Google Git
Sign in
android / platform / tools / base / studio-master-dev / . / lint / libs / lint-tests / src / test / java / com / android / tools / lint / checks / GradleDetectorTest.kt
blob: dbf28ae9813e697639095885b0118b11a597bf5a [file] [log] [blame]
/*
* Copyright (C) 2014 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.tools.lint.checks
import com.android.SdkConstants.GRADLE_PLUGIN_MINIMUM_VERSION
import com.android.SdkConstants.GRADLE_PLUGIN_RECOMMENDED_VERSION
import com.android.ide.common.repository.GoogleMavenRepository.Companion.MAVEN_GOOGLE_CACHE_DIR_KEY
import com.android.ide.common.repository.GradleCoordinate
import com.android.ide.common.repository.GradleVersion
import com.android.sdklib.AndroidVersion
import com.android.sdklib.IAndroidTarget
import com.android.sdklib.SdkVersionInfo.LOWEST_ACTIVE_API
import com.android.testutils.TestUtils
import com.android.tools.lint.checks.GradleDetector.Companion.ACCIDENTAL_OCTAL
import com.android.tools.lint.checks.GradleDetector.Companion.ANNOTATION_PROCESSOR_ON_COMPILE_PATH
import com.android.tools.lint.checks.GradleDetector.Companion.BUNDLED_GMS
import com.android.tools.lint.checks.GradleDetector.Companion.COMPATIBILITY
import com.android.tools.lint.checks.GradleDetector.Companion.DATA_BINDING_WITHOUT_KAPT
import com.android.tools.lint.checks.GradleDetector.Companion.DEPENDENCY
import com.android.tools.lint.checks.GradleDetector.Companion.DEPRECATED
import com.android.tools.lint.checks.GradleDetector.Companion.DEPRECATED_CONFIGURATION
import com.android.tools.lint.checks.GradleDetector.Companion.DEPRECATED_LIBRARY
import com.android.tools.lint.checks.GradleDetector.Companion.DEV_MODE_OBSOLETE
import com.android.tools.lint.checks.GradleDetector.Companion.DUPLICATE_CLASSES
import com.android.tools.lint.checks.GradleDetector.Companion.EXPIRED_TARGET_SDK_VERSION
import com.android.tools.lint.checks.GradleDetector.Companion.EXPIRING_TARGET_SDK_VERSION
import com.android.tools.lint.checks.GradleDetector.Companion.GRADLE_GETTER
import com.android.tools.lint.checks.GradleDetector.Companion.GRADLE_PLUGIN_COMPATIBILITY
import com.android.tools.lint.checks.GradleDetector.Companion.HIGH_APP_VERSION_CODE
import com.android.tools.lint.checks.GradleDetector.Companion.KTX_EXTENSION_AVAILABLE
import com.android.tools.lint.checks.GradleDetector.Companion.LIFECYCLE_ANNOTATION_PROCESSOR_WITH_JAVA8
import com.android.tools.lint.checks.GradleDetector.Companion.MIN_SDK_TOO_LOW
import com.android.tools.lint.checks.GradleDetector.Companion.NOT_INTERPOLATED
import com.android.tools.lint.checks.GradleDetector.Companion.PATH
import com.android.tools.lint.checks.GradleDetector.Companion.PLUS
import com.android.tools.lint.checks.GradleDetector.Companion.REMOTE_VERSION
import com.android.tools.lint.checks.GradleDetector.Companion.RISKY_LIBRARY
import com.android.tools.lint.checks.GradleDetector.Companion.STRING_INTEGER
import com.android.tools.lint.checks.GradleDetector.Companion.getNamedDependency
import com.android.tools.lint.checks.infrastructure.TestIssueRegistry
import com.android.tools.lint.checks.infrastructure.TestLintTask
import com.android.tools.lint.checks.infrastructure.TestResultTransformer
import com.android.tools.lint.detector.api.Detector
import com.android.tools.lint.detector.api.Implementation
import com.android.tools.lint.detector.api.Project
import com.android.tools.lint.detector.api.Scope
import com.android.utils.FileUtils
import junit.framework.TestCase
import org.mockito.Mockito.`when`
import org.mockito.Mockito.mock
import java.io.File
import java.io.IOException
import java.util.Calendar
import java.util.Locale
import java.util.function.Predicate
/**
* NOTE: Many of these tests are duplicated in the Android Studio plugin to test the custom
* GradleDetector subclass, LintIdeGradleDetector, which customizes some behavior to be based on top
* of PSI rather than the Groovy parser.
*/
class GradleDetectorTest : AbstractCheckTest() {
private val mDependencies = source(
"build.gradle",
"" +
"apply plugin: 'android'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 19\n" +
" buildToolsVersion \"19.0.0\"\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 7\n" +
" targetSdkVersion 17\n" +
" versionCode 1\n" +
" versionName \"1.0\"\n" +
" }\n" +
"\n" +
" productFlavors {\n" +
" free {\n" +
" }\n" +
" pro {\n" +
" }\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.android.support:appcompat-v7:+'\n" +
" freeCompile 'com.google.guava:guava:11.0.2'\n" +
" compile 'com.android.support:appcompat-v7:13.0.0'\n" +
" compile 'com.google.android.support:wearable:1.2.0'\n" +
" compile 'com.android.support:multidex:1.0.0'\n" +
"\n" +
" androidTestCompile 'com.android.support.test:runner:0.3'\n" +
"}\n"
)
override fun tearDown() {
super.tearDown()
if (sdkRootDir != null) {
deleteFile(sdkRootDir)
sdkRootDir = null
}
}
override fun lint(): TestLintTask {
val task = super.lint()
task.sdkHome(mockSupportLibraryInstallation)
initializeNetworkMocksAndCaches(task)
return task
}
fun testBasic() {
val expected = "" +
"build.gradle:25: Error: This support library should not use a different version (13) than the compileSdkVersion (19) [GradleCompatible]\n" +
" compile 'com.android.support:appcompat-v7:13.0.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:1: Warning: 'android' is deprecated; use 'com.android.application' instead [GradleDeprecated]\n" +
"apply plugin: 'android'\n" +
"~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:5: Warning: Old buildToolsVersion 19.0.0; recommended version is 19.1 or later [GradleDependency]\n" +
" buildToolsVersion \"19.0.0\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:24: Warning: A newer version of com.google.guava:guava than 11.0.2 is available: 21.0 [GradleDependency]\n" +
" freeCompile 'com.google.guava:guava:11.0.2'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:25: Warning: A newer version of com.android.support:appcompat-v7 than 13.0.0 is available: 19.1.0 [GradleDependency]\n" +
" compile 'com.android.support:appcompat-v7:13.0.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:26: Warning: A newer version of com.google.android.support:wearable than 1.2.0 is available: 1.3.0 [GradleDependency]\n" +
" compile 'com.google.android.support:wearable:1.2.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:27: Warning: A newer version of com.android.support:multidex than 1.0.0 is available: 1.0.1 [GradleDependency]\n" +
" compile 'com.android.support:multidex:1.0.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:29: Warning: A newer version of com.android.support.test:runner than 0.3 is available: 0.5 [GradleDependency]\n" +
" androidTestCompile 'com.android.support.test:runner:0.3'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:23: Warning: Avoid using + in version numbers; can lead to unpredictable and unrepeatable builds (com.android.support:appcompat-v7:+) [GradleDynamicVersion]\n" +
" compile 'com.android.support:appcompat-v7:+'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 8 warnings\n"
lint().files(mDependencies)
.issues(COMPATIBILITY, DEPRECATED, DEPENDENCY, PLUS)
.sdkHome(mockSupportLibraryInstallation)
.run()
.expect(expected)
.expectFixDiffs(
"" +
"Fix for build.gradle line 24: Replace with 19.1.0:\n" +
"@@ -25 +25\n" +
"- compile 'com.android.support:appcompat-v7:13.0.0'\n" +
"+ compile 'com.android.support:appcompat-v7:19.1.0'\n" +
"Fix for build.gradle line 0: Replace with com.android.application:\n" +
"@@ -1 +1\n" +
"- apply plugin: 'android'\n" +
"+ apply plugin: 'com.android.application'\n" +
"Fix for build.gradle line 4: Change to 19.1:\n" +
"@@ -5 +5\n" +
"- buildToolsVersion \"19.0.0\"\n" +
"+ buildToolsVersion \"19.1\"\n" +
"Fix for build.gradle line 23: Change to 21.0:\n" +
"@@ -24 +24\n" +
"- freeCompile 'com.google.guava:guava:11.0.2'\n" +
"+ freeCompile 'com.google.guava:guava:21.0'\n" +
"Fix for build.gradle line 24: Change to 19.1.0:\n" +
"@@ -25 +25\n" +
"- compile 'com.android.support:appcompat-v7:13.0.0'\n" +
"+ compile 'com.android.support:appcompat-v7:19.1.0'\n" +
"Fix for build.gradle line 25: Change to 1.3.0:\n" +
"@@ -26 +26\n" +
"- compile 'com.google.android.support:wearable:1.2.0'\n" +
"+ compile 'com.google.android.support:wearable:1.3.0'\n" +
"Fix for build.gradle line 26: Change to 1.0.1:\n" +
"@@ -27 +27\n" +
"- compile 'com.android.support:multidex:1.0.0'\n" +
"+ compile 'com.android.support:multidex:1.0.1'\n" +
"Fix for build.gradle line 28: Change to 0.5:\n" +
"@@ -29 +29\n" +
"- androidTestCompile 'com.android.support.test:runner:0.3'\n" +
"+ androidTestCompile 'com.android.support.test:runner:0.5'\n" +
"Data for build.gradle line 22: GradleCoordinate : com.android.support:appcompat-v7:+"
)
}
fun testVersionsFromGradleCache() {
val expected = "" +
"build.gradle:7: Warning: A newer version of com.android.tools.build:gradle than 2.4.0-alpha3 is available: 3.5.0-alpha10 [GradleDependency]\n" +
" classpath 'com.android.tools.build:gradle:2.4.0-alpha3'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:11: Warning: A newer version of org.apache.httpcomponents:httpcomponents-core than 4.2 is available: 4.4 [GradleDependency]\n" +
" compile 'org.apache.httpcomponents:httpcomponents-core:4.2'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:12: Warning: A newer version of com.android.support:recyclerview-v7 than 25.0.0 is available: 26.0.0 [GradleDependency]\n" +
" compile 'com.android.support:recyclerview-v7:25.0.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:13: Warning: A newer version of com.google.firebase:firebase-messaging than 10.2.1 is available: 11.0.0 [GradleDependency]\n" +
" compile 'com.google.firebase:firebase-messaging:10.2.1'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 4 warnings\n"
lint().files(
gradle(
"" +
"buildscript {\n" +
" repositories {\n" +
" google()\n" +
" jcenter()\n" +
" }\n" +
" dependencies {\n" +
" classpath 'com.android.tools.build:gradle:2.4.0-alpha3'\n" +
" }\n" +
"}\n" +
"dependencies {\n" +
" compile 'org.apache.httpcomponents:httpcomponents-core:4.2'\n" +
" compile 'com.android.support:recyclerview-v7:25.0.0'\n" +
" compile 'com.google.firebase:firebase-messaging:10.2.1'\n" +
"}\n"
)
)
.issues(DEPENDENCY)
.run()
.expect(expected)
.expectFixDiffs(
"" +
"Fix for build.gradle line 7: Change to 3.5.0-alpha10:\n" +
"@@ -7 +7\n" +
"- classpath 'com.android.tools.build:gradle:2.4.0-alpha3'\n" +
"+ classpath 'com.android.tools.build:gradle:3.5.0-alpha10'\n" +
"Fix for build.gradle line 11: Change to 4.4:\n" +
"@@ -11 +11\n" +
"- compile 'org.apache.httpcomponents:httpcomponents-core:4.2'\n" +
"+ compile 'org.apache.httpcomponents:httpcomponents-core:4.4'\n" +
"Fix for build.gradle line 12: Change to 26.0.0:\n" +
"@@ -12 +12\n" +
"- compile 'com.android.support:recyclerview-v7:25.0.0'\n" +
"+ compile 'com.android.support:recyclerview-v7:26.0.0'\n" +
"Fix for build.gradle line 13: Change to 11.0.0:\n" +
"@@ -13 +13\n" +
"- compile 'com.google.firebase:firebase-messaging:10.2.1'\n" +
"+ compile 'com.google.firebase:firebase-messaging:11.0.0'\n"
)
}
fun testMoreRecentStableVersion() {
lint().files(
gradle(
"" +
"buildscript {\n" +
" repositories {\n" +
" google()\n" +
" jcenter()\n" +
" }\n" +
" dependencies {\n" +
" classpath 'com.android.tools.build:gradle:3.0.0'\n" +
" classpath 'com.android.tools.build:gradle:3.0.+'\n" +
" classpath 'com.android.tools.build:gradle:3.+'\n" +
" }\n" +
"}\n"
)
)
.issues(DEPENDENCY)
.sdkHome(mockSupportLibraryInstallation)
.run()
.expect(
"" +
"build.gradle:7: Warning: A newer version of com.android.tools.build:gradle than 3.0.0 is available: 3.3.2. (There is also a newer version of 3.0.\uD835\uDC65 available, if upgrading to 3.3.2 is difficult: 3.0.1) [GradleDependency]\n" +
" classpath 'com.android.tools.build:gradle:3.0.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings"
)
.expectFixDiffs(
"" +
"Fix for build.gradle line 7: Change to 3.3.2:\n" +
"@@ -7 +7\n" +
"- classpath 'com.android.tools.build:gradle:3.0.0'\n" +
"+ classpath 'com.android.tools.build:gradle:3.3.2'\n" +
"Fix for build.gradle line 7: Change to 3.0.1:\n" +
"@@ -7 +7\n" +
"- classpath 'com.android.tools.build:gradle:3.0.0'\n" +
"+ classpath 'com.android.tools.build:gradle:3.0.1'"
)
}
fun testDependenciesWithCallSyntax() {
// Regression test for 134692580
val expected = "" +
"build.gradle:7: Warning: A newer version of com.google.firebase:firebase-messaging than 10.2.1 is available: 11.0.0 [GradleDependency]\n" +
" implementation(\"com.google.firebase:firebase-messaging:10.2.1\")\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings"
lint().files(
gradle(
"" +
"buildscript {\n" +
" repositories {\n" +
" jcenter()\n" +
" }\n" +
"}\n" +
"dependencies {\n" +
" implementation(\"com.google.firebase:firebase-messaging:10.2.1\")\n" +
"}\n"
)
)
.issues(DEPENDENCY)
.run()
.expect(expected)
.expectFixDiffs(
"" +
"Fix for build.gradle line 7: Change to 11.0.0:\n" +
"@@ -7 +7\n" +
"- implementation(\"com.google.firebase:firebase-messaging:10.2.1\")\n" +
"+ implementation(\"com.google.firebase:firebase-messaging:11.0.0\")"
)
}
fun testDependenciesWithOtherArtifacts() {
// Regression test for b/124415929
listOf(
"implementation",
"testImplementation",
"androidTestImplementation"
).forEach { configuration ->
listOf(
"com.android.support:appcompat-v7" to ("13.0.0" to "25.3.1"),
"com.google.guava:guava" to ("11.0.2" to "21.0")
)
.forEach { libraryInfo ->
val library = libraryInfo.first
val version = libraryInfo.second.first
val expectedVersion = libraryInfo.second.second
listOf(false, true).forEach {
val versionString = if (it) "\$version" else version
val dependencyString = "$configuration(\"$library:$versionString\")"
println(dependencyString)
val source = gradle(
"" +
"ext.version = '$version'\n" +
"\n" +
"buildscript {\n" +
" repositories {\n" +
" jcenter()\n" +
" }\n" +
"}\n" +
"dependencies {\n" +
" $dependencyString\n" +
"}\n"
)
val expected = "" +
"build.gradle:9: Warning: A newer version of $library than $version is available: $expectedVersion [GradleDependency]\n" +
" $dependencyString\n" +
" ${"~".repeat(dependencyString.length)}\n" +
"0 errors, 1 warnings"
lint().files(source).issues(DEPENDENCY).run().expect(expected)
}
}
}
}
fun testVersionFromIDE() {
// Hardcoded cache lookup for the test in GroovyGradleDetector below. In the IDE
// it consults SDK lib.
val expected = "" +
"build.gradle:2: Warning: A newer version of com.android.support.constraint:constraint-layout than 1.0.1 is available: 1.0.2 [GradleDependency]\n" +
" compile 'com.android.support.constraint:constraint-layout:1.0.1'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:4: Warning: A newer version of com.android.support.constraint:constraint-layout than 1.0.3-alpha5 is available: 1.0.3-alpha8 [GradleDependency]\n" +
" compile 'com.android.support.constraint:constraint-layout:1.0.3-alpha5'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 2 warnings\n"
lint().files(
gradle(
"" +
"dependencies {\n" +
" compile 'com.android.support.constraint:constraint-layout:1.0.1'\n" +
" compile 'com.android.support.constraint:constraint-layout:1.0.2'\n" +
" compile 'com.android.support.constraint:constraint-layout:1.0.3-alpha5'\n" +
" compile 'com.android.support.constraint:constraint-layout:1.0.+'\n" +
"}\n"
)
).issues(DEPENDENCY).run().expect(expected)
}
fun testQvsAndroidX() {
// Regression test for 128648458: Lint Warning to update appCompat in Q
val expected = "" +
"build.gradle:13: Error: Version 28 (intended for Android Pie and below) is the last version of the legacy support library, so we recommend that you migrate to AndroidX libraries when using Android Q and moving forward. The IDE can help with this: Refactor > Migrate to AndroidX... [GradleCompatible]\n" +
" implementation 'com.android.support:appcompat-v7:28.0.0' \n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 'android-Q'\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 19\n" +
" targetSdkVersion 'Q'\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" implementation 'com.android.support:appcompat-v7:28.0.0' \n" +
"}\n"
)
).issues(COMPATIBILITY).run().expect(expected)
}
fun testCompatibility() {
val expected = "" +
"build.gradle:4: Error: The compileSdkVersion (18) should not be lower than the targetSdkVersion (19) [GradleCompatible]\n" +
" compileSdkVersion 18\n" +
" ~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 18\n" +
" buildToolsVersion \"19.0.0\"\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 7\n" +
" targetSdkVersion 19\n" +
" versionCode 1\n" +
" versionName \"1.0\"\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.android.support:support-v4:18.0.0'\n" +
" compile 'com.android.support.test:espresso:0.2'\n" +
" compile 'com.android.support:multidex:1.0.1'\n" +
" compile 'com.android.support:multidex-instrumentation:1.0.1'\n" +
"\n" +
" // Suppressed:\n" +
" //noinspection GradleCompatible\n" +
" compile 'com.android.support:support-v4:18.0.0'\n" +
"}\n"
)
).issues(COMPATIBILITY).run().expect(expected).expectFixDiffs(
"" +
"Fix for build.gradle line 3: Set compileSdkVersion to 19:\n" +
"@@ -4 +4\n" +
"- compileSdkVersion 18\n" +
"+ compileSdkVersion 19\n"
)
}
fun testMinSdkVersion() {
val expectedNewVersion = LOWEST_ACTIVE_API.toString()
val expected = ("" +
"build.gradle:8: Warning: The value of minSdkVersion is too low. It can be incremented without noticeably reducing the number of supported devices. [MinSdkTooLow]\n" +
" minSdkVersion 7\n" +
" ~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings\n")
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 19\n" +
" buildToolsVersion \"19.0.0\"\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 7\n" +
" targetSdkVersion 19\n" +
" versionCode 1\n" +
" versionName \"1.0\"\n" +
" }\n" +
"}\n"
)
).issues(MIN_SDK_TOO_LOW).run().expect(expected).expectFixDiffs(
"" +
"Fix for build.gradle line 7: Update minSdkVersion to 16:\n" +
"@@ -8 +8\n" +
"- minSdkVersion 7\n" +
"+ minSdkVersion " +
expectedNewVersion +
"\n"
)
}
fun testIncompatiblePlugin() {
val expected = "" +
"build.gradle:6: Error: You must use a newer version of the Android Gradle plugin. The minimum supported version is " +
GRADLE_PLUGIN_MINIMUM_VERSION +
" and the recommended version is " +
GRADLE_PLUGIN_RECOMMENDED_VERSION +
" [GradlePluginVersion]\n" +
" classpath 'com.android.tools.build:gradle:0.1.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"buildscript {\n" +
" repositories {\n" +
" mavenCentral()\n" +
" }\n" +
" dependencies {\n" +
" classpath 'com.android.tools.build:gradle:0.1.0'\n" +
" }\n" +
"}\n" +
"\n" +
"allprojects {\n" +
" repositories {\n" +
" mavenCentral()\n" +
" }\n" +
"}\n"
)
).issues(GRADLE_PLUGIN_COMPATIBILITY).run().expect(expected)
}
fun testTooRecentVersion() {
// Regression test for https://issuetracker.google.com/119210741
// Don't offer Gradle plugin versions newer than the IDE (when running in the IDE)
// Same (older) version of Studio and Gradle:
// Studio 3.0, gradle: 3.0.0-alpha4: Offer latest 3.0.0, not 3.1 or 3.2 etc
val expected = "" +
"build.gradle:7: Warning: A newer version of com.android.tools.build:gradle than 3.0.0-alpha4 is available: 3.0.1 [GradleDependency]\n" +
" classpath 'com.android.tools.build:gradle:3.0.0-alpha4'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings"
lint().files(
gradle(
"""
buildscript {
repositories {
google()
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.0.0-alpha4'
}
}
allprojects {
repositories {
mavenCentral()
}
}
"""
).indented()
).issues(DEPENDENCY)
.client(object :
com.android.tools.lint.checks.infrastructure.TestLintClient(CLIENT_STUDIO) {
// Studio 3.0.0
override fun getClientRevision(): String? = "3.0.0.0"
})
.run().expect(expected)
}
fun testTooRecentVersion2() {
// Regression test for https://issuetracker.google.com/119210741
// Don't offer Gradle plugin versions newer than the IDE (when running in the IDE)
// Newer Studio than Gradle:
// Studio 3.1, Gradle 3.0: Offer 3.1
lint().files(
gradle(
"""
buildscript {
repositories {
google()
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.0.0-alpha01'
}
}
allprojects {
repositories {
mavenCentral()
}
}
"""
).indented()
).issues(DEPENDENCY)
.client(object :
com.android.tools.lint.checks.infrastructure.TestLintClient(CLIENT_STUDIO) {
// Studio 3.0.0
override fun getClientRevision(): String? = "3.1.0"
})
.run().expect(
"" +
"build.gradle:7: Warning: A newer version of com.android.tools.build:gradle than 3.0.0-alpha01 is available: 3.1.0 [GradleDependency]\n" +
" classpath 'com.android.tools.build:gradle:3.0.0-alpha01'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings"
)
}
fun testTooRecentVersion3() {
// Regression test for https://issuetracker.google.com/119210741
// Older Studio than Gradle:
// Studio 2.3, gradle: 3.0.0-alpha4: Already using Gradle 3.0: offer latest version of it
lint().files(
gradle(
"""
buildscript {
repositories {
google()
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.0.0-alpha4'
}
}
allprojects {
repositories {
mavenCentral()
}
}
"""
).indented()
).issues(DEPENDENCY)
.client(object :
com.android.tools.lint.checks.infrastructure.TestLintClient(CLIENT_STUDIO) {
// Studio 3.0.0
override fun getClientRevision(): String? = "2.3.0.0"
})
.run().expect(
"""
build.gradle:7: Warning: A newer version of com.android.tools.build:gradle than 3.0.0-alpha4 is available: 3.0.1 [GradleDependency]
classpath 'com.android.tools.build:gradle:3.0.0-alpha4'
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
0 errors, 1 warnings
"""
)
}
fun testSetter() {
val expected = "" +
"build.gradle:18: Error: Bad method name: pick a unique method name which does not conflict with the implicit getters for the defaultConfig properties. For example, try using the prefix compute- instead of get-. [GradleGetter]\n" +
" versionCode getVersionCode\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:19: Error: Bad method name: pick a unique method name which does not conflict with the implicit getters for the defaultConfig properties. For example, try using the prefix compute- instead of get-. [GradleGetter]\n" +
" versionName getVersionName\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"2 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"def getVersionName() {\n" +
" \"1.0\"\n" +
"}\n" +
"\n" +
"def getVersionCode() {\n" +
" 50\n" +
"}\n" +
"\n" +
"android {\n" +
" compileSdkVersion 19\n" +
" buildToolsVersion \"19.0.0\"\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 7\n" +
" targetSdkVersion 17\n" +
" versionCode getVersionCode\n" +
" versionName getVersionName\n" +
" }\n" +
"}\n"
)
).issues(GRADLE_GETTER).ignoreUnknownGradleConstructs().run().expect(expected)
}
fun testDependencies() {
val expected = "" +
"build.gradle:5: Warning: Old buildToolsVersion 19.0.0; recommended version is 19.1 or later [GradleDependency]\n" +
" buildToolsVersion \"19.0.0\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:24: Warning: A newer version of com.google.guava:guava than 11.0.2 is available: 21.0 [GradleDependency]\n" +
" freeCompile 'com.google.guava:guava:11.0.2'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:25: Warning: A newer version of com.android.support:appcompat-v7 than 13.0.0 is available: 19.1.0 [GradleDependency]\n" +
" compile 'com.android.support:appcompat-v7:13.0.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:26: Warning: A newer version of com.google.android.support:wearable than 1.2.0 is available: 1.3.0 [GradleDependency]\n" +
" compile 'com.google.android.support:wearable:1.2.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:27: Warning: A newer version of com.android.support:multidex than 1.0.0 is available: 1.0.1 [GradleDependency]\n" +
" compile 'com.android.support:multidex:1.0.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:29: Warning: A newer version of com.android.support.test:runner than 0.3 is available: 0.5 [GradleDependency]\n" +
" androidTestCompile 'com.android.support.test:runner:0.3'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 6 warnings\n"
lint().files(mDependencies).issues(DEPENDENCY).run().expect(expected)
}
fun testLongHandDependencies() {
val expected = "" +
"build.gradle:9: Warning: A newer version of com.android.support:support-v4 than 19.0 is available: 21.0.2 [GradleDependency]\n" +
" compile group: 'com.android.support', name: 'support-v4', version: '19.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 21\n" +
" buildToolsVersion \"21.1.2\"\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile group: 'com.android.support', name: 'support-v4', version: '19.0'\n" +
"}\n"
)
).issues(DEPENDENCY).run().expect(expected)
}
fun testDependenciesMinSdkVersion() {
val expected = "" +
"build.gradle:13: Warning: Using the appcompat library when minSdkVersion >= 14 and compileSdkVersion < 21 is not necessary [GradleDependency]\n" +
" compile 'com.android.support:appcompat-v7:+'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 19\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" targetSdkVersion 17\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.android.support:appcompat-v7:+'\n" +
"}\n"
)
).issues(DEPENDENCY).run().expect(expected)
}
fun testNoWarningFromUnknownSupportLibrary() {
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 21\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" targetSdkVersion 17\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.google.android.gms:play-services-appindexing:9.8.0'\n" +
" compile 'com.android.support:appcompat-v7:25.0.0'\n" +
"}\n"
)
).issues(DEPENDENCY).sdkHome(sdkDirWithoutSupportLib).run().expectClean()
}
fun testDependenciesMinSdkVersionLollipop() {
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 21\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" targetSdkVersion 17\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.android.support:appcompat-v7:+'\n" +
"}\n"
)
).issues(DEPENDENCY).run().expectClean()
}
fun testDependenciesNoMicroVersion() {
// Regression test for https://code.google.com/p/android/issues/detail?id=77594
val expected = "" +
"build.gradle:13: Warning: A newer version of com.google.code.gson:gson than 2.2 is available: 2.8.2 [GradleDependency]\n" +
" compile 'com.google.code.gson:gson:2.2'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 19\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" targetSdkVersion 17\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.google.code.gson:gson:2.2'\n" +
"}\n"
)
).issues(DEPENDENCY).run().expect(expected)
}
fun testPaths() {
val expected = "" +
"build.gradle:4: Warning: Do not use Windows file separators in .gradle files; use / instead [GradlePath]\n" +
" compile files('my\\\\libs\\\\http.jar')\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:5: Warning: Avoid using absolute paths in .gradle files [GradlePath]\n" +
" compile files('/libs/android-support-v4.jar')\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 2 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"dependencies {\n" +
" compile files('my\\\\libs\\\\http.jar')\n" +
" compile files('/libs/android-support-v4.jar')\n" +
"}\n"
)
).issues(PATH).ignoreUnknownGradleConstructs().run().expect(expected).expectFixDiffs(
"""
Fix for build.gradle line 4: Replace with my/libs/http.jar:
@@ -4 +4
- compile files('my\\libs\\http.jar')
+ compile files('my/libs/http.jar')
"""
)
}
fun testIdSuffix() {
val expected = "" +
"build.gradle:6: Warning: Application ID suffix should probably start with a \".\" [GradlePath]\n" +
" applicationIdSuffix \"debug\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" buildTypes {\n" +
" debug {\n" +
" applicationIdSuffix \"debug\"\n" +
" }\n" +
" }\n" +
"}\n"
)
).issues(PATH).run().expect(expected)
}
fun testPackage() {
val expected = "" +
"build.gradle:5: Warning: Deprecated: Replace 'packageName' with 'applicationId' [GradleDeprecated]\n" +
" packageName 'my.pkg'\n" +
" ~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:9: Warning: Deprecated: Replace 'packageNameSuffix' with 'applicationIdSuffix' [GradleDeprecated]\n" +
" packageNameSuffix \".debug\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 2 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" defaultConfig {\n" +
" packageName 'my.pkg'\n" +
" }\n" +
" buildTypes {\n" +
" debug {\n" +
" packageNameSuffix \".debug\"\n" +
" }\n" +
" }\n" +
"}\n"
)
).issues(DEPRECATED).run().expect(expected).expectFixDiffs(
"Fix for build.gradle line 5: Replace 'packageName' with 'applicationId':\n" +
"@@ -5 +5\n" +
"- packageName 'my.pkg'\n" +
"+ applicationId 'my.pkg'\n" +
"Fix for build.gradle line 9: Replace 'packageNameSuffix' with 'applicationIdSuffix':\n" +
"@@ -9 +9\n" +
"- packageNameSuffix \".debug\"\n" +
"+ applicationIdSuffix \".debug\""
)
}
fun testPlus() {
val expected = "" +
"build.gradle:9: Warning: Avoid using + in version numbers; can lead to unpredictable and unrepeatable builds (com.android.support:appcompat-v7:+) [GradleDynamicVersion]\n" +
" compile 'com.android.support:appcompat-v7:+'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:10: Warning: Avoid using + in version numbers; can lead to unpredictable and unrepeatable builds (com.android.support:support-v4:21.0.+) [GradleDynamicVersion]\n" +
" compile group: 'com.android.support', name: 'support-v4', version: '21.0.+'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:11: Warning: Avoid using + in version numbers; can lead to unpredictable and unrepeatable builds (com.android.support:appcompat-v7:+@aar) [GradleDynamicVersion]\n" +
" compile 'com.android.support:appcompat-v7:+@aar'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 3 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 19\n" +
" buildToolsVersion \"19.0.1\"\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.android.support:appcompat-v7:+'\n" +
" compile group: 'com.android.support', name: 'support-v4', version: '21.0.+'\n" +
" compile 'com.android.support:appcompat-v7:+@aar'\n" +
"}\n"
)
).issues(PLUS).run().expect(expected)
}
fun testStringInt() {
val expected = "" +
"build.gradle:4: Error: Use an integer rather than a string here (replace '19' with just 19) [StringShouldBeInt]\n" +
" compileSdkVersion '19'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:7: Error: Use an integer rather than a string here (replace '8' with just 8) [StringShouldBeInt]\n" +
" minSdkVersion '8'\n" +
" ~~~~~~~~~~~~~~~~~\n" +
"build.gradle:8: Error: Use an integer rather than a string here (replace \"16\" with just 16) [StringShouldBeInt]\n" +
" targetSdkVersion \"16\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~\n" +
"3 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion '19'\n" +
" buildToolsVersion \"19.0.1\"\n" +
" defaultConfig {\n" +
" minSdkVersion '8'\n" +
" targetSdkVersion \"16\"\n" +
" }\n" +
"}\n"
)
).issues(STRING_INTEGER).run().expect(expected).expectFixDiffs(
"" +
"Fix for build.gradle line 3: Replace with integer:\n" +
"@@ -4 +4\n" +
"- compileSdkVersion '19'\n" +
"+ compileSdkVersion 19\n" +
"Fix for build.gradle line 6: Replace with integer:\n" +
"@@ -7 +7\n" +
"- minSdkVersion '8'\n" +
"+ minSdkVersion 8\n" +
"Fix for build.gradle line 7: Replace with integer:\n" +
"@@ -8 +8\n" +
"- targetSdkVersion \"16\"\n" +
"+ targetSdkVersion 16\n"
)
}
fun testSuppressLine2() {
lint().files(
gradle(
"" +
"//noinspection GradleDeprecated\n" +
"apply plugin: 'android'\n" +
"\n" +
"android {\n" +
"}\n"
)
).run().expectClean()
}
fun testDeprecatedPluginId() {
val expected = "" +
"build.gradle:4: Warning: 'android' is deprecated; use 'com.android.application' instead [GradleDeprecated]\n" +
"apply plugin: 'android'\n" +
"~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:5: Warning: 'android-library' is deprecated; use 'com.android.library' instead [GradleDeprecated]\n" +
"apply plugin: 'android-library'\n" +
"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 2 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"apply plugin: 'com.android.library'\n" +
"apply plugin: 'java'\n" +
"apply plugin: 'android'\n" +
"apply plugin: 'android-library'\n" +
"\n" +
"android {\n" +
"}\n"
)
).issues(DEPRECATED).ignoreUnknownGradleConstructs().run().expect(expected).expectFixDiffs(
"" +
"Fix for build.gradle line 3: Replace with com.android.application:\n" +
"@@ -4 +4\n" +
"- apply plugin: 'android'\n" +
"+ apply plugin: 'com.android.application'\n" +
"Fix for build.gradle line 4: Replace with com.android.library:\n" +
"@@ -5 +5\n" +
"- apply plugin: 'android-library'\n" +
"+ apply plugin: 'com.android.library'\n"
)
}
fun testIgnoresGStringsInDependencies() {
lint().files(
gradle(
"" +
"buildscript {\n" +
" ext.androidGradleVersion = '0.11.0'\n" +
" dependencies {\n" +
" classpath \"com.android.tools.build:gradle:\$androidGradleVersion\"\n" +
" }\n" +
"}\n"
)
).ignoreUnknownGradleConstructs().run().expectClean()
}
fun testAccidentalOctal() {
val expected = "" +
"build.gradle:13: Error: The leading 0 turns this number into octal which is probably not what was intended (interpreted as 8) [AccidentalOctal]\n" +
" versionCode 010\n" +
" ~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" defaultConfig {\n" +
" // Ok: not octal\n" +
" versionCode 1\n" +
" versionCode 10\n" +
" versionCode 100\n" +
" // ok: octal == decimal\n" +
" versionCode 01\n" +
"\n" +
" // Errors\n" +
" versionCode 010\n" +
"\n" +
" // Lint Groovy Bug:\n" +
" versionCode 01 // line suffix comments are not handled correctly\n" +
" }\n" +
"}\n"
)
).issues(ACCIDENTAL_OCTAL).run().expect(expected)
}
fun testBadPlayServicesVersion() {
val expected = "" +
"build.gradle:5: Error: Version 5.2.08 should not be used; the app can not be published with this version. Use version 11.1.71 instead. [GradleCompatible]\n" +
" compile 'com.google.android.gms:play-services:5.2.08'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'android'\n" +
"\n" +
"dependencies {\n" +
"\n" +
" compile 'com.google.android.gms:play-services:5.2.08'\n" +
"}\n"
)
).issues(COMPATIBILITY).run().expect(expected).expectFixDiffs(
"" +
"Fix for build.gradle line 4: Change to 11.1.71:\n" +
"@@ -5 +5\n" +
"- compile 'com.google.android.gms:play-services:5.2.08'\n" +
"+ compile 'com.google.android.gms:play-services:11.1.71'\n"
)
}
fun testRemoteVersions() {
val expected = "" +
"build.gradle:9: Warning: A newer version of joda-time:joda-time than 2.1 is available: 2.9.9 [NewerVersionAvailable]\n" +
" compile 'joda-time:joda-time:2.1'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:10: Warning: A newer version of com.squareup.dagger:dagger than 1.2.0 is available: 1.2.5 [NewerVersionAvailable]\n" +
" compile 'com.squareup.dagger:dagger:1.2.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 2 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 19\n" +
" buildToolsVersion \"19.0.0\"\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'joda-time:joda-time:2.1'\n" +
" compile 'com.squareup.dagger:dagger:1.2.0'\n" +
"}\n"
)
)
.networkData(
"http://search.maven.org/solrsearch/select?q=g:%22joda-time%22+AND+a:%22joda-time%22&core=gav&wt=json",
"" +
"{\"responseHeader\":" +
"{\"status\":0,\"QTime\":0,\"params\":" +
"{\"fl\":\"id,g,a,v,p,ec,timestamp,tags\",\"sort\":\"score desc,timestamp desc,g asc,a asc,v desc\",\"indent\":\"off\",\"q\":\"g:\\\"joda-time\\\" AND a:\\\"joda-time\\\"\",\"core\":\"gav\",\"wt\":\"json\",\"version\":\"2.2\"}}," +
"\"response\":" +
"{\"numFound\":34,\"start\":0,\"docs\":[" +
"{\"id\":\"joda-time:joda-time:2.9.9\",\"g\":\"joda-time\",\"a\":\"joda-time\",\"v\":\"2.9.9\",\"p\":\"jar\",\"timestamp\":1490275993000,\"tags\":[\"replace\",\"time\",\"library\",\"date\",\"handling\"],\"ec\":[\"-no-tzdb.jar\",\"-sources.jar\",\"-no-tzdb-javadoc.jar\",\"-javadoc.jar\",\"-no-tzdb-sources.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"joda-time:joda-time:2.9.8\",\"g\":\"joda-time\",\"a\":\"joda-time\",\"v\":\"2.9.8\",\"p\":\"jar\",\"timestamp\":1490220931000,\"tags\":[\"replace\",\"time\",\"library\",\"date\",\"handling\"],\"ec\":[\"-no-tzdb.jar\",\"-sources.jar\",\"-no-tzdb-javadoc.jar\",\"-javadoc.jar\",\"-no-tzdb-sources.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"joda-time:joda-time:2.9.7\",\"g\":\"joda-time\",\"a\":\"joda-time\",\"v\":\"2.9.7\",\"p\":\"jar\",\"timestamp\":1482188123000,\"tags\":[\"replace\",\"time\",\"library\",\"date\",\"handling\"],\"ec\":[\"-javadoc.jar\",\"-no-tzdb-javadoc.jar\",\"-sources.jar\",\"-no-tzdb.jar\",\"-no-tzdb-sources.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"joda-time:joda-time:2.9.6\",\"g\":\"joda-time\",\"a\":\"joda-time\",\"v\":\"2.9.6\",\"p\":\"jar\",\"timestamp\":1478812169000,\"tags\":[\"replace\",\"time\",\"library\",\"date\",\"handling\"],\"ec\":[\"-no-tzdb-javadoc.jar\",\"-no-tzdb.jar\",\"-sources.jar\",\"-javadoc.jar\",\"-no-tzdb-sources.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"joda-time:joda-time:2.9.5\",\"g\":\"joda-time\",\"a\":\"joda-time\",\"v\":\"2.9.5\",\"p\":\"jar\",\"timestamp\":1478191007000,\"tags\":[\"replace\",\"time\",\"library\",\"date\",\"handling\"],\"ec\":[\"-no-tzdb-javadoc.jar\",\"-javadoc.jar\",\"-sources.jar\",\"-no-tzdb.jar\",\"-no-tzdb-sources.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"joda-time:joda-time:2.9.4\",\"g\":\"joda-time\",\"a\":\"joda-time\",\"v\":\"2.9.4\",\"p\":\"jar\",\"timestamp\":1464341135000,\"tags\":[\"replace\",\"time\",\"library\",\"date\",\"handling\"],\"ec\":[\"-no-tzdb.jar\",\"-sources.jar\",\"-javadoc.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"joda-time:joda-time:2.9.3\",\"g\":\"joda-time\",\"a\":\"joda-time\",\"v\":\"2.9.3\",\"p\":\"jar\",\"timestamp\":1459107331000,\"tags\":[\"replace\",\"time\",\"library\",\"date\",\"handling\"],\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\"-no-tzdb.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"joda-time:joda-time:2.9.2\",\"g\":\"joda-time\",\"a\":\"joda-time\",\"v\":\"2.9.2\",\"p\":\"jar\",\"timestamp\":1453988648000,\"tags\":[\"replace\",\"time\",\"library\",\"date\",\"handling\"],\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\"-no-tzdb.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"joda-time:joda-time:2.9.1\",\"g\":\"joda-time\",\"a\":\"joda-time\",\"v\":\"2.9.1\",\"p\":\"jar\",\"timestamp\":1447329806000,\"tags\":[\"replace\",\"time\",\"library\",\"date\",\"handling\"],\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\"-no-tzdb.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"joda-time:joda-time:2.9\",\"g\":\"joda-time\",\"a\":\"joda-time\",\"v\":\"2.9\",\"p\":\"jar\",\"timestamp\":1445680109000,\"tags\":[\"replace\",\"time\",\"library\",\"date\",\"handling\"],\"ec\":[\"-sources.jar\",\"-no-tzdb.jar\",\"-javadoc.jar\",\".jar\",\".pom\"]}]}}"
)
.networkData(
"http://search.maven.org/solrsearch/select?q=g:%22com.squareup.dagger%22+AND+a:%22dagger%22&core=gav&wt=json",
"" +
"{\"responseHeader\":" +
"{\"status\":0,\"QTime\":0,\"params\":" +
"{\"fl\":\"id,g,a,v,p,ec,timestamp,tags\",\"sort\":\"score desc,timestamp desc,g asc,a asc,v desc\",\"indent\":\"off\",\"q\":\"g:\\\"com.squareup.dagger\\\" AND a:\\\"dagger\\\"\",\"core\":\"gav\",\"wt\":\"json\",\"version\":\"2.2\"}}," +
"\"response\":" +
"{\"numFound\":9,\"start\":0,\"docs\":[" +
"{\"id\":\"com.squareup.dagger:dagger:1.2.5\",\"g\":\"com.squareup.dagger\",\"a\":\"dagger\",\"v\":\"1.2.5\",\"p\":\"jar\",\"timestamp\":1462852968000,\"tags\":[\"dependency\",\"android\",\"injector\",\"java\",\"fast\"],\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\"-tests.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"com.squareup.dagger:dagger:1.2.4\",\"g\":\"com.squareup.dagger\",\"a\":\"dagger\",\"v\":\"1.2.4\",\"p\":\"jar\",\"timestamp\":1462291775000,\"tags\":[\"dependency\",\"android\",\"injector\",\"java\",\"fast\"],\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\".jar\",\"-tests.jar\",\".pom\"]}," +
"{\"id\":\"com.squareup.dagger:dagger:1.2.3\",\"g\":\"com.squareup.dagger\",\"a\":\"dagger\",\"v\":\"1.2.3\",\"p\":\"jar\",\"timestamp\":1462238813000,\"tags\":[\"dependency\",\"android\",\"injector\",\"java\",\"fast\"],\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\".jar\",\"-tests.jar\",\".pom\"]}," +
"{\"id\":\"com.squareup.dagger:dagger:1.2.2\",\"g\":\"com.squareup.dagger\",\"a\":\"dagger\",\"v\":\"1.2.2\",\"p\":\"jar\",\"timestamp\":1405987370000,\"tags\":[\"dependency\",\"android\",\"injector\",\"java\",\"fast\"],\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\"-tests.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"com.squareup.dagger:dagger:1.2.1\",\"g\":\"com.squareup.dagger\",\"a\":\"dagger\",\"v\":\"1.2.1\",\"p\":\"jar\",\"timestamp\":1392614597000,\"tags\":[\"dependency\",\"android\",\"injector\",\"java\",\"fast\"],\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\"-tests.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"com.squareup.dagger:dagger:1.2.0\",\"g\":\"com.squareup.dagger\",\"a\":\"dagger\",\"v\":\"1.2.0\",\"p\":\"jar\",\"timestamp\":1386979272000,\"tags\":[\"dependency\",\"android\",\"injector\",\"java\",\"fast\"],\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\".jar\",\"-tests.jar\",\".pom\"]}," +
"{\"id\":\"com.squareup.dagger:dagger:1.1.0\",\"g\":\"com.squareup.dagger\",\"a\":\"dagger\",\"v\":\"1.1.0\",\"p\":\"jar\",\"timestamp\":1375745812000,\"tags\":[\"dependency\",\"android\",\"injector\",\"java\"],\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\".jar\",\"-tests.jar\",\".pom\"]}," +
"{\"id\":\"com.squareup.dagger:dagger:1.0.1\",\"g\":\"com.squareup.dagger\",\"a\":\"dagger\",\"v\":\"1.0.1\",\"p\":\"jar\",\"timestamp\":1370304793000,\"tags\":[\"dependency\",\"android\",\"injector\",\"java\"],\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\".jar\",\".pom\"]}," +
"{\"id\":\"com.squareup.dagger:dagger:1.0.0\",\"g\":\"com.squareup.dagger\",\"a\":\"dagger\",\"v\":\"1.0.0\",\"p\":\"jar\",\"timestamp\":1367941344000,\"tags\":[\"dependency\",\"android\",\"injector\",\"java\"],\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\".jar\",\".pom\"]}]}}"
).issues(REMOTE_VERSION).run().expect(expected)
}
fun testRemoteVersionsWithPreviews() {
// If the most recent version is a rc version, query for all versions
val expected = "" +
"build.gradle:9: Warning: A newer version of com.google.guava:guava than 11.0.2 is available: 23.6-android [NewerVersionAvailable]\n" +
" compile 'com.google.guava:guava:11.0.2'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:10: Warning: A newer version of com.google.guava:guava than 16.0-rc1 is available: 18.0-rc1 [NewerVersionAvailable]\n" +
" compile 'com.google.guava:guava:16.0-rc1'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 2 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 19\n" +
" buildToolsVersion \"19.0.0\"\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.google.guava:guava:11.0.2'\n" +
" compile 'com.google.guava:guava:16.0-rc1'\n" +
"}\n"
)
)
.issues(REMOTE_VERSION)
.networkData(
"http://search.maven.org/solrsearch/select?q=g:%22com.google.guava%22+AND+a:%22guava%22&core=gav&rows=1&wt=json",
"{\"responseHeader\":{\"status\":0,\"QTime\":0,\"params\":{\"fl\":\"id,g,a,v,p,ec,timestamp,tags\",\"sort\":\"score desc,timestamp desc,g asc,a asc,v desc\",\"indent\":\"off\",\"q\":\"g:\\\"com.google.guava\\\" AND a:\\\"guava\\\"\",\"core\":\"gav\",\"wt\":\"json\",\"rows\":\"1\",\"version\":\"2.2\"}},\"response\":{\"numFound\":38,\"start\":0,\"docs\":[{\"id\":\"com.google.guava:guava:18.0-rc1\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"18.0-rc1\",\"p\":\"bundle\",\"timestamp\":1407266204000,\"tags\":[\"spec\",\"libraries\",\"classes\",\"google\",\"code\",\"expanded\",\"much\",\"include\",\"annotation\",\"dependency\",\"that\",\"more\",\"utility\",\"guava\",\"javax\",\"only\",\"core\",\"suite\",\"collections\"],\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\".jar\",\"-site.jar\",\".pom\"]}]}}"
)
.networkData(
"http://search.maven.org/solrsearch/select?q=g:%22com.google.guava%22+AND+a:%22guava%22&core=gav&wt=json",
"{\"responseHeader\":{\"status\":0,\"QTime\":0,\"params\":{\"q\":\"g:\\\"com.google.guava\\\" AND a:\\\"guava\\\"\",\"core\":\"gav\",\"indent\":\"off\",\"fl\":\"id,g,a,v,p,ec,timestamp,tags\",\"sort\":\"score desc,timestamp desc,g asc,a asc,v desc\",\"wt\":\"json\",\"version\":\"2.2\"}},\"response\":{\"numFound\":68,\"start\":0,\"docs\":[{\"id\":\"com.google.guava:guava:23.6-jre\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"23.6-jre\",\"p\":\"bundle\",\"timestamp\":1513818220000,\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\".jar\",\".pom\"],\"tags\":[\"libraries\",\"classes\",\"google\",\"expanded\",\"much\",\"include\",\"that\",\"more\",\"utility\",\"guava\",\"core\",\"suite\",\"collections\"]},{\"id\":\"com.google.guava:guava:23.6-android\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"23.6-android\",\"p\":\"bundle\",\"timestamp\":1513817611000,\"ec\":[\"-javadoc.jar\",\"-sources.jar\",\".jar\",\".pom\"],\"tags\":[\"libraries\",\"classes\",\"google\",\"expanded\",\"much\",\"include\",\"that\",\"more\",\"utility\",\"guava\",\"core\",\"suite\",\"collections\"]},{\"id\":\"com.google.guava:guava:23.5-jre\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"23.5-jre\",\"p\":\"bundle\",\"timestamp\":1511382806000,\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\".jar\",\".pom\"],\"tags\":[\"libraries\",\"classes\",\"google\",\"expanded\",\"much\",\"include\",\"that\",\"more\",\"utility\",\"guava\",\"core\",\"suite\",\"collections\"]},{\"id\":\"com.google.guava:guava:23.5-android\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"23.5-android\",\"p\":\"bundle\",\"timestamp\":1511382148000,\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\".jar\",\".pom\"],\"tags\":[\"libraries\",\"classes\",\"google\",\"expanded\",\"much\",\"include\",\"that\",\"more\",\"utility\",\"guava\",\"core\",\"suite\",\"collections\"]},{\"id\":\"com.google.guava:guava:23.4-jre\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"23.4-jre\",\"p\":\"bundle\",\"timestamp\":1510248931000,\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\".jar\",\".pom\"],\"tags\":[\"libraries\",\"classes\",\"google\",\"expanded\",\"much\",\"include\",\"that\",\"more\",\"utility\",\"guava\",\"core\",\"suite\",\"collections\"]},{\"id\":\"com.google.guava:guava:23.4-android\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"23.4-android\",\"p\":\"bundle\",\"timestamp\":1510248248000,\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\".jar\",\".pom\"],\"tags\":[\"libraries\",\"classes\",\"google\",\"expanded\",\"much\",\"include\",\"that\",\"more\",\"utility\",\"guava\",\"core\",\"suite\",\"collections\"]},{\"id\":\"com.google.guava:guava:23.3-jre\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"23.3-jre\",\"p\":\"bundle\",\"timestamp\":1509048371000,\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\".jar\",\".pom\"],\"tags\":[\"libraries\",\"classes\",\"google\",\"expanded\",\"much\",\"include\",\"that\",\"more\",\"utility\",\"guava\",\"core\",\"suite\",\"collections\"]},{\"id\":\"com.google.guava:guava:23.3-android\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"23.3-android\",\"p\":\"bundle\",\"timestamp\":1509047759000,\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\".jar\",\".pom\"],\"tags\":[\"libraries\",\"classes\",\"google\",\"expanded\",\"much\",\"include\",\"that\",\"more\",\"utility\",\"guava\",\"core\",\"suite\",\"collections\"]},{\"id\":\"com.google.guava:guava:23.2-jre\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"23.2-jre\",\"p\":\"bundle\",\"timestamp\":1507762486000,\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\".jar\",\".pom\"],\"tags\":[\"libraries\",\"classes\",\"google\",\"expanded\",\"much\",\"include\",\"that\",\"more\",\"utility\",\"guava\",\"core\",\"suite\",\"collections\"]},{\"id\":\"com.google.guava:guava:23.2-android\",\"g\":\"com.google.guava\",\"a\":\"guava\",\"v\":\"23.2-android\",\"p\":\"bundle\",\"timestamp\":1507761822000,\"ec\":[\"-sources.jar\",\"-javadoc.jar\",\".jar\",\".pom\"],\"tags\":[\"libraries\",\"classes\",\"google\",\"expanded\",\"much\",\"include\",\"that\",\"more\",\"utility\",\"guava\",\"core\",\"suite\",\"collections\"]}]}}"
)
.run()
.expect(expected)
}
fun testPreviewVersions() {
val expected = "" +
"build.gradle:7: Error: You must use a newer version of the Android Gradle plugin. The minimum supported version is 1.0.0 and the recommended version is " +
GRADLE_PLUGIN_RECOMMENDED_VERSION +
" [GradlePluginVersion]\n" +
" classpath 'com.android.tools.build:gradle:1.0.0-rc8'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:8: Warning: A newer version of com.android.tools.build:gradle than 1.0.0 is available: " +
GRADLE_PLUGIN_RECOMMENDED_VERSION +
" [GradleDependency]\n" +
" classpath 'com.android.tools.build:gradle:1.0.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:9: Warning: A newer version of com.android.tools.build:gradle than 2.0.0-alpha4 is available: 3.5.0-alpha10 [GradleDependency]\n" +
" classpath 'com.android.tools.build:gradle:2.0.0-alpha4'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 2 warnings\n"
lint().files(
gradle(
"" +
"buildscript {\n" +
" repositories {\n" +
" google()\n" +
" jcenter()\n" +
" }\n" +
" dependencies {\n" +
" classpath 'com.android.tools.build:gradle:1.0.0-rc8'\n" +
" classpath 'com.android.tools.build:gradle:1.0.0'\n" +
" classpath 'com.android.tools.build:gradle:2.0.0-alpha4'\n" +
" }\n" +
"}\n" +
"\n" +
"allprojects {\n" +
" repositories {\n" +
" jcenter()\n" +
" }\n" +
"}\n"
)
).issues(DEPENDENCY, GRADLE_PLUGIN_COMPATIBILITY).run().expect(expected)
}
fun testPreviewVersionsNoGoogleMaven() {
// regression test for b/144442233: if we don't have google() in buildscript repositories,
// we probably shouldn't blindly update AGP version dependencies.
val expected = "" +
"build.gradle:6: Error: You must use a newer version of the Android Gradle plugin. The minimum supported version is 1.0.0 and the recommended version is " +
GRADLE_PLUGIN_RECOMMENDED_VERSION +
" [GradlePluginVersion]\n" +
" classpath 'com.android.tools.build:gradle:1.0.0-rc8'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"buildscript {\n" +
" repositories {\n" +
" jcenter()\n" +
" }\n" +
" dependencies {\n" +
" classpath 'com.android.tools.build:gradle:1.0.0-rc8'\n" +
" classpath 'com.android.tools.build:gradle:1.0.0'\n" +
" classpath 'com.android.tools.build:gradle:2.0.0-alpha4'\n" +
" }\n" +
"}\n" +
"\n" +
"allprojects {\n" +
" repositories {\n" +
" jcenter()\n" +
" }\n" +
"}\n"
)
).issues(DEPENDENCY, GRADLE_PLUGIN_COMPATIBILITY).run()
.expect(expected)
.expectFixDiffs("")
}
fun testDependenciesInVariables() {
val expected = "" +
"build.gradle:10: Warning: A newer version of com.google.android.gms:play-services-wearable than 5.0.77 is available: 6.1.71 [GradleDependency]\n" +
" compile \"com.google.android.gms:play-services-wearable:\${GPS_VERSION}\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings\n"
lint().files(
source(
"build.gradle",
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 21\n" +
"}\n" +
"\n" +
"final GPS_VERSION = '5.0.77'\n" +
"\n" +
"dependencies {\n" +
" compile \"com.google.android.gms:play-services-wearable:\${GPS_VERSION}\"\n" +
"}\n"
),
gradle(
"internal-only.gradle",
"" +
// Not part of the lint check; used only to provide a mock model to
// the infrastructure
"dependencies {\n" +
" compile 'com.google.android.gms:play-services-wearable:5.0.77'\n" +
"}"
)
).issues(DEPENDENCY).run().expect(expected)
}
fun testPlayServiceConsistency() {
val expected = "" +
"build.gradle:4: Error: All gms/firebase libraries must use the exact same version specification (mixing versions can lead to runtime crashes). Found versions 7.5.0, 7.3.0. Examples include com.google.android.gms:play-services-wearable:7.5.0 and com.google.android.gms:play-services-location:7.3.0 [GradleCompatible]\n" +
" compile 'com.google.android.gms:play-services-wearable:7.5.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'android'\n" +
"\n" +
"dependencies {\n" +
" compile 'com.google.android.gms:play-services-wearable:7.5.0'\n" +
" compile 'com.google.android.gms:play-services-location:7.3.0'\n" +
"}\n"
)
).issues(COMPATIBILITY).incremental().run().expect(expected)
}
fun testSupportLibraryConsistency() {
val expected = "" +
"build.gradle:4: Error: All com.android.support libraries must use the exact same version specification (mixing versions can lead to runtime crashes). Found versions 25.0-SNAPSHOT, 24.2, 24.1. Examples include com.android.support:preference-v7:25.0-SNAPSHOT and com.android.support:animated-vector-drawable:24.2 [GradleCompatible]\n" +
" compile \"com.android.support:appcompat-v7:24.2\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'android'\n" +
"dependencies {\n" +
" compile \"com.android.support:multidex:1.0.1\"\n" +
" compile \"com.android.support:appcompat-v7:24.2\"\n" +
" compile \"com.android.support:support-v13:24.1\"\n" +
" compile \"com.android.support:preference-v7:25.0-SNAPSHOT\"\n" +
" compile \"com.android.support:cardview-v7:24.2\"\n" +
" compile \"com.android.support:support-annotations:25.0.0\"\n" +
" compile \"com.android.support:renderscript:25.0.2\"\n" +
"}\n"
)
).issues(COMPATIBILITY).incremental().run().expect(expected)
}
fun testSupportLibraryConsistencyWithDataBinding() {
val expected = "" +
"build.gradle:3: Error: All com.android.support libraries must use the exact " +
"same version specification (mixing versions can lead to runtime crashes). " +
"Found versions 25.0.0, 21.0.3. Examples include " +
"com.android.support:recyclerview-v7:25.0.0 and " +
"com.android.support:support-v4:21.0.3. " +
"Note that this project is using data binding " +
"(com.android.databinding:library:1.3.1) which pulls in " +
"com.android.support:support-v4:21.0.3. " +
"You can try to work around this by adding an explicit dependency on" +
" com.android.support:support-v4:25.0.0 [GradleCompatible]\n" +
" compile \"com.android.support:recyclerview-v7:25.0.0\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().projects(
project(
gradle(
"" +
"apply plugin: 'android'\n" +
"dependencies {\n" +
" compile \"com.android.support:recyclerview-v7:25.0.0\"\n" +
" compile \"com.android.databinding:library:1.3.1\"\n" +
" compile \"com.android.databinding:baseLibrary:2.3.0-alpha2\"\n" +
"}\n"
)
)
.withDependencyGraph(
"" +
"+--- com.android.support:recyclerview-v7:25.0.0\n" +
"| +--- com.android.support:support-annotations:25.0.0\n" +
"| +--- com.android.support:support-compat:25.0.0\n" +
"| | \\--- com.android.support:support-annotations:25.0.0\n" +
"| \\--- com.android.support:support-core-ui:25.0.0\n" +
"| \\--- com.android.support:support-compat:25.0.0 (*)\n" +
"+--- com.android.databinding:library:1.3.1\n" +
"| +--- com.android.support:support-v4:21.0.3\n" +
"| | \\--- com.android.support:support-annotations:21.0.3 -> 25.0.0\n" +
"| \\--- com.android.databinding:baseLibrary:2.3.0-dev -> 2.3.0-alpha2\n" +
"+--- com.android.databinding:baseLibrary:2.3.0-alpha2\n" +
"\\--- com.android.databinding:adapters:1.3.1\n" +
" +--- com.android.databinding:library:1.3 -> 1.3.1 (*)\n" +
" \\--- com.android.databinding:baseLibrary:2.3.0-dev -> 2.3.0-alpha2"
)
).issues(COMPATIBILITY).incremental().run().expect(expected)
}
fun testWearableConsistency1() {
// Regression test 1 for b/29006320.
val expected = "" +
"build.gradle:4: Error: Project depends on com.google.android.support:wearable:2.0.0-alpha3, so it must also depend (as a provided dependency) on com.google.android.wearable:wearable:2.0.0-alpha3 [GradleCompatible]\n" +
" compile \"com.google.android.support:wearable:2.0.0-alpha3\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'android'\n" +
"\n" +
"dependencies {\n" +
" compile \"com.google.android.support:wearable:2.0.0-alpha3\"\n" +
"}\n"
)
).issues(COMPATIBILITY).incremental("build.gradle").run().expect(expected)
}
fun testWearableConsistency2() {
// Regression test 2 for b/29006320.
val expected = "" +
"build.gradle:4: Error: The wearable libraries for com.google.android.support and com.google.android.wearable must use exactly the same versions; found 2.0.0-alpha3 and 2.0.0-alpha4 [GradleCompatible]\n" +
" compile \"com.google.android.support:wearable:2.0.0-alpha3\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'android'\n" +
"\n" +
"dependencies {\n" +
" compile \"com.google.android.support:wearable:2.0.0-alpha3\"\n" +
" provided \"com.google.android.wearable:wearable:2.0.0-alpha4\"\n" +
"}\n"
)
).issues(COMPATIBILITY).incremental().run().expect(expected)
}
fun testWearableConsistency3() {
// Regression test 3 for b/29006320.
val expected = "" +
"build.gradle:4: Error: This dependency should be marked as compileOnly, not compile [GradleCompatible]\n" +
" compile \"com.google.android.support:wearable:2.0.0-alpha3\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'android'\n" +
"\n" +
"dependencies {\n" +
" compile \"com.google.android.support:wearable:2.0.0-alpha3\"\n" +
" compile \"com.google.android.wearable:wearable:2.0.0-alpha3\"\n" +
"}\n"
)
).issues(COMPATIBILITY).incremental().run().expect(expected)
}
fun testSupportLibraryConsistencyNonIncremental() {
val expected = "" +
"build.gradle:6: Error: All com.android.support libraries must use the exact same version specification (mixing versions can lead to runtime crashes). Found versions 25.0-SNAPSHOT, 24.2, 24.1. Examples include com.android.support:preference-v7:25.0-SNAPSHOT and com.android.support:animated-vector-drawable:24.2 [GradleCompatible]\n" +
" compile \"com.android.support:preference-v7:25.0-SNAPSHOT\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'android'\n" +
"\n" +
"dependencies {\n" +
" compile \"com.android.support:appcompat-v7:24.2\"\n" +
" compile \"com.android.support:support-v13:24.1\"\n" +
" compile \"com.android.support:preference-v7:25.0-SNAPSHOT\"\n" +
" compile \"com.android.support:cardview-v7:24.2\"\n" +
" compile \"com.android.support:multidex:1.0.1\"\n" +
" compile \"com.android.support:support-annotations:25.0.0\"\n" +
"}\n"
)
).issues(COMPATIBILITY).run().expect(expected)
}
fun testSupportLibraryNotFatal() {
// In fatal-only issue mode should not be reporting these
lint().files(
gradle(
"" +
"apply plugin: 'android'\n" +
"\n" +
"dependencies {\n" +
" compile \"com.android.support:appcompat-v7:24.2\"\n" +
" compile \"com.android.support:support-v13:24.1\"\n" +
" compile \"com.android.support:preference-v7:25.0-SNAPSHOT\"\n" +
" compile \"com.android.support:cardview-v7:24.2\"\n" +
" compile \"com.android.support:multidex:1.0.1\"\n" +
" compile \"com.android.support:support-annotations:25.0.0\"\n" +
"}\n"
)
).issues(COMPATIBILITY).vital(true).run().expectClean()
}
fun testPlayServiceConsistencyNonIncremental() {
val expected = "" +
"build.gradle:4: Error: All gms/firebase libraries must use the exact same version specification (mixing versions can lead to runtime crashes). Found versions 7.5.0, 7.3.0. Examples include com.google.android.gms:play-services-wearable:7.5.0 and com.google.android.gms:play-services-location:7.3.0 [GradleCompatible]\n" +
" compile 'com.google.android.gms:play-services-wearable:7.5.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
" build.gradle:5: <No location-specific message\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'android'\n" +
"\n" +
"dependencies {\n" +
" compile 'com.google.android.gms:play-services-wearable:7.5.0'\n" +
" compile 'com.google.android.gms:play-services-location:7.3.0'\n" +
"}\n"
)
).issues(COMPATIBILITY).run().expect(expected)
}
fun testPlayServiceInconsistentVersionsVersion14() {
lint().files(
gradle(
"" +
"apply plugin: 'android'\n" +
"\n" +
"dependencies {\n" +
" compile 'com.google.android.gms:play-services-wearable:14.0.0'\n" +
" compile 'com.google.android.gms:play-services-location:15.0.1'\n" +
" compile 'com.google.android.gms:play-services-foo-bar:0.0.1'\n" +
"}\n"
)
).issues(COMPATIBILITY).run().expectClean()
}
fun testWrongQuotes() {
val expected = "" +
"build.gradle:5: Error: It looks like you are trying to substitute a version variable, but using single quotes ('). For Groovy string interpolation you must use double quotes (\"). [NotInterpolated]\n" +
" compile 'com.android.support:design:\${supportLibVersion}'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"ext {\n" +
" supportLibVersion = \"23.1.1\"\n" +
"}\n" +
"dependencies {\n" +
" compile 'com.android.support:design:\${supportLibVersion}'\n" +
" compile \"com.android.support:appcompat-v7:\${supportLibVersion}\"\n" +
"}\n"
)
)
.issues(NOT_INTERPOLATED)
.ignoreUnknownGradleConstructs()
.run()
.expect(expected)
.expectFixDiffs(
"" +
"Fix for build.gradle line 4: Replace single quotes with double quotes:\n" +
"@@ -5 +5\n" +
"- compile 'com.android.support:design:\${supportLibVersion}'\n" +
"+ compile \"com.android.support:design:\${supportLibVersion}\"\n"
)
}
fun testOldFabric() {
// This version of Fabric created a unique string for every build which results in
// Hotswaps getting disabled due to resource changes
val expected = "" +
"build.gradle:3: Warning: Use Fabric Gradle plugin version 1.21.6 or later to improve Instant Run performance (was 1.21.2) [GradleDependency]\n" +
" classpath 'io.fabric.tools:gradle:1.21.2'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:4: Warning: Use Fabric Gradle plugin version 1.21.6 or later to improve Instant Run performance (was 1.20.0) [GradleDependency]\n" +
" classpath 'io.fabric.tools:gradle:1.20.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:5: Warning: A newer version of io.fabric.tools:gradle than 1.22.0 is available: 1.25.1 [GradleDependency]\n" +
" classpath 'io.fabric.tools:gradle:1.22.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 3 warnings\n"
lint().files(
gradle(
"" +
"buildscript {\n" +
" dependencies {\n" +
" classpath 'io.fabric.tools:gradle:1.21.2'\n" + // Not OK
" classpath 'io.fabric.tools:gradle:1.20.0'\n" + // Not OK
" classpath 'io.fabric.tools:gradle:1.22.0'\n" + // Old
" classpath 'io.fabric.tools:gradle:1.+'\n" + // OK
" }\n" +
"}\n"
)
)
.issues(DEPENDENCY)
.run()
.expect(expected)
.expectFixDiffs(
"" +
"Fix for build.gradle line 2: Change to 1.22.1:\n" +
"@@ -3 +3\n" +
"- classpath 'io.fabric.tools:gradle:1.21.2'\n" +
"+ classpath 'io.fabric.tools:gradle:1.22.1'\n" +
"Fix for build.gradle line 3: Change to 1.22.1:\n" +
"@@ -4 +4\n" +
"- classpath 'io.fabric.tools:gradle:1.20.0'\n" +
"+ classpath 'io.fabric.tools:gradle:1.22.1'\n" +
"Fix for build.gradle line 4: Change to 1.25.1:\n" +
"@@ -5 +5\n" +
"- classpath 'io.fabric.tools:gradle:1.22.0'\n" +
"+ classpath 'io.fabric.tools:gradle:1.25.1'"
)
}
private fun isWindows(): Boolean {
return System.getProperty("os.name").toLowerCase(Locale.US).contains("windows")
}
fun testOldRobolectric() {
// Old robolectric warning is shown only for windows users
val expected =
if (isWindows())
"""
build.gradle:2: Warning: Use robolectric version 4.2.1 or later to fix issues with parsing of Windows paths [GradleDependency]
testImplementation 'org.robolectric:robolectric:4.1'
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:3: Warning: Use robolectric version 4.2.1 or later to fix issues with parsing of Windows paths [GradleDependency]
testImplementation 'org.robolectric:robolectric:3.8'
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:4: Warning: Use robolectric version 4.2.1 or later to fix issues with parsing of Windows paths [GradleDependency]
testImplementation 'org.robolectric:robolectric:3.6'
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:5: Warning: Use robolectric version 4.2.1 or later to fix issues with parsing of Windows paths [GradleDependency]
testImplementation 'org.robolectric:robolectric:2.0'
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
0 errors, 4 warnings
""".trimIndent()
else
"No warnings."
lint().files(
gradle(
"""
dependencies {
testImplementation 'org.robolectric:robolectric:4.1'
testImplementation 'org.robolectric:robolectric:3.8'
testImplementation 'org.robolectric:robolectric:3.6'
testImplementation 'org.robolectric:robolectric:2.0'
testImplementation 'org.robolectric:robolectric:4.2.1'
}
""".trimIndent()
)
)
.issues(DEPENDENCY)
.run()
.expect(expected)
.expectFixDiffs(
if (isWindows())
"""
Fix for build.gradle line 2: Change to 4.2.1:
@@ -2 +2
- testImplementation 'org.robolectric:robolectric:4.1'
+ testImplementation 'org.robolectric:robolectric:4.2.1'
Fix for build.gradle line 3: Change to 4.2.1:
@@ -3 +3
- testImplementation 'org.robolectric:robolectric:3.8'
+ testImplementation 'org.robolectric:robolectric:4.2.1'
Fix for build.gradle line 4: Change to 4.2.1:
@@ -4 +4
- testImplementation 'org.robolectric:robolectric:3.6'
+ testImplementation 'org.robolectric:robolectric:4.2.1'
Fix for build.gradle line 5: Change to 4.2.1:
@@ -5 +5
- testImplementation 'org.robolectric:robolectric:2.0'
@@ -7 +6
+ testImplementation 'org.robolectric:robolectric:4.2.1'
""".trimIndent()
else ""
)
}
fun testOldBugSnag() {
// This version of BugSnag triggered instant run full rebuilds
val expected = "" +
"build.gradle:3: Warning: Use BugSnag Gradle plugin version 2.1.2 or later to improve Instant Run performance (was 2.1.0) [GradleDependency]\n" +
" classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.1.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:4: Warning: Use BugSnag Gradle plugin version 2.1.2 or later to improve Instant Run performance (was 2.1.1) [GradleDependency]\n" +
" classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.1.1'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:5: Warning: A newer version of com.bugsnag:bugsnag-android-gradle-plugin than 2.1.2 is available: 3.2.5 [GradleDependency]\n" +
" classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.1.2'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:6: Warning: A newer version of com.bugsnag:bugsnag-android-gradle-plugin than 2.2 is available: 3.2.5 [GradleDependency]\n" +
" classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.2'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:7: Warning: A newer version of com.bugsnag:bugsnag-android-gradle-plugin than 2.5 is available: 3.2.5 [GradleDependency]\n" +
" classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.5'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 5 warnings"
lint().files(
gradle(
"" +
"buildscript {\n" +
" dependencies {\n" +
" classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.1.0'\n" + // Bad
" classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.1.1'\n" + // Bad
" classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.1.2'\n" + // Old
" classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.2'\n" + // Old
" classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.5'\n" + // OK
" }\n" +
"}\n"
)
)
.issues(DEPENDENCY)
.run()
.expect(expected)
.expectFixDiffs(
"" +
"Fix for build.gradle line 2: Change to 2.4.1:\n" +
"@@ -3 +3\n" +
"- classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.1.0'\n" +
"+ classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.4.1'\n" +
"Fix for build.gradle line 3: Change to 2.4.1:\n" +
"@@ -4 +4\n" +
"- classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.1.1'\n" +
"+ classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.4.1'\n" +
"Fix for build.gradle line 4: Change to 3.2.5:\n" +
"@@ -5 +5\n" +
"- classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.1.2'\n" +
"+ classpath 'com.bugsnag:bugsnag-android-gradle-plugin:3.2.5'\n" +
"Fix for build.gradle line 5: Change to 3.2.5:\n" +
"@@ -6 +6\n" +
"- classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.2'\n" +
"+ classpath 'com.bugsnag:bugsnag-android-gradle-plugin:3.2.5'\n" +
"Fix for build.gradle line 6: Change to 3.2.5:\n" +
"@@ -7 +7\n" +
"- classpath 'com.bugsnag:bugsnag-android-gradle-plugin:2.5'\n" +
"+ classpath 'com.bugsnag:bugsnag-android-gradle-plugin:3.2.5'"
)
}
fun testDeprecatedAppIndexingDependency() {
val expected = "" +
"build.gradle:9: Warning: Deprecated: Replace 'com.google.android.gms:play-services-appindexing:9.8.0' with 'com.google.firebase:firebase-appindexing:10.0.0' or above. More info: http://firebase.google.com/docs/app-indexing/android/migrate [GradleDeprecated]\n" +
"compile 'com.google.android.gms:play-services-appindexing:9.8.0'\n" +
"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 25\n" +
" buildToolsVersion \"25.0.2\"\n" +
"}\n" +
"\n" +
"dependencies {\n" +
"compile 'com.google.android.gms:play-services-appindexing:9.8.0'\n" +
"}\n"
)
)
.issues(DEPRECATED)
.run()
.expect(expected)
.expectFixDiffs(
"" +
"Fix for build.gradle line 8: Replace with Firebase:\n" +
"@@ -9 +9\n" +
"- compile 'com.google.android.gms:play-services-appindexing:9.8.0'\n" +
"+ compile 'com.google.firebase:firebase-appindexing:10.2.1'\n"
)
}
fun testBadBuildTools() {
// Warn about build tools 23.0.0 which is known to be a bad version
val expected = "" +
"build.gradle:7: Error: Build Tools 23.0.0 should not be used; it has some known serious bugs. Use version 23.0.3 instead. [GradleCompatible]\n" +
" buildToolsVersion \"23.0.0\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 18\n" +
" buildToolsVersion \"19.0.0\"\n" + // OK
" buildToolsVersion \"22.1.0\"\n" + // OK
" buildToolsVersion \"23.0.0\"\n" + // ERROR
" buildToolsVersion \"23.0.1\"\n" + // OK
" buildToolsVersion \"23.1.0\"\n" + // OK
" buildToolsVersion \"24.0.0\"\n" + // OK
" buildToolsVersion \"23.0.+\"\n" + // OK
"}"
)
).issues(COMPATIBILITY).run().expect(expected)
}
fun testGetNamedDependency() {
TestCase.assertEquals(
"com.android.support:support-v4:21.0.+",
getNamedDependency(
"group: 'com.android.support', name: 'support-v4', version: '21.0.+'"
)
)
TestCase.assertEquals(
"com.android.support:support-v4:21.0.+",
getNamedDependency(
"name:'support-v4', group: \"com.android.support\", version: '21.0.+'"
)
)
TestCase.assertEquals(
"junit:junit:4.+",
getNamedDependency("group: 'junit', name: 'junit', version: '4.+'")
)
TestCase.assertEquals(
"com.android.support:support-v4:19.0.+",
getNamedDependency(
"group: 'com.android.support', name: 'support-v4', version: '19.0.+'"
)
)
TestCase.assertEquals(
"com.google.guava:guava:11.0.1",
getNamedDependency(
"group: 'com.google.guava', name: 'guava', version: '11.0.1', transitive: false"
)
)
TestCase.assertEquals(
"com.google.api-client:google-api-client:1.6.0-beta",
getNamedDependency(
"group: 'com.google.api-client', name: 'google-api-client', version: '1.6.0-beta', transitive: false"
)
)
TestCase.assertEquals(
"org.robolectric:robolectric:2.3-SNAPSHOT",
getNamedDependency(
"group: 'org.robolectric', name: 'robolectric', version: '2.3-SNAPSHOT'"
)
)
}
fun testSupportAnnotations() {
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 19\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" testCompile 'com.android.support:support-annotations:24.0.0'\n" +
" compile 'com.android.support:appcompat-v7:+'\n" +
"}\n"
)
).issues(COMPATIBILITY).run().expectClean()
}
fun testBundledGmsDependency() {
lint().files(
gradle(
"" +
"dependencies {\n" +
" compile 'com.google.android.gms:play-services:8.5.6'\n" +
"}\n"
)
).issues(BUNDLED_GMS).run().expect(
"" +
"build.gradle:2: Warning: Avoid using bundled version of Google Play services SDK. [UseOfBundledGooglePlayServices]\n" +
" compile 'com.google.android.gms:play-services:8.5.6'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings\n"
)
}
fun testUnbundledGmsDependency() {
lint().files(
gradle(
"" +
"dependencies {\n" +
" compile 'com.google.android.gms:play-services-auth:9.2.1'\n" +
"}\n"
)
).issues(BUNDLED_GMS).run().expectClean()
}
fun testHighAppVersionCode() {
val expected = "" +
"build.gradle:5: Error: The 'versionCode' is very high and close to the max allowed value [HighAppVersionCode]\n" +
" versionCode 2146435071\n" +
" ~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" defaultConfig {\n" +
" versionCode 2146435071\n" +
" }\n" +
"}"
)
).issues(HIGH_APP_VERSION_CODE).run().expect(expected)
}
fun testORequirements() {
val expected = "" +
"build.gradle:14: Error: Version must be at least 10.2.1 when targeting O [GradleCompatible]\n" +
" compile 'com.google.android.gms:play-services-gcm:10.2.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:15: Error: Version must be at least 10.2.1 when targeting O [GradleCompatible]\n" +
" compile 'com.google.firebase:firebase-messaging:10.2.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:16: Error: Version must be at least 0.6.0 when targeting O [GradleCompatible]\n" +
" compile 'com.google.firebase:firebase-jobdispatcher:0.5.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:17: Error: Version must be at least 0.6.0 when targeting O [GradleCompatible]\n" +
" compile 'com.google.firebase:firebase-jobdispatcher-with-gcm-dep:0.5.0'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"4 errors, 0 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion \"android-O\"\n" +
" buildToolsVersion \"26.0.0 rc1\"\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" targetSdkVersion \"O\"\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.google.android.gms:play-services-gcm:10.2.0'\n" +
" compile 'com.google.firebase:firebase-messaging:10.2.0'\n" +
" compile 'com.google.firebase:firebase-jobdispatcher:0.5.0'\n" +
" compile 'com.google.firebase:firebase-jobdispatcher-with-gcm-dep:0.5.0'\n" +
"}\n"
)
).issues(COMPATIBILITY).incremental().run().expect(expected)
}
fun testORequirementsNotApplicable() {
// targetSdkVersion < O: No check
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion \"android-O\"\n" +
" buildToolsVersion \"26.0.0 rc1\"\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" targetSdkVersion 25\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.google.android.gms:play-services-gcm:10.2.0'\n" +
" compile 'com.google.firebase:firebase-messaging:10.2.0'\n" +
" compile 'com.google.firebase:firebase-jobdispatcher:0.5.0'\n" +
" compile 'com.google.firebase:firebase-jobdispatcher-with-gcm-dep:0.5.0'\n" +
"}\n"
)
)
.issues(COMPATIBILITY)
.incremental()
.run()
.expectClean()
}
fun testORequirementsSatisfied() {
// Versions > threshold: No problem
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion \"android-O\"\n" +
" buildToolsVersion \"26.0.0 rc1\"\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" targetSdkVersion \"O\"\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.google.android.gms:play-services-gcm:10.2.1'\n" +
" compile 'com.google.firebase:firebase-messaging:10.2.1'\n" +
" compile 'com.google.firebase:firebase-jobdispatcher:0.6.0'\n" +
" compile 'com.google.firebase:firebase-jobdispatcher-with-gcm-dep:0.6.0'\n" +
"}\n"
)
)
.issues(COMPATIBILITY)
.incremental()
.run()
.expectClean()
}
fun testOR2RequiresAppCompat26Beta1() {
// Both versions older than 26 beta: No problem
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 25\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" targetSdkVersion 25\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.android.support:appcompat-v7:25.0.0-rc1'\n" +
"}\n"
)
)
.issues(COMPATIBILITY)
.client(getClientWithMockPlatformTarget(AndroidVersion("25"), 1))
.run()
.expectClean()
// Both versions newer than 26 beta: No problem
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion \"android-O\"\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" targetSdkVersion \"O\"\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.android.support:appcompat-v7:26.0.0-beta1'\n" +
"}\n"
)
)
.issues(COMPATIBILITY)
.client(getClientWithMockPlatformTarget(AndroidVersion("26"), 2))
.run()
.expectClean()
// SDK >= O, support library < 26 beta: problem
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion \"android-O\"\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" targetSdkVersion \"O\"\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.android.support:appcompat-v7:26.0.0-alpha1'\n" +
"}\n"
)
)
.issues(COMPATIBILITY)
.client(getClientWithMockPlatformTarget(AndroidVersion("O"), 2))
.run()
.expect(
"" +
"build.gradle:13: Error: When using a compileSdkVersion android-O revision 2 or higher, the support library version should be 26.0.0-beta1 or higher (was 26.0.0-alpha1) [GradleCompatible]\n" +
" compile 'com.android.support:appcompat-v7:26.0.0-alpha1'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
)
// SDK < O, support library >= 26 beta: problem
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 'android-O'\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.android.support:appcompat-v7:26.0.0-beta1'\n" +
"}\n"
)
)
.issues(COMPATIBILITY)
.client(getClientWithMockPlatformTarget(AndroidVersion("O"), 1))
.run()
.expect(
"" +
"build.gradle:12: Error: When using a compileSdkVersion older than android-O revision 2, the support library version must be 26.0.0-alpha1 or lower (was 26.0.0-beta1) [GradleCompatible]\n" +
" compile 'com.android.support:appcompat-v7:26.0.0-beta1'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"1 errors, 0 warnings\n"
)
// Using SDK 26 final with 26.0.0-beta2 // ok
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" compileSdkVersion 'android-O'\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion 15\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile 'com.android.support:appcompat-v7:26.0.0-beta2'\n" +
"}\n"
)
)
.issues(COMPATIBILITY)
.client(
getClientWithMockPlatformTarget(
// Using apiLevel implies version.isPreview is false
AndroidVersion("26"), 1
)
)
.run()
.expectClean()
}
fun testDevVariantNotNeeded() {
val expected = "" +
"build.gradle:9: Warning: You no longer need a dev mode to enable multi-dexing during development, and this can break API version checks [DevModeObsolete]\n" +
" minSdkVersion 21\n" +
" ~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings\n"
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" productFlavors {\n" +
" // When building a variant that uses this flavor, the following configurations\n" +
" // override those in the defaultConfig block.\n" +
" dev {\n" +
" // To avoid using legacy multidex, set minSdkVersion to 21 or higher.\n" +
" minSdkVersion 21\n" +
" versionNameSuffix \"-dev\"\n" +
" applicationIdSuffix '.dev'\n" +
" }\n" +
" }\n" +
"}\n"
)
)
.issues(DEV_MODE_OBSOLETE)
.incremental()
.run()
.expect(expected)
}
fun testDuplicateWarnings() {
lint().projects(
project(
gradle(
"dependencies {\n" +
" implementation 'my.indirect.dependency:myname:1.2.3'\n" +
" implementation 'xpp3:xpp3:1.1.4c'\n" +
" implementation 'commons-logging:commons-logging:1.2'\n" +
" implementation 'xerces:xmlParserAPIs:2.6.2'\n" +
" implementation 'org.json:json:20170516'\n" +
" implementation 'org.khronos:opengl-api:gl1.1-android-2.1_r1'\n" +
" implementation 'com.google.android:android:4.1.1.4'\n" +
// Multi-line scenario:
" compile group: 'org.apache.httpcomponents',\n" +
" name: 'httpclient',\n" +
" version: '4.5.3'\n" +
"}\n"
)
)
.withDependencyGraph(
"" +
"+--- my.indirect.dependency:myname:1.2.3\n" +
"| \\--- org.json:json:20170516\n" +
"+--- commons-logging:commons-logging:1.2\n" +
"+--- org.apache.httpcomponents:httpclient:4.5.3\n" +
"| +--- org.apache.httpcomponents:httpcore:4.4.6\n" +
"| +--- commons-logging:commons-logging:1.2\n" +
"| \\--- commons-codec:commons-codec:1.9\n" +
"+--- xpp3:xpp3:1.1.4c\n" +
"+--- xerces:xmlParserAPIs:2.6.2\n" +
"+--- org.json:json:20170516\n" +
"+--- org.khronos:opengl-api:gl1.1-android-2.1_r1\n" +
"\\--- com.google.android:android:4.1.1.4\n" +
" +--- commons-logging:commons-logging:1.1.1 -> 1.2\n" +
" +--- org.apache.httpcomponents:httpclient:4.0.1 -> 4.5.3 (*)\n" +
" +--- org.khronos:opengl-api:gl1.1-android-2.1_r1\n" +
" +--- xerces:xmlParserAPIs:2.6.2\n" +
" +--- xpp3:xpp3:1.1.4c\n" +
" \\--- org.json:json:20080701 -> 20170516"
)
)
.issues(DUPLICATE_CLASSES)
.run()
.expect(
"build.gradle:2: Error: myname depends on a library (org.json:json) which defines classes that conflict with classes now provided by Android. Solutions include finding newer versions or alternative libraries that don't have the same problem (for example, for httpclient use HttpUrlConnection or okhttp instead), or repackaging the library using something like jarjar. Dependency chain: my.indirect.dependency:myname → org.json:json) [DuplicatePlatformClasses]\n" +
" implementation 'my.indirect.dependency:myname:1.2.3'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:3: Error: xpp3 defines classes that conflict with classes now provided by Android. Solutions include finding newer versions or alternative libraries that don't have the same problem (for example, for httpclient use HttpUrlConnection or okhttp instead), or repackaging the library using something like jarjar. [DuplicatePlatformClasses]\n" +
" implementation 'xpp3:xpp3:1.1.4c'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:4: Error: commons-logging defines classes that conflict with classes now provided by Android. Solutions include finding newer versions or alternative libraries that don't have the same problem (for example, for httpclient use HttpUrlConnection or okhttp instead), or repackaging the library using something like jarjar. [DuplicatePlatformClasses]\n" +
" implementation 'commons-logging:commons-logging:1.2'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:5: Error: xmlParserAPIs defines classes that conflict with classes now provided by Android. Solutions include finding newer versions or alternative libraries that don't have the same problem (for example, for httpclient use HttpUrlConnection or okhttp instead), or repackaging the library using something like jarjar. [DuplicatePlatformClasses]\n" +
" implementation 'xerces:xmlParserAPIs:2.6.2'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:6: Error: json defines classes that conflict with classes now provided by Android. Solutions include finding newer versions or alternative libraries that don't have the same problem (for example, for httpclient use HttpUrlConnection or okhttp instead), or repackaging the library using something like jarjar. [DuplicatePlatformClasses]\n" +
" implementation 'org.json:json:20170516'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:7: Error: opengl-api defines classes that conflict with classes now provided by Android. Solutions include finding newer versions or alternative libraries that don't have the same problem (for example, for httpclient use HttpUrlConnection or okhttp instead), or repackaging the library using something like jarjar. [DuplicatePlatformClasses]\n" +
" implementation 'org.khronos:opengl-api:gl1.1-android-2.1_r1'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:8: Error: android depends on a library (org.json:json) which defines classes that conflict with classes now provided by Android. Solutions include finding newer versions or alternative libraries that don't have the same problem (for example, for httpclient use HttpUrlConnection or okhttp instead), or repackaging the library using something like jarjar. Dependency chain: com.google.android:android → org.json:json) [DuplicatePlatformClasses]\n" +
" implementation 'com.google.android:android:4.1.1.4'\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"build.gradle:9: Error: httpclient depends on a library (commons-logging:commons-logging) which defines classes that conflict with classes now provided by Android. Solutions include finding newer versions or alternative libraries that don't have the same problem (for example, for httpclient use HttpUrlConnection or okhttp instead), or repackaging the library using something like jarjar. Dependency chain: org.apache.httpcomponents:httpclient → commons-logging:commons-logging) [DuplicatePlatformClasses]\n" +
" compile group: 'org.apache.httpcomponents',\n" +
" ^\n" +
"8 errors, 0 warnings"
)
.expectFixDiffs(
"" +
"Fix for build.gradle line 1: Delete dependency:\n" +
"@@ -2 +2\n" +
"- implementation 'my.indirect.dependency:myname:1.2.3'\n" +
"Fix for build.gradle line 2: Delete dependency:\n" +
"@@ -3 +3\n" +
"- implementation 'xpp3:xpp3:1.1.4c'\n" +
"Fix for build.gradle line 3: Delete dependency:\n" +
"@@ -4 +4\n" +
"- implementation 'commons-logging:commons-logging:1.2'\n" +
"Fix for build.gradle line 4: Delete dependency:\n" +
"@@ -5 +5\n" +
"- implementation 'xerces:xmlParserAPIs:2.6.2'\n" +
"Fix for build.gradle line 5: Delete dependency:\n" +
"@@ -6 +6\n" +
"- implementation 'org.json:json:20170516'\n" +
"Fix for build.gradle line 6: Delete dependency:\n" +
"@@ -7 +7\n" +
"- implementation 'org.khronos:opengl-api:gl1.1-android-2.1_r1'\n" +
"Fix for build.gradle line 7: Delete dependency:\n" +
"@@ -8 +8\n" +
"- implementation 'com.google.android:android:4.1.1.4'\n" +
"Fix for build.gradle line 8: Delete dependency:\n" +
"@@ -9 +9\n" +
"- compile group: 'org.apache.httpcomponents',\n" +
"- name: 'httpclient',\n" +
"- version: '4.5.3'\n"
)
}
fun testKtsSupport() {
lint().files(
// https://github.com/gradle/kotlin-dsl/blob/master/samples/hello-android/build.gradle.kts
kts(
"" +
"plugins {\n" +
" id(\"com.android.application\") version \"2.3.3\"\n" +
// Deprecated version of the above (shouldn't be used in real KTS file,
// but here to check that visitors also touch method calls
" id(\"android\") version \"2.3.3\"\n" +
" kotlin(\"android\") version \"1.1.51\"\n" +
"}\n" +
"\n" +
"android {\n" +
" buildToolsVersion(\"25.0.0\")\n" +
" compileSdkVersion(23)\n" +
"\n" +
" defaultConfig {\n" +
" minSdkVersion(7)\n" +
" targetSdkVersion(23)\n" +
"\n" +
" applicationId = \"com.example.kotlingradle\"\n" +
" versionCode = 1\n" +
" versionName = \"1.0\"\n" +
" }\n" +
"\n" +
" buildTypes {\n" +
" getByName(\"release\") {\n" +
" isMinifyEnabled = false\n" +
" proguardFiles(\"proguard-rules.pro\")\n" +
" }\n" +
" }\n" +
"}\n" +
"\n" +
"dependencies {\n" +
" compile(\"com.android.support:appcompat-v7:23.4.0\")\n" +
" compile(\"com.android.support.constraint:constraint-layout:1.0.0-alpha8\")\n" +
" compile(kotlin(\"stdlib\", \"1.1.51\"))\n" +
"}\n" +
"\n" +
"repositories {\n" +
" jcenter()\n" +
"}"
)
)
.issues(DEPENDENCY, MIN_SDK_TOO_LOW, DEPRECATED)
.run()
.expect(
"""
build.gradle.kts:3: Warning: 'android' is deprecated; use 'com.android.application' instead [GradleDeprecated]
id("android") version "2.3.3"
~~~~~~~
build.gradle.kts:8: Warning: Old buildToolsVersion 25.0.0; recommended version is 25.0.3 or later [GradleDependency]
buildToolsVersion("25.0.0")
~~~~~~
build.gradle.kts:30: Warning: A newer version of com.android.support.constraint:constraint-layout than 1.0.0-alpha8 is available: 1.0.3-alpha8 [GradleDependency]
compile("com.android.support.constraint:constraint-layout:1.0.0-alpha8")
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle.kts:12: Warning: The value of minSdkVersion is too low. It can be incremented without noticeably reducing the number of supported devices. [MinSdkTooLow]
minSdkVersion(7)
~
0 errors, 4 warnings
"""
)
.expectFixDiffs(
"""
Fix for build.gradle.kts line 3: Replace with com.android.application:
@@ -3 +3
- id("android") version "2.3.3"
+ id("com.android.application") version "2.3.3"
Fix for build.gradle.kts line 8: Change to 25.0.3:
@@ -8 +8
- buildToolsVersion("25.0.0")
+ buildToolsVersion("25.0.3")
Fix for build.gradle.kts line 30: Change to 1.0.3-alpha8:
@@ -30 +30
- compile("com.android.support.constraint:constraint-layout:1.0.0-alpha8")
+ compile("com.android.support.constraint:constraint-layout:1.0.3-alpha8")
Fix for build.gradle.kts line 12: Update minSdkVersion to 16:
@@ -12 +12
- minSdkVersion(7)
+ minSdkVersion(16)
"""
)
}
fun testExpiring() {
try {
val calendar = Calendar.getInstance()
GradleDetector.calendar = calendar
calendar.set(Calendar.YEAR, 2018)
calendar.set(Calendar.MONTH, 6)
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" defaultConfig {\n" +
" targetSdkVersion 17\n" +
" }\n" +
"}\n"
)
)
.issues(EXPIRED_TARGET_SDK_VERSION, EXPIRING_TARGET_SDK_VERSION)
.sdkHome(mockSupportLibraryInstallation)
.run()
.expect(
"""
build.gradle:5: Error: Google Play will soon require that apps target API level 26 or higher. This will be required for new apps in August 2018, and for updates to existing apps in November 2018. [ExpiringTargetSdkVersion]
targetSdkVersion 17
~~~~~~~~~~~~~~~~~~~
1 errors, 0 warnings
"""
)
} finally {
GradleDetector.calendar = null
}
}
fun testExpired() {
try {
val calendar = Calendar.getInstance()
GradleDetector.calendar = calendar
calendar.set(Calendar.YEAR, 2018)
calendar.set(Calendar.MONTH, 10)
lint().files(
gradle(
"" +
"apply plugin: 'com.android.application'\n" +
"\n" +
"android {\n" +
" defaultConfig {\n" +
" targetSdkVersion 17\n" +
" }\n" +
"}\n"
)
)
.issues(EXPIRED_TARGET_SDK_VERSION, EXPIRING_TARGET_SDK_VERSION)
.sdkHome(mockSupportLibraryInstallation)
.run()
.expect(
"""
build.gradle:5: Error: Google Play requires that apps target API level 26 or higher.
[ExpiredTargetSdkVersion]
targetSdkVersion 17
~~~~~~~~~~~~~~~~~~~
1 errors, 0 warnings
"""
)
} finally {
GradleDetector.calendar = null
}
}
fun testDeprecatedLibrary() {
lint().files(
gradle(
"""
dependencies {
compile 'log4j:log4j:1.2.18' // OK
compile 'log4j:log4j:1.2.17' // OK
compile 'log4j:log4j:1.2.16' // ERROR
compile 'log4j:log4j:1.2.15' // ERROR
compile 'log4j:log4j:1.2.14' // ERROR
compile 'log4j:log4j:1.2.13' // ERROR
compile 'log4j:log4j:1.2.12' // ERROR
compile 'log4j:log4j:1.2.4' // ERROR
compile 'log4j:log4j:1.2.3' // OK (not included in range)
compile 'log4j:log4j:0.5' // ERROR
compile 'com.example.ads.thirdparty:example:7.3.1' // OK
compile 'com.example.ads.thirdparty:example:8.0.0' // OK
compile 'com.example.ads.thirdparty:example:7.2.2' // OK
compile 'com.example.ads.thirdparty:example:7.2.1' // ERROR
compile 'com.example.ads.thirdparty:example:7.2.0' // ERROR
compile 'com.example.ads.thirdparty:example:7.1.1' // ERROR
compile 'com.example.ads.thirdparty:example:7.1.0' // ERROR
compile 'com.example.ads.thirdparty:example:7.0.5' // OK
compile 'com.example.ads.thirdparty:example:7.0.0' // ERROR
compile 'com.example.ads.thirdparty:example:6.8.5' // ERROR
compile 'com.android.volley:volley:1.1.0' // OK
}
"""
).indented()
).issues(RISKY_LIBRARY, DEPRECATED_LIBRARY, DEPENDENCY)
.sdkHome(mockSupportLibraryInstallation)
.run().expect(
"""
build.gradle:10: Warning: A newer version of log4j:log4j than 1.2.3 is available: 1.2.17 [GradleDependency]
compile 'log4j:log4j:1.2.3' // OK (not included in range)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:14: Warning: A newer version of com.example.ads.thirdparty:example than 7.2.2 is available: 7.3.1 [GradleDependency]
compile 'com.example.ads.thirdparty:example:7.2.2' // OK
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:19: Warning: A newer version of com.example.ads.thirdparty:example than 7.0.5 is available: 7.3.1 [GradleDependency]
compile 'com.example.ads.thirdparty:example:7.0.5' // OK
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:7: Error: This version is known to be insecure. Details: Bad security bug CVE-4311. Consider switching to recommended version 1.2.17. [RiskyLibrary]
compile 'log4j:log4j:1.2.13' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:8: Error: This version is known to be insecure. Details: Bad security bug CVE-4311. Consider switching to recommended version 1.2.17. [RiskyLibrary]
compile 'log4j:log4j:1.2.12' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:9: Error: This version is known to be insecure. Details: Bad security bug CVE-4311. Consider switching to recommended version 1.2.17. [RiskyLibrary]
compile 'log4j:log4j:1.2.4' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:4: Error: This version is deprecated. Details: Deprecated due to ANR issue. Consider switching to recommended version 1.2.17. [OutdatedLibrary]
compile 'log4j:log4j:1.2.16' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:5: Error: This version is deprecated. Details: Deprecated due to ANR issue. Consider switching to recommended version 1.2.17. [OutdatedLibrary]
compile 'log4j:log4j:1.2.15' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:6: Error: This version is deprecated. Details: Deprecated due to ANR issue. Consider switching to recommended version 1.2.17. [OutdatedLibrary]
compile 'log4j:log4j:1.2.14' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:11: Error: This version is obsolete. Details: Library is obsolete. Consider switching to recommended version 1.2.17. [OutdatedLibrary]
compile 'log4j:log4j:0.5' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:15: Error: This version is deprecated. Details: Deprecated due to ANR issue. Consider switching to recommended version 7.3.1. [OutdatedLibrary]
compile 'com.example.ads.thirdparty:example:7.2.1' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:16: Error: This version is deprecated. Details: Deprecated due to ANR issue. Consider switching to recommended version 7.3.1. [OutdatedLibrary]
compile 'com.example.ads.thirdparty:example:7.2.0' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:17: Error: This version is deprecated. Details: Deprecated due to ANR issue. Consider switching to recommended version 7.3.1. [OutdatedLibrary]
compile 'com.example.ads.thirdparty:example:7.1.1' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:18: Error: This version is deprecated. Details: Deprecated due to ANR issue. Consider switching to recommended version 7.3.1. [OutdatedLibrary]
compile 'com.example.ads.thirdparty:example:7.1.0' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:20: Error: This version is deprecated. Details: Deprecated due to ANR issue. Consider switching to recommended version 7.3.1. [OutdatedLibrary]
compile 'com.example.ads.thirdparty:example:7.0.0' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build.gradle:21: Error: This version is deprecated. Details: Deprecated due to ANR issue. Consider switching to recommended version 7.3.1. [OutdatedLibrary]
compile 'com.example.ads.thirdparty:example:6.8.5' // ERROR
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
13 errors, 3 warnings
"""
).expectFixDiffs(
"""
Fix for build.gradle line 10: Change to 1.2.17:
@@ -10 +10
- compile 'log4j:log4j:1.2.3' // OK (not included in range)
+ compile 'log4j:log4j:1.2.17' // OK (not included in range)
Fix for build.gradle line 14: Change to 7.3.1:
@@ -14 +14
- compile 'com.example.ads.thirdparty:example:7.2.2' // OK
+ compile 'com.example.ads.thirdparty:example:7.3.1' // OK
Fix for build.gradle line 19: Change to 7.3.1:
@@ -19 +19
- compile 'com.example.ads.thirdparty:example:7.0.5' // OK
+ compile 'com.example.ads.thirdparty:example:7.3.1' // OK
Fix for build.gradle line 7: Change to 1.2.17:
@@ -7 +7
- compile 'log4j:log4j:1.2.13' // ERROR
+ compile 'log4j:log4j:1.2.17' // ERROR
Fix for build.gradle line 8: Change to 1.2.17:
@@ -8 +8
- compile 'log4j:log4j:1.2.12' // ERROR
+ compile 'log4j:log4j:1.2.17' // ERROR
Fix for build.gradle line 9: Change to 1.2.17:
@@ -9 +9
- compile 'log4j:log4j:1.2.4' // ERROR
+ compile 'log4j:log4j:1.2.17' // ERROR
Fix for build.gradle line 4: Change to 1.2.17:
@@ -4 +4
- compile 'log4j:log4j:1.2.16' // ERROR
+ compile 'log4j:log4j:1.2.17' // ERROR
Fix for build.gradle line 5: Change to 1.2.17:
@@ -5 +5
- compile 'log4j:log4j:1.2.15' // ERROR
+ compile 'log4j:log4j:1.2.17' // ERROR
Fix for build.gradle line 6: Change to 1.2.17:
@@ -6 +6
- compile 'log4j:log4j:1.2.14' // ERROR
+ compile 'log4j:log4j:1.2.17' // ERROR
Fix for build.gradle line 11: Change to 1.2.17:
@@ -11 +11
- compile 'log4j:log4j:0.5' // ERROR
+ compile 'log4j:log4j:1.2.17' // ERROR
Fix for build.gradle line 15: Change to 7.3.1:
@@ -15 +15
- compile 'com.example.ads.thirdparty:example:7.2.1' // ERROR
+ compile 'com.example.ads.thirdparty:example:7.3.1' // ERROR
Fix for build.gradle line 16: Change to 7.3.1:
@@ -16 +16
- compile 'com.example.ads.thirdparty:example:7.2.0' // ERROR
+ compile 'com.example.ads.thirdparty:example:7.3.1' // ERROR
Fix for build.gradle line 17: Change to 7.3.1:
@@ -17 +17
- compile 'com.example.ads.thirdparty:example:7.1.1' // ERROR
+ compile 'com.example.ads.thirdparty:example:7.3.1' // ERROR
Fix for build.gradle line 18: Change to 7.3.1:
@@ -18 +18
- compile 'com.example.ads.thirdparty:example:7.1.0' // ERROR
+ compile 'com.example.ads.thirdparty:example:7.3.1' // ERROR
Fix for build.gradle line 20: Change to 7.3.1:
@@ -20 +20
- compile 'com.example.ads.thirdparty:example:7.0.0' // ERROR
+ compile 'com.example.ads.thirdparty:example:7.3.1' // ERROR
Fix for build.gradle line 21: Change to 7.3.1:
@@ -21 +21
- compile 'com.example.ads.thirdparty:example:6.8.5' // ERROR
+ compile 'com.example.ads.thirdparty:example:7.3.1' // ERROR
"""
)
}
fun testAndroidxMixedDependencies() {
val expected = """
build.gradle: Error: Dependencies using groupId com.android.support and androidx.* can not be combined but found __ and __ incompatible dependencies [GradleCompatible]
1 errors, 0 warnings"""
lint().files(
gradle(
"" +
"buildscript {\n" +
" repositories {\n" +
" jcenter()\n" +
" }\n" +
" dependencies {\n" +
" classpath 'com.android.tools.build:gradle:3.5.0-alpha10'\n" +
" }\n" +
"}\n" +
"dependencies {\n" +
" compile 'com.android.support:recyclerview-v7:28.0.0'\n" +
" compile 'androidx.appcompat:appcompat:1.0.0'\n" +
"}\n"
)
)
.issues(COMPATIBILITY)
.run()
.expect(expected, transformer = TestResultTransformer {
it.replace(
Regex("found .* and .* incompatible"),
"found __ and __ incompatible"
)
})
}
/**
* Tests that the navigation libraries are not considered as part of androidx even when
* their name does start with "androidx."
*/
fun testAndroidxMixedDependenciesWithNavigation() {
lint().files(
gradle(
"" +
"buildscript {\n" +
" repositories {\n" +
" jcenter()\n" +
" }\n" +
" dependencies {\n" +
" classpath 'com.android.tools.build:gradle:3.5.0-alpha10'\n" +
" }\n" +
"}\n" +
"dependencies {\n" +
" compile 'com.android.support:recyclerview-v7:28.0.0'\n" +
" compile 'androidx.navigation:navigation-fragment:1.0.0'\n" +
"}\n"
)
)
.issues(COMPATIBILITY)
.run()
.expect("No warnings.")
}
fun testDataBindingWithKaptUsingApplyPluginSyntax() {
// android.dataBinding.enabled format
lint().files(
gradle(
"""
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-kapt'
android {
dataBinding {
enabled true
}
}
"""
).indented()
)
.issues(DATA_BINDING_WITHOUT_KAPT)
.run()
.expectClean()
// android.buildFeatures.dataBinding format
lint().files(
gradle(
"""
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-kapt'
android {
buildFeatures {
dataBinding true
}
}
"""
).indented()
)
.issues(DATA_BINDING_WITHOUT_KAPT)
.run()
.expectClean()
}
fun testDataBindingWithoutKaptUsingApplyPluginSyntax() {
// android.dataBinding.enabled format
lint().files(
gradle(
"""
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
android {
dataBinding {
enabled true
}
}
"""
).indented()
)
.issues(DATA_BINDING_WITHOUT_KAPT)
.run()
.expect(
"build.gradle:6: Warning: If you plan to use data binding in a Kotlin project, you should apply the kotlin-kapt plugin. [DataBindingWithoutKapt]\n" +
" enabled true\n" +
" ~~~~~~~~~~~~\n" +
"0 errors, 1 warnings"
)
// android.buildFeatures.dataBinding format
lint().files(
gradle(
"""
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
android {
buildFeatures {
dataBinding true
}
}
"""
).indented()
)
.issues(DATA_BINDING_WITHOUT_KAPT)
.run()
.expect(
"build.gradle:6: Warning: If you plan to use data binding in a Kotlin project, you should apply the kotlin-kapt plugin. [DataBindingWithoutKapt]\n" +
" dataBinding true\n" +
" ~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings"
)
}
fun testDataBindingWithKaptUsingPluginBlockSyntax() {
// Test groovy
lint().files(
gradle(
"""
plugins {
id 'com.android.application'
id 'kotlin-android'
id 'kotlin-kapt'
}
android {
dataBinding {
enabled true
}
}
"""
).indented()
)
.issues(DATA_BINDING_WITHOUT_KAPT)
.run()
.expectClean()
// Test kotlin
lint().files(
kts(
"""
plugins {
id("com.android.application")
id("kotlin-android")
id("kotlin-kapt")
}
android {
dataBinding {
isEnabled = true
}
}
"""
).indented()
)
.issues(DATA_BINDING_WITHOUT_KAPT)
.run()
.expectClean()
}
fun testDataBindingWithoutKaptUsingPluginBlockSyntax() {
// Test groovy
lint().files(
gradle(
"""
plugins {
id 'com.android.application'
id 'kotlin-android'
}
android {
dataBinding {
enabled true
}
}
"""
).indented()
)
.issues(DATA_BINDING_WITHOUT_KAPT)
.run()
.expect(
"build.gradle:8: Warning: If you plan to use data binding in a Kotlin project, you should apply the kotlin-kapt plugin. [DataBindingWithoutKapt]\n" +
" enabled true\n" +
" ~~~~~~~~~~~~\n" +
"0 errors, 1 warnings"
)
// Test kotlin
lint().files(
kts(
"""
plugins {
id("com.android.application")
id("kotlin-android")
}
android {
dataBinding {
isEnabled = true
}
}
"""
).indented()
)
.issues(DATA_BINDING_WITHOUT_KAPT)
.run()
.expect(
"build.gradle.kts:8: Warning: If you plan to use data binding in a Kotlin project, you should apply the kotlin-kapt plugin. [DataBindingWithoutKapt]\n" +
" isEnabled = true\n" +
" ~~~~\n" +
"0 errors, 1 warnings"
)
}
fun testDataBindingWithKaptUsingMixedPluginSyntax() {
lint().files(
gradle(
"""
plugins {
id 'com.android.application'
id 'kotlin-android'
}
apply plugin: 'kotlin-kapt'
android {
dataBinding {
enabled true
}
}
""".trimIndent()
)
)
.issues(DATA_BINDING_WITHOUT_KAPT)
.run()
.expectClean()
}
fun testJava8WithLifecycleAnnotationProcessor() {
lint().files(
gradle(
"dependencies {\n" +
" implementation \"android.arch.lifecycle:runtime:1.1.1\"\n" +
" annotationProcessor \"android.arch.lifecycle:compiler:1.1.1\"\n" +
"}" +
"android {\n" +
" compileOptions {\n" +
" sourceCompatibility JavaVersion.VERSION_1_8\n" +
" targetCompatibility JavaVersion.VERSION_1_8\n" +
" }\n" +
"}"
)
)
.issues(LIFECYCLE_ANNOTATION_PROCESSOR_WITH_JAVA8)
.run()
.expect(
"" +
"build.gradle:3: Warning: Use the Lifecycle Java 8 API provided by the lifecycle-common-java8 library instead of Lifecycle annotations for faster incremental build. [LifecycleAnnotationProcessorWithJava8]\n" +
" annotationProcessor \"android.arch.lifecycle:compiler:1.1.1\"\n" +
" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" +
"0 errors, 1 warnings"
)
}
fun testJava8WithoutLifecycleAnnotationProcessor() {
lint().files(
gradle(
"dependencies {\n" +
" implementation \"android.arch.lifecycle:runtime:1.1.1\"\n" +
" implementation \"android.arch.lifecycle:common-java8:1.1.1\"\n" +
"}" +
"android {\n" +
" compileOptions {\n" +
" sourceCompatibility JavaVersion.VERSION_1_8\n" +
" targetCompatibility JavaVersion.VERSION_1_8\n" +
" }\n" +
"}"
)
)
.issues(LIFECYCLE_ANNOTATION_PROCESSOR_WITH_JAVA8)
.run()
.expectClean()
}
fun testJava7WithLifecycleAnnotationProcessor() {
lint().files(
gradle(
"dependencies {\n" +
" implementation \"android.arch.lifecycle:runtime:1.1.1\"\n" +
" annotationProcessor \"android.arch.lifecycle:compiler:1.1.1\"\n" +
"}" +
"android {\n" +
" compileOptions {\n" +
" sourceCompatibility JavaVersion.VERSION_1_7\n" +
" targetCompatibility JavaVersion.VERSION_1_7\n" +
" }\n" +
"}"
)
)
.issues(LIFECYCLE_ANNOTATION_PROCESSOR_WITH_JAVA8)
.run()
.expectClean()
}
fun testCompileDeprecationInConsumableModule() {
val expected = """
build.gradle:9: Warning: compile is deprecated; replace with either api to maintain current behavior, or implementation to improve build performance by not sharing this dependency transitively. [GradleDeprecatedConfiguration]
compile 'androidx.appcompat:appcompat:1.0.0'
~~~~~~~
build.gradle:10: Warning: debugCompile is deprecated; replace with either debugApi to maintain current behavior, or debugImplementation to improve build performance by not sharing this dependency transitively. [GradleDeprecatedConfiguration]
debugCompile 'androidx.appcompat:appcompat:1.0.0'
~~~~~~~~~~~~
0 errors, 2 warnings"""
val expectedFix = """
Fix for build.gradle line 9: Replace 'compile' with 'api':
@@ -9 +9
- compile 'androidx.appcompat:appcompat:1.0.0'
+ api 'androidx.appcompat:appcompat:1.0.0'
Fix for build.gradle line 9: Replace 'compile' with 'implementation':
@@ -9 +9
- compile 'androidx.appcompat:appcompat:1.0.0'
+ implementation 'androidx.appcompat:appcompat:1.0.0'
Fix for build.gradle line 10: Replace 'debugCompile' with 'debugApi':
@@ -10 +10
- debugCompile 'androidx.appcompat:appcompat:1.0.0'
+ debugApi 'androidx.appcompat:appcompat:1.0.0'
Fix for build.gradle line 10: Replace 'debugCompile' with 'debugImplementation':
@@ -10 +10
- debugCompile 'androidx.appcompat:appcompat:1.0.0'
+ debugImplementation 'androidx.appcompat:appcompat:1.0.0'""".trimIndent()
lint()
.files(
gradle(
"""
buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.0.0'
}
}
apply plugin: 'com.android.library'
dependencies {
compile 'androidx.appcompat:appcompat:1.0.0'
debugCompile 'androidx.appcompat:appcompat:1.0.0'
}
""".trimIndent()
)
)
.issues(DEPRECATED_CONFIGURATION)
.run()
.expect(expected)
.expectFixDiffs(expectedFix)
}
fun testCompileDeprecationInLeafModule() {
val expected = """
build.gradle:9: Warning: compile is deprecated; replace with implementation [GradleDeprecatedConfiguration]
compile 'androidx.appcompat:appcompat:1.0.0'
~~~~~~~
0 errors, 1 warnings"""
val expectedFix = """
Fix for build.gradle line 9: Replace 'compile' with 'implementation':
@@ -9 +9
- compile 'androidx.appcompat:appcompat:1.0.0'
+ implementation 'androidx.appcompat:appcompat:1.0.0'
""".trimIndent()
lint()
.files(
gradle(
"""
buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.0.0'
}
}
apply plugin: 'com.android.application'
dependencies {
compile 'androidx.appcompat:appcompat:1.0.0'
}
""".trimIndent()
)
)
.issues(DEPRECATED_CONFIGURATION)
.run()
.expect(expected)
.expectFixDiffs(expectedFix)
}
fun testTestCompileDeprecation() {
val expected = """
build.gradle:7: Warning: testCompile is deprecated; replace with testImplementation [GradleDeprecatedConfiguration]
testCompile 'androidx.appcompat:appcompat:1.0.0'
~~~~~~~~~~~
build.gradle:8: Warning: testDebugCompile is deprecated; replace with testDebugImplementation [GradleDeprecatedConfiguration]
testDebugCompile 'androidx.appcompat:appcompat:1.0.0'
~~~~~~~~~~~~~~~~
build.gradle:9: Warning: androidTestDebugCompile is deprecated; replace with androidTestDebugImplementation [GradleDeprecatedConfiguration]
androidTestDebugCompile 'androidx.appcompat:appcompat:1.0.0'
~~~~~~~~~~~~~~~~~~~~~~~
0 errors, 3 warnings
"""
val fixDiff =
"Fix for build.gradle line 7: Replace 'testCompile' with 'testImplementation':\n" +
"@@ -7 +7\n" +
"- testCompile 'androidx.appcompat:appcompat:1.0.0'\n" +
"+ testImplementation 'androidx.appcompat:appcompat:1.0.0'\n" +
"Fix for build.gradle line 8: Replace 'testDebugCompile' with 'testDebugImplementation':\n" +
"@@ -8 +8\n" +
"- testDebugCompile 'androidx.appcompat:appcompat:1.0.0'\n" +
"+ testDebugImplementation 'androidx.appcompat:appcompat:1.0.0'\n" +
"Fix for build.gradle line 9: Replace 'androidTestDebugCompile' with 'androidTestDebugImplementation':\n" +
"@@ -9 +9\n" +
"- androidTestDebugCompile 'androidx.appcompat:appcompat:1.0.0'\n" +
"+ androidTestDebugImplementation 'androidx.appcompat:appcompat:1.0.0'"
lint().files(
gradle(
"""
buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.0.0'
}
}
dependencies {
testCompile 'androidx.appcompat:appcompat:1.0.0'
testDebugCompile 'androidx.appcompat:appcompat:1.0.0'
androidTestDebugCompile 'androidx.appcompat:appcompat:1.0.0'
}
""".trimIndent()
)
)
.issues(DEPRECATED_CONFIGURATION)
.run()
.expect(expected)
.expectFixDiffs(fixDiff)
}
fun testAnnotationProcessorOnCompilePath() {
val expected = """
build.gradle:2: Warning: Add annotation processor to processor path using annotationProcessor instead of api [AnnotationProcessorOnCompilePath]
api 'com.jakewharton:butterknife-compiler:10.1.0'
~~~
build.gradle:3: Warning: Add annotation processor to processor path using annotationProcessor instead of implementation [AnnotationProcessorOnCompilePath]
implementation 'com.github.bumptech.glide:compiler:4.9.0'
~~~~~~~~~~~~~~
build.gradle:4: Warning: Add annotation processor to processor path using annotationProcessor instead of compile [AnnotationProcessorOnCompilePath]
compile "androidx.lifecycle:lifecycle-compiler:2.2.0-alpha01"
~~~~~~~
build.gradle:5: Warning: Add annotation processor to processor path using testAnnotationProcessor instead of testImplementation [AnnotationProcessorOnCompilePath]
testImplementation "com.google.auto.value:auto-value:1.6.2"
~~~~~~~~~~~~~~~~~~
build.gradle:6: Warning: Add annotation processor to processor path using androidTestAnnotationProcessor instead of androidTestCompile [AnnotationProcessorOnCompilePath]
androidTestCompile "org.projectlombok:lombok:1.18.8"
~~~~~~~~~~~~~~~~~~
build.gradle:8: Warning: Add annotation processor to processor path using debugAnnotationProcessor instead of debugCompile [AnnotationProcessorOnCompilePath]
debugCompile "android.arch.persistence.room:compiler:1.1.1"
~~~~~~~~~~~~
0 errors, 6 warnings
"""
val fixDiff = """
Fix for build.gradle line 2: Replace api with annotationProcessor:
@@ -2 +2
- api 'com.jakewharton:butterknife-compiler:10.1.0'
+ annotationProcessor 'com.jakewharton:butterknife-compiler:10.1.0'
Fix for build.gradle line 3: Replace implementation with annotationProcessor:
@@ -3 +3
- implementation 'com.github.bumptech.glide:compiler:4.9.0'
+ annotationProcessor 'com.github.bumptech.glide:compiler:4.9.0'
Fix for build.gradle line 4: Replace compile with annotationProcessor:
@@ -4 +4
- compile "androidx.lifecycle:lifecycle-compiler:2.2.0-alpha01"
+ annotationProcessor "androidx.lifecycle:lifecycle-compiler:2.2.0-alpha01"
Fix for build.gradle line 5: Replace testImplementation with testAnnotationProcessor:
@@ -5 +5
- testImplementation "com.google.auto.value:auto-value:1.6.2"
+ testAnnotationProcessor "com.google.auto.value:auto-value:1.6.2"
Fix for build.gradle line 6: Replace androidTestCompile with androidTestAnnotationProcessor:
@@ -6 +6
- androidTestCompile "org.projectlombok:lombok:1.18.8"
+ androidTestAnnotationProcessor "org.projectlombok:lombok:1.18.8"
Fix for build.gradle line 8: Replace debugCompile with debugAnnotationProcessor:
@@ -8 +8
- debugCompile "android.arch.persistence.room:compiler:1.1.1"
+ debugAnnotationProcessor "android.arch.persistence.room:compiler:1.1.1"
"""
lint().files(
gradle(
"""
dependencies {
api 'com.jakewharton:butterknife-compiler:10.1.0'
implementation 'com.github.bumptech.glide:compiler:4.9.0'
compile "androidx.lifecycle:lifecycle-compiler:2.2.0-alpha01"
testImplementation "com.google.auto.value:auto-value:1.6.2"
androidTestCompile "org.projectlombok:lombok:1.18.8"
annotationProcessor 'com.jakewharton:butterknife-compiler:10.1.0'
debugCompile "android.arch.persistence.room:compiler:1.1.1"
implementation "com.jakewharton:butterknife:10.1.0"
}
"""
).indented()
)
.issues(ANNOTATION_PROCESSOR_ON_COMPILE_PATH)
.run()
.expect(expected)
.expectFixDiffs(fixDiff)
}
fun testKtxExtensions() {
lint().files(
gradle(
"""
plugins {
id 'com.android.application'
id 'kotlin-android'
}
dependencies {
implementation "org.jetbrains.kotlin:kotlin-stdlib:1.0.0"
implementation "androidx.core:core:1.2.0"
implementation "androidx.core:core:999.2.0" // No KTX extensions for this version.
implementation "androidx.core:fake-artifact:1.2.0" // No KTX extensions for this artifact.
}
"""
).indented()
)
.issues(KTX_EXTENSION_AVAILABLE)
.run()
.expect("""
build.gradle:7: Information: Add suffix -ktx to enable the Kotlin extensions for this library [KtxExtensionAvailable]
implementation "androidx.core:core:1.2.0"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
0 errors, 0 warnings
""")
.expectFixDiffs("""
Fix for build.gradle line 7: Replace with KTX dependency:
@@ -7 +7
- implementation "androidx.core:core:1.2.0"
+ implementation "androidx.core:core-ktx:1.2.0"
""".trimIndent())
}
fun testKtxExtensionsClean() {
// Expect clean when the project does not depend on Kotlin.
lint().files(
gradle(
"""
plugins {
id 'com.android.application'
}
dependencies {
implementation "androidx.core:core:1.2.0"
}
"""
).indented()
)
.issues(KTX_EXTENSION_AVAILABLE)
.run()
.expectClean()
// Expect clean when the project only depends on Kotlin for tests.
lint().files(
gradle(
"""
plugins {
id 'com.android.application'
id 'kotlin-android'
}
dependencies {
testImplementation "org.jetbrains.kotlin:kotlin-stdlib:1.0.0"
implementation "androidx.core:core:1.2.0"
}
"""
).indented()
)
.issues(KTX_EXTENSION_AVAILABLE)
.run()
.expectClean()
}
// -------------------------------------------------------------------------------------------
// Test infrastructure below here
// -------------------------------------------------------------------------------------------
override fun getDetector(): Detector {
return GroovyGradleDetector()
}
class GroovyGradleDetector : GradleDetector() {
override val gradleUserHome: File
get() = GradleDetectorTest.gradleUserHome ?: super.gradleUserHome
}
companion object {
private var sdkRootDir: File? = null
private var fullSdkDir: File? = null
private var leanSdkDir: File? = null
private var gradleUserHome: File? = null
/** Creates a mock SDK installation structure, containing a fixed set of dependencies */
private val mockSupportLibraryInstallation: File?
get() {
initializeMockSdkDirs()
return fullSdkDir
}
/** Like [.getMockSupportLibraryInstallation] but without local support library */
private val sdkDirWithoutSupportLib: File?
get() {
initializeMockSdkDirs()
return leanSdkDir
}
@JvmStatic
fun createRelativePaths(sdkDir: File, paths: Array<String>) {
for (path in paths) {
val file = File(sdkDir, path.replace('/', File.separatorChar))
val parent = file.parentFile
if (!parent.exists()) {
val ok = parent.mkdirs()
TestCase.assertTrue(parent.path, ok)
}
try {
val created = file.createNewFile()
TestCase.assertTrue(file.path, created)
} catch (e: IOException) {
TestCase.fail(e.toString())
}
}
}
private fun initializeMockSdkDirs() {
if (sdkRootDir == null) {
// Make fake SDK "installation" such that we can predict the set
// of Maven repositories discovered by this test
sdkRootDir = TestUtils.createTempDirDeletedOnExit()
fullSdkDir = File(sdkRootDir, "full")
createRelativePaths(
fullSdkDir!!,
arrayOf(
// build tools
"build-tools/23.0.0/aapt",
"build-tools/23.0.3/aapt"
)
)
leanSdkDir = File(sdkRootDir, "lean")
createRelativePaths(
leanSdkDir!!,
arrayOf(
// build tools
"build-tools/23.0.0/aapt", "build-tools/23.0.3/aapt"
)
)
// Test-isolated version of ~/.gradle/
gradleUserHome = File(sdkRootDir, "gradle-user-home")
createRelativePaths(
gradleUserHome!!,
arrayOf(
"caches/modules-2/files-2.1/com.android.tools.build/gradle/2.2.0/dummy",
"caches/modules-2/files-2.1/com.android.tools.build/gradle/2.2.3/dummy",
"caches/modules-2/files-2.1/com.android.tools.build/gradle/2.3.0/dummy",
"caches/modules-2/files-2.1/com.android.tools.build/gradle/2.3.1/dummy",
"caches/modules-2/files-2.1/com.android.tools.build/gradle/2.4.0-alpha3/dummy",
"caches/modules-2/files-2.1/com.android.tools.build/gradle/2.4.0-alpha5/dummy",
"caches/modules-2/files-2.1/com.android.tools.build/gradle/2.4.0-alpha6/dummy",
"caches/modules-2/files-2.1/com.google.guava/guava/17.0/dummy",
"caches/modules-2/files-2.1/org.apache.httpcomponents/httpcomponents-core/4.1/dummy",
"caches/modules-2/files-2.1/org.apache.httpcomponents/httpcomponents-core/4.2.1/dummy",
"caches/modules-2/files-2.1/org.apache.httpcomponents/httpcomponents-core/4.2.5/dummy",
"caches/modules-2/files-2.1/org.apache.httpcomponents/httpcomponents-core/4.4/dummy",
// SDK distributed via Maven
"caches/modules-2/files-2.1/com.android.support/recyclerview-v7/26.0.0/dummy",
"caches/modules-2/files-2.1/com.google.firebase/firebase-messaging/11.0.0/dummy"
)
)
}
}
fun initializeNetworkMocksAndCaches(task: TestLintTask): TestLintTask {
// Set up exactly the expected maven.google.com network output to ensure stable
// version suggestions in the tests
task.networkData(
"https://maven.google.com/master-index.xml",
"""
<?xml version='1.0' encoding='UTF-8'?>
<metadata>
<com.android.support/>
<com.android.support.test/>
<com.android.tools/>
<com.android.tools.build/>
<com.google.android.gms/>
<com.google.android.support/>
<androidx.core/>
</metadata>
""".trimIndent()
)
task.networkData(
"https://maven.google.com/com/android/tools/build/group-index.xml",
"" +
"<?xml version='1.0' encoding='UTF-8'?>\n" +
"<com.android.tools.build>\n" +
" <gradle versions=\"3.0.0-alpha1,3.0.0-alpha2,3.0.0-alpha3,3.0.0-alpha4,3.0.0-alpha5,3.0.0-alpha6,3.0.0-alpha7,3.0.0-alpha8,3.0.0-alpha9,3.0.0-beta1,3.0.0-beta2,3.0.0-beta3,3.0.0-beta4,3.0.0-beta5,3.0.0-beta6,3.0.0-beta7,3.0.0-rc1,3.0.0-rc2,3.0.0,3.0.1," +
"3.1.0-alpha01,3.1.0-alpha02,3.1.0-alpha03,3.1.0-alpha04,3.1.0-alpha05,3.1.0-alpha06,3.1.0-alpha07,3.1.0-alpha08,3.1.0-alpha09,3.1.0-beta1,3.1.0-beta2,3.1.0-beta3,3.1.0-beta4,3.1.0-rc1,3.1.0," +
"3.2.0-alpha01,3.2.0-alpha02,3.2.0-alpha03,3.2.0-alpha04,3.2.0-alpha05,3.2.0-alpha06,3.2.0-alpha07,3.2.0-alpha08,3.2.0-alpha09,3.2.0-alpha10,3.2.0-alpha11,3.2.0-alpha12,3.2.0-alpha13,3.2.0-alpha14,3.2.0-alpha15,3.2.0-alpha16,3.2.0-alpha17,3.2.0-alpha18,3.2.0-beta01,3.2.0-beta02,3.2.0-beta03,3.2.0-beta04,3.2.0-beta05,3.2.0-rc01,3.2.0-rc02,3.2.0-rc03,3.2.0,3.2.1," +
"3.3.0-alpha01,3.3.0-alpha02,3.3.0-alpha03,3.3.0-alpha04,3.3.0-alpha05,3.3.0-alpha06,3.3.0-alpha07,3.3.0-alpha08,3.3.0-alpha09,3.3.0-alpha10,3.3.0-alpha11,3.3.0-alpha12,3.3.0-alpha13,3.3.0-beta01,3.3.0-beta02,3.3.0-beta03,3.3.0-beta04,3.3.0-rc01,3.3.0-rc02,3.3.0-rc03,3.3.0,3.3.1,3.3.2," +
"3.4.0-alpha01,3.4.0-alpha02,3.4.0-alpha03,3.4.0-alpha04,3.4.0-alpha05,3.4.0-alpha06,3.4.0-alpha07,3.4.0-alpha08,3.4.0-alpha09,3.4.0-alpha10,3.4.0-beta01,3.4.0-beta02,3.4.0-beta03,3.4.0-beta04,3.4.0-beta05,3.4.0-rc01,3.4.0-rc02,3.4.0-rc03," +
"3.5.0-alpha01,3.5.0-alpha02,3.5.0-alpha03,3.5.0-alpha04,3.5.0-alpha05,3.5.0-alpha06,3.5.0-alpha07,3.5.0-alpha08,3.5.0-alpha09,3.5.0-alpha10\"/>\n" +
"</com.android.tools.build>"
)
task.networkData(
"https://maven.google.com/com/android/support/group-index.xml",
"""
<?xml version='1.0' encoding='UTF-8'?>
<com.android.support>
<support-compat versions="19.1.0,25.3.1,26.0.0-beta1"/>
<appcompat-v7 versions="19.1.0, 19.1.0,25.3.1,26.0.0-beta1"/>
<multidex versions="1.0.1,1.0.1"/>
<support-v4 versions="19.1.0,21.0.2,25.3.1,26.0.0-beta1"/>
</com.android.support>
""".trimIndent()
)
task.networkData(
"https://maven.google.com/com/google/android/support/group-index.xml",
"""
<?xml version='1.0' encoding='UTF-8'?>
<com.google.android.support>
<wearable versions="1.3.0,26.0.0-alpha1"/>
</com.google.android.support>
""".trimIndent()
)
task.networkData(
"https://maven.google.com/com/google/android/gms/group-index.xml",
"""
<?xml version='1.0' encoding='UTF-8'?>
<com.google.android.gms>
<play-services-wearable versions="6.1.71"/>
<play-services versions="11.1.71"/>
</com.google.android.gms>
""".trimIndent()
)
task.networkData(
"https://maven.google.com/com/android/support/constraint/group-index.xml",
"""
<?xml version='1.0' encoding='UTF-8'?>
<com.android.support.constraint>
<constraint-layout versions="1.0.0,1.0.2"/>
</com.android.support.constraint>
""".trimIndent()
)
task.networkData(
"https://maven.google.com/com/android/support/test/group-index.xml",
"""
<?xml version='1.0' encoding='UTF-8'?>
<com.android.support.test>
<runner versions="0.3,0.5"/>
</com.android.support.test>
""".trimIndent()
)
task.networkData(
"https://maven.google.com/androidx/core/group-index.xml",
"""
<?xml version="1.0" encoding="UTF-8"?>
<androidx.core>
<core-ktx versions="1.2.0"/>
<core versions="1.2.0"/>
</androidx.core>
""".trimIndent()
)
// Similarly set up the expected SDK registry network output from dl.google.com to
// ensure stable SDK library suggestions in the tests
task.networkData(
SDK_REGISTRY_URL,
"""
<sdk_metadata>
<library groupId="com.android.volley" artifactId="volley" recommended-version="1.1.0">
<versions from="1.1.0-rc2" status="deprecated" description="Bug affecting app stability" url="https://github.com/google/volley/releases" />
<versions from="1.1.0-rc1" status="deprecated" description="Bug affecting app stability" url="https://github.com/google/volley/releases" />
<versions from="1.0.0" status="deprecated" description="Bug affecting app stability" url="https://github.com/google/volley/releases" />
</library>
<library groupId="log4j" artifactId="log4j" recommended-version="1.2.17" recommended-version-sha="5af35056b4d257e4b64b9e8069c0746e8b08629f">
<versions from="1.2.14" to="1.2.16" status="deprecated" description="Deprecated due to ANR issue">
<vulnerability description="Specifics and developer actions go here." cve="CVE-4313" />
</versions>
<versions from="1.2.4" to="1.2.13" status="insecure" description="Bad security bug CVE-4311" />
<vulnerability description="Buffer overflow vulnerability in this version." cve="CVE-4311" />
<versions to="1.2.0" status="obsolete" description="Library is obsolete." />
</library>
<library groupId="com.example.ads.thirdparty" artifactId="example" recommended-version="7.3.1">
<versions from="7.1.0" to="7.2.1" status="deprecated" description="Deprecated due to ANR issue">
<vulnerability description="Specifics and developer actions go here." />
</versions>
<versions to="7.0.0" status="deprecated" description="Deprecated due to ANR issue">
<vulnerability description="Specifics and developer actions go here." />
</versions>
</library>
</sdk_metadata>
""".trimIndent()
)
// Also ensure we don't have a stale cache on disk.
val cacheDir =
com.android.tools.lint.checks.infrastructure.TestLintClient()
.getCacheDir(MAVEN_GOOGLE_CACHE_DIR_KEY, true)
if (cacheDir != null && cacheDir.isDirectory) {
try {
FileUtils.deleteDirectoryContents(cacheDir)
} catch (e: IOException) {
fail(e.message)
}
}
val client: com.android.tools.lint.checks.infrastructure.TestLintClient =
object : com.android.tools.lint.checks.infrastructure.TestLintClient() {
override fun getSdkHome(): File? {
if (task.sdkHome != null) {
return task.sdkHome
}
return mockSupportLibraryInstallation
}
override fun getHighestKnownVersion(
coordinate: GradleCoordinate,
filter: Predicate<GradleVersion>?
): GradleVersion? {
// Hardcoded for unit test to ensure stable data
return if ("com.android.support.constraint" == coordinate.groupId && "constraint-layout" == coordinate.artifactId) {
if (coordinate.isPreview) {
GradleVersion.tryParse("1.0.3-alpha8")
} else {
GradleVersion.tryParse("1.0.2")
}
} else null
}
}
task.client(client)
val cacheDir2 =
com.android.tools.lint.checks.infrastructure.TestLintClient()
.getCacheDir(DEPRECATED_SDK_CACHE_DIR_KEY, true)
if (cacheDir2 != null && cacheDir2.isDirectory) {
try {
FileUtils.deleteDirectoryContents(cacheDir2)
} catch (e: IOException) {
fail(e.message)
}
}
return task
}
// Utility for testOR2RequiresAppCompat26Beta1
private fun getClientWithMockPlatformTarget(
version: AndroidVersion,
revision: Int
): com.android.tools.lint.checks.infrastructure.TestLintClient {
return object : com.android.tools.lint.checks.infrastructure.TestLintClient() {
override fun getCompileTarget(project: Project): IAndroidTarget {
val target = mock(IAndroidTarget::class.java)
`when`(target.revision).thenReturn(revision)
`when`(target.version).thenReturn(version)
return target
}
}
}
private val IMPLEMENTATION =
Implementation(GroovyGradleDetector::class.java, Scope.GRADLE_SCOPE)
init {
for (issue in TestIssueRegistry().issues) {
if (issue.implementation.detectorClass == GradleDetector::class.java) {
issue.implementation = IMPLEMENTATION
}
}
}
}
}