commit ac773deff2287f0f3a2da52919efa2eefd574970
author Sen Jiang <senj@google.com> Thu Apr 26 15:50:13 2018 -0700
committer Sen Jiang <senj@google.com> Sat Apr 28 00:13:48 2018 +0000
tree 46917af5f20dba2f1c1a3e421bb20bbd5933a221
parent 128936fb266af57d19e1faced52d686d271519d6

Move calling BZ2_bzDecompressEnd() to destructor.

Not calling it could lead to memory leaks.

Test: fail a REPLACE_BZ operation repeatedly
Change-Id: I898b5c71f8963a70647ae08ae81466e22b98cbfb

payload_consumer/bzip_extent_writer.cc

diff --git a/payload_consumer/bzip_extent_writer.cc b/payload_consumer/bzip_extent_writer.cc
index 39d9d67..7828589 100644
--- a/payload_consumer/bzip_extent_writer.cc
+++ b/payload_consumer/bzip_extent_writer.cc
@@ -24,6 +24,10 @@
 const brillo::Blob::size_type kOutputBufferLength = 16 * 1024;
 }
 
+BzipExtentWriter::~BzipExtentWriter() {
+  TEST_AND_RETURN(BZ2_bzDecompressEnd(&stream_) == BZ_OK);
+}
+
 bool BzipExtentWriter::Init(FileDescriptorPtr fd,
                             const RepeatedPtrField<Extent>& extents,
                             uint32_t block_size) {
@@ -84,7 +88,6 @@
 
 bool BzipExtentWriter::EndImpl() {
   TEST_AND_RETURN_FALSE(input_buffer_.empty());
-  TEST_AND_RETURN_FALSE(BZ2_bzDecompressEnd(&stream_) == BZ_OK);
   return next_->End();
 }
 

payload_consumer/bzip_extent_writer.h

diff --git a/payload_consumer/bzip_extent_writer.h b/payload_consumer/bzip_extent_writer.h
index 86b346a..710727f 100644
--- a/payload_consumer/bzip_extent_writer.h
+++ b/payload_consumer/bzip_extent_writer.h
@@ -38,7 +38,7 @@
       : next_(std::move(next)) {
     memset(&stream_, 0, sizeof(stream_));
   }
-  ~BzipExtentWriter() override = default;
+  ~BzipExtentWriter() override;
 
   bool Init(FileDescriptorPtr fd,
             const google::protobuf::RepeatedPtrField<Extent>& extents,