Fix presubmit script failures on Windows
Perfetto's root PRESUBMIT.py file invokes child scripts in a way that
doesn't work on Windows, leading to cryptic failures if the presubmits
are run on Windows (either directly or through git cl upload). Since
Windows support is clearly not a priority this change fixes this by
disabling the problematic tests on Windows.
With this change "git cl presubmit" passes successfully on
https://android-review.googlesource.com/c/platform/external/perfetto/+/2660235.
Change-Id: I9f232134a41d45dea9bd2a4a94905789adf296a2
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 7b11412..b8dbf70 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -93,6 +93,10 @@
def CheckBuild(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/gen_bazel'
# If no GN files were modified, bail out.
@@ -111,6 +115,10 @@
def CheckAndroidBlueprint(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/gen_android_bp'
# If no GN files were modified, bail out.
@@ -129,6 +137,10 @@
def CheckIncludeGuards(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/fix_include_guards'
def file_filter(x):
@@ -193,6 +205,10 @@
def CheckIncludeViolations(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/check_include_violations'
def file_filter(x):
@@ -207,6 +223,10 @@
def CheckBinaryDescriptors(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/gen_binary_descriptors'
def file_filter(x):
@@ -224,6 +244,10 @@
def CheckMergedTraceConfigProto(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/gen_merged_protos'
def build_file_filter(x):
@@ -257,6 +281,10 @@
def CheckProtoComments(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/check_proto_comments'
def file_filter(x):
@@ -271,6 +299,10 @@
def CheckSqlModules(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/check_sql_modules.py'
def file_filter(x):
@@ -285,6 +317,10 @@
def CheckSqlMetrics(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/check_sql_metrics.py'
def file_filter(x):
@@ -299,6 +335,10 @@
def CheckTestData(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/test_data'
if subprocess.call([tool, 'status', '--quiet']):
return [
@@ -313,6 +353,10 @@
def CheckAmalgamatedPythonTools(input_api, output_api):
+ # The script invocation doesn't work on Windows.
+ if input_api.is_windows:
+ return []
+
tool = 'tools/gen_amalgamated_python_tools'
# If no GN files were modified, bail out.
