commit ecc5b59a7069ab080a892e3f6a413ef62d3afee2
author Rhys Perry <pendingchaos02@gmail.com> Mon Aug 17 11:36:24 2020 +0100
committer Marge Bot <eric+marge@anholt.net> Thu Oct 29 18:08:31 2020 +0000
tree 002e9f936bbbe6c339a99ccacf0765122ac7ff1e
parent bb890f2e7c1bc941cd72483686723fe0fbe51625

aco: don't allow destination opsel for v_cvt_pknorm

It doesn't make sense to do this.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7349>

src/amd/compiler/aco_ir.cpp

diff --git a/src/amd/compiler/aco_ir.cpp b/src/amd/compiler/aco_ir.cpp
index f794125..a258447 100644
--- a/src/amd/compiler/aco_ir.cpp
+++ b/src/amd/compiler/aco_ir.cpp
@@ -310,14 +310,14 @@
    case aco_opcode::v_sub_i16:
    case aco_opcode::v_add_u16_e64:
    case aco_opcode::v_sub_u16_e64:
-   case aco_opcode::v_cvt_pknorm_i16_f16:
-   case aco_opcode::v_cvt_pknorm_u16_f16:
    case aco_opcode::v_lshlrev_b16_e64:
    case aco_opcode::v_lshrrev_b16_e64:
    case aco_opcode::v_ashrrev_i16_e64:
    case aco_opcode::v_mul_lo_u16_e64:
       return true;
    case aco_opcode::v_pack_b32_f16:
+   case aco_opcode::v_cvt_pknorm_i16_f16:
+   case aco_opcode::v_cvt_pknorm_u16_f16:
       return idx != -1;
    case aco_opcode::v_mad_u32_u16:
    case aco_opcode::v_mad_i32_i16: