commit f08aa3e023a0ca1d11324944d161133609a171d1
author Jens Wiklander <jens.wiklander@linaro.org> Thu Jan 17 13:30:57 2019 +0100
committer Jens Wiklander <jens.wiklander@linaro.org> Thu Jan 17 13:30:57 2019 +0100
tree bfd78b03ad095b4ef0f069ffc42cd8591c897499
parent 62ec2dd68f92b1970ff3cdcdccf652837a359680

fix memory leak in mpi_miller_rabin()

Fixes memory leak in mpi_miller_rabin() that occurs when the function has
failed to obtain a usable random 'A' 30 turns in a row.

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

library/bignum.c

diff --git a/library/bignum.c b/library/bignum.c
index d3d02b1..606bca4 100644
--- a/library/bignum.c
+++ b/library/bignum.c
@@ -2329,7 +2329,8 @@
             }
 
             if (count++ > 30) {
-                return MBEDTLS_ERR_MPI_NOT_ACCEPTABLE;
+                ret = MBEDTLS_ERR_MPI_NOT_ACCEPTABLE;
+                goto cleanup;
             }
 
         } while ( mbedtls_mpi_cmp_mpi( &A, &W ) >= 0 ||