commit e89488debf6d3a708c9d65eb4863251bd0e5c639
author Raef Coles <raef.coles@arm.com> Fri Oct 07 16:06:35 2022 +0100
committer Raef Coles <raef.coles@arm.com> Thu Oct 13 14:29:27 2022 +0100
tree b4a6a974b4ec56612bbfb993b81fcda8dc9fa931
parent 3f6cdd7aab90fa6b4830349916d994a05d6f8f79

Fix bug in LMS public key loading

To avoid using the type before it is parsed from the signature

Signed-off-by: Raef Coles <raef.coles@arm.com>

library/lmots.c

diff --git a/library/lmots.c b/library/lmots.c
index 059d6c8..9168ef1 100644
--- a/library/lmots.c
+++ b/library/lmots.c
@@ -409,6 +409,11 @@
 int mbedtls_lmots_import_public_key( mbedtls_lmots_public_t *ctx,
                                  const unsigned char *key, size_t key_len )
 {
+    if( key_len < MBEDTLS_LMOTS_SIG_TYPE_OFFSET + MBEDTLS_LMOTS_TYPE_LEN )
+    {
+        return( MBEDTLS_ERR_LMS_BAD_INPUT_DATA );
+    }
+
     ctx->params.type =
         mbedtls_lms_network_bytes_to_unsigned_int( MBEDTLS_LMOTS_TYPE_LEN,
                 key + MBEDTLS_LMOTS_SIG_TYPE_OFFSET );

library/lms.c

diff --git a/library/lms.c b/library/lms.c
index a4235ad..fba5d88 100644
--- a/library/lms.c
+++ b/library/lms.c
@@ -235,11 +235,6 @@
     mbedtls_lms_algorithm_type_t type;
     mbedtls_lmots_algorithm_type_t otstype;
 
-    if( key_size != MBEDTLS_LMS_PUBLIC_KEY_LEN(ctx->params.type) )
-    {
-        return( MBEDTLS_ERR_LMS_BAD_INPUT_DATA );
-    }
-
     type = mbedtls_lms_network_bytes_to_unsigned_int( MBEDTLS_LMS_TYPE_LEN,
             key + PUBLIC_KEY_TYPE_OFFSET );
     if( type != MBEDTLS_LMS_SHA256_M32_H10 )
@@ -248,6 +243,11 @@
     }
     ctx->params.type = type;
 
+    if( key_size != MBEDTLS_LMS_PUBLIC_KEY_LEN(ctx->params.type) )
+    {
+        return( MBEDTLS_ERR_LMS_BAD_INPUT_DATA );
+    }
+
     otstype = mbedtls_lms_network_bytes_to_unsigned_int( MBEDTLS_LMOTS_TYPE_LEN,
             key + PUBLIC_KEY_OTSTYPE_OFFSET );
     if( otstype != MBEDTLS_LMOTS_SHA256_N32_W8 )