commit 989f06d52d32e7f640c264e86242d4a6c0bc3ada
author XiaokangQian <xiaokang.qian@arm.com> Tue May 17 01:50:15 2022 +0000
committer XiaokangQian <xiaokang.qian@arm.com> Thu May 26 00:47:11 2022 +0000
tree 05103479805f9d6e1d42f78a9c9fa98c599d6faf
parent 63e713e8abe5201e5bea917eb3341de25b8ebae5

Change some comments base on review

Change-Id: I3db2b8ca8162eb368d2f17dfeffee8b25f9edf6f
Signed-off-by: XiaokangQian <xiaokang.qian@arm.com>

library/ssl_tls13_generic.c

diff --git a/library/ssl_tls13_generic.c b/library/ssl_tls13_generic.c
index ef27644..49ed112 100644
--- a/library/ssl_tls13_generic.c
+++ b/library/ssl_tls13_generic.c
@@ -551,32 +551,39 @@
 static int ssl_tls13_validate_certificate( mbedtls_ssl_context *ssl )
 {
     int ret = 0;
-    int authmode = ssl->conf->authmode;
+    int authmode = MBEDTLS_SSL_VERIFY_REQUIRED;
     mbedtls_x509_crt *ca_chain;
     mbedtls_x509_crl *ca_crl;
     uint32_t verify_result = 0;
 
     /* If SNI was used, overwrite authentication mode
      * from the configuration. */
+#if defined(MBEDTLS_SSL_SRV_C)
+    if( ssl->conf->endpoint == MBEDTLS_SSL_IS_SERVER )
+    {
 #if defined(MBEDTLS_SSL_SERVER_NAME_INDICATION)
-    if( ssl->handshake->sni_authmode != MBEDTLS_SSL_VERIFY_UNSET )
-        authmode = ssl->handshake->sni_authmode;
+        if( ssl->handshake->sni_authmode != MBEDTLS_SSL_VERIFY_UNSET )
+            authmode = ssl->handshake->sni_authmode;
+        else
+#endif
+            authmode = ssl->conf->authmode;
+    }
 #endif
 
     /*
-     * If the client hasn't sent a certificate ( i.e. it sent
+     * If the peer hasn't sent a certificate ( i.e. it sent
      * an empty certificate chain ), this is reflected in the peer CRT
      * structure being unset.
      * Check for that and handle it depending on the
-     * server's authentication mode.
+     * authentication mode.
      */
     if( ssl->session_negotiate->peer_cert == NULL )
     {
+        MBEDTLS_SSL_DEBUG_MSG( 1, ( "peer has not sent a certificate" ) );
+
 #if defined(MBEDTLS_SSL_SRV_C)
         if( ssl->conf->endpoint == MBEDTLS_SSL_IS_SERVER )
         {
-            MBEDTLS_SSL_DEBUG_MSG( 1, ( "client has no certificate" ) );
-
             /* The client was asked for a certificate but didn't send
              * one. The client should know what's going on, so we
              * don't send an alert.
@@ -585,7 +592,11 @@
             if( authmode == MBEDTLS_SSL_VERIFY_OPTIONAL )
                 return( 0 );
             else
-                return( MBEDTLS_ERR_SSL_NO_CLIENT_CERTIFICATE );
+            {
+                MBEDTLS_SSL_PEND_FATAL_ALERT( MBEDTLS_SSL_ALERT_MSG_NO_CERT,
+                                              MBEDTLS_ERR_SSL_FATAL_ALERT_MESSAGE );
+                return( MBEDTLS_ERR_SSL_FATAL_ALERT_MESSAGE );
+            }
         }
 #endif /* MBEDTLS_SSL_SRV_C */
 
@@ -654,7 +665,6 @@
         ret = 0;
     }
 
-
     if( ca_chain == NULL && authmode == MBEDTLS_SSL_VERIFY_REQUIRED )
     {
         MBEDTLS_SSL_DEBUG_MSG( 1, ( "got no CA chain" ) );

library/ssl_tls13_server.c

diff --git a/library/ssl_tls13_server.c b/library/ssl_tls13_server.c
index 43018d0..e45db76 100644
--- a/library/ssl_tls13_server.c
+++ b/library/ssl_tls13_server.c
@@ -1626,7 +1626,7 @@
 
         case MBEDTLS_SSL_CLIENT_CERTIFICATE:
             ret = mbedtls_ssl_tls13_process_certificate( ssl );
-            if( ret == 0 && ssl->session_negotiate->peer_cert != NULL)
+            if( ret == 0 && ssl->session_negotiate->peer_cert != NULL )
             {
                 mbedtls_ssl_handshake_set_state(
                     ssl, MBEDTLS_SSL_CLIENT_CERTIFICATE_VERIFY );