commit 6458e3b743ec7c15fad483d1b643709627a4bb2b
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Thu Jan 08 14:16:56 2015 +0100
committer Manuel Pégourié-Gonnard <mpg@elzevir.fr> Thu Jan 08 14:16:56 2015 +0100
tree 89d1cb90472bb53516fa5e4a988a62fddc04f01c
parent 846ba473af0af5cc4aafdc23ed1862a9d1df4da3

Some more refactoring/tuning.

library/ssl_srv.c

diff --git a/library/ssl_srv.c b/library/ssl_srv.c
index a385c89..211ab5d 100644
--- a/library/ssl_srv.c
+++ b/library/ssl_srv.c
@@ -749,11 +749,11 @@
 
 #if defined(POLARSSL_X509_CRT_PARSE_C)
 /*
- * Return 1 if the given EC key uses the given curve, 0 otherwise
+ * Return 0 if the given key uses one of the acceptable curves, -1 otherwise
  */
 #if defined(POLARSSL_ECDSA_C)
-static int ssl_key_matches_curves( pk_context *pk,
-                                   const ecp_curve_info **curves )
+static int ssl_check_key_curve( pk_context *pk,
+                                const ecp_curve_info **curves )
 {
     const ecp_curve_info **crv = curves;
     ecp_group_id grp_id = pk_ec( *pk )->grp.id;
@@ -761,11 +761,11 @@
     while( *crv != NULL )
     {
         if( (*crv)->grp_id == grp_id )
-            return( 1 );
+            return( 0 );
         crv++;
     }
 
-    return( 0 );
+    return( -1 );
 }
 #endif /* POLARSSL_ECDSA_C */
 
@@ -810,7 +810,7 @@
 
 #if defined(POLARSSL_ECDSA_C)
         if( pk_alg == POLARSSL_PK_ECDSA &&
-            ! ssl_key_matches_curves( cur->key, ssl->handshake->curves ) )
+            ssl_check_key_curve( cur->key, ssl->handshake->curves ) != 0 )
             continue;
 #endif
 
@@ -838,8 +838,8 @@
     suite_info = ssl_ciphersuite_from_id( suite_id );
     if( suite_info == NULL )
     {
-        SSL_DEBUG_MSG( 1, ( "ciphersuite info for %04x not found", suite_id ) );
-        return( POLARSSL_ERR_SSL_BAD_INPUT_DATA );
+        SSL_DEBUG_MSG( 1, ( "should never happen" ) );
+        return( POLARSSL_ERR_SSL_INTERNAL_ERROR );
     }
 
     if( suite_info->min_minor_ver > ssl->minor_ver ||