commit 62d22f9782dd68876353feb23889210ebb9a7efc
author Mateusz Starzyk <mateusz.starzyk@mobica.com> Mon Aug 09 15:53:41 2021 +0200
committer Mateusz Starzyk <mateusz.starzyk@mobica.com> Tue Aug 10 14:00:14 2021 +0200
tree 10ce1ce52266aab7d56ff27d10cbe9dae4e82514
parent 4f2dd8aada0f75717db1ff9c0139de71f93a0321

Use additional state in CCM to track auth data input.

Signed-off-by: Mateusz Starzyk <mateusz.starzyk@mobica.com>

library/ccm.c

diff --git a/library/ccm.c b/library/ccm.c
index 33c631a..7574bdc 100644
--- a/library/ccm.c
+++ b/library/ccm.c
@@ -100,7 +100,8 @@
 #define CCM_STATE__CLEAR                0
 #define CCM_STATE__STARTED              (1 << 0)
 #define CCM_STATE__LENGHTS_SET          (1 << 1)
-#define CCM_STATE__AUTH_DATA_FINISHED   (1 << 2)
+#define CCM_STATE__AUTH_DATA_STARTED    (1 << 2)
+#define CCM_STATE__AUTH_DATA_FINISHED   (1 << 3)
 #define CCM_STATE__ERROR                (1 << 4)
 
 /*
@@ -272,7 +273,7 @@
             return MBEDTLS_ERR_CCM_BAD_SEQUENCE;
         }
 
-        if( ctx->processed == 0 )
+        if( !(ctx->state & CCM_STATE__AUTH_DATA_STARTED) )
         {
             if ( add_len > ctx->add_len )
             {
@@ -282,17 +283,17 @@
             ctx->y[0] ^= (unsigned char)( ( ctx->add_len >> 8 ) & 0xFF );
             ctx->y[1] ^= (unsigned char)( ( ctx->add_len      ) & 0xFF );
 
-            ctx->processed += 2;
+            ctx->state |= CCM_STATE__AUTH_DATA_STARTED;
         }
-        else if ( ctx->processed - 2 + add_len > ctx->add_len )
+        else if ( ctx->processed + add_len > ctx->add_len )
         {
             return MBEDTLS_ERR_CCM_BAD_INPUT;
         }
 
         while( add_len > 0 )
         {
-            offset = ctx->processed % 16;
-
+            offset = (ctx->processed + 2) % 16; /* account for y[0] and y[1]
+                                                 * holding total auth data length */
             use_len = 16 - offset;
 
             if( use_len > add_len )
@@ -305,7 +306,7 @@
             add_len -= use_len;
             add += use_len;
 
-            if( use_len + offset == 16 || ctx->processed - 2 == ctx->add_len )
+            if( use_len + offset == 16 || ctx->processed == ctx->add_len )
             {
                 if( ( ret = mbedtls_cipher_update( &ctx->cipher_ctx, ctx->y, 16, ctx->y, &olen ) ) != 0 )
                 {
@@ -315,7 +316,7 @@
             }
         }
 
-        if( ctx->processed - 2 == ctx->add_len )
+        if( ctx->processed == ctx->add_len )
         {
             ctx->state |= CCM_STATE__AUTH_DATA_FINISHED;
             ctx->processed = 0; // prepare for mbedtls_ccm_update()