commit 0184b3c69b8bd1891ff6b2cf711b5ddf63254eef
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Wed Oct 31 10:36:51 2018 +0100
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Nov 22 09:59:34 2018 +0100
tree c4f82147e6da62c9f00086ead0f6a793b9bc1587
parent 01a12c49aa057c83383ac2fc1dd32489672089c2

Add support for get_(bit)len on opaque keys

library/pk_wrap.c

diff --git a/library/pk_wrap.c b/library/pk_wrap.c
index 0e12d05..75a49a1 100644
--- a/library/pk_wrap.c
+++ b/library/pk_wrap.c
@@ -733,10 +733,21 @@
     mbedtls_free( ctx );
 }
 
+static size_t pk_psa_get_bitlen( const void *ctx )
+{
+    const psa_key_slot_t *key = (const psa_key_slot_t *) ctx;
+    size_t bits;
+
+    if( PSA_SUCCESS != psa_get_key_information( *key, NULL, &bits ) )
+        return( 0 );
+
+    return( bits );
+}
+
 const mbedtls_pk_info_t mbedtls_pk_opaque_psa_info = {
     MBEDTLS_PK_OPAQUE_PSA,
     "Opaque (PSA)",
-    NULL, /* coming soon: bitlen */
+    pk_psa_get_bitlen,
     NULL, /* coming soon: can_do */
     NULL, /* verify - will be done later */
     NULL, /* coming soon: sign */

tests/suites/test_suite_pk.function

diff --git a/tests/suites/test_suite_pk.function b/tests/suites/test_suite_pk.function
index 64f1fec..8f6abf5 100644
--- a/tests/suites/test_suite_pk.function
+++ b/tests/suites/test_suite_pk.function
@@ -101,9 +101,11 @@
 void pk_psa_utils(  )
 {
     mbedtls_pk_context pk;
-    const char * const name = "Opaque (PSA)";
     psa_key_slot_t key;
 
+    const char * const name = "Opaque (PSA)";
+    const size_t bitlen = 256; /* harcoded in genkey() */
+
     mbedtls_pk_init( &pk );
 
     key = pk_psa_genkey();
@@ -114,6 +116,9 @@
     TEST_ASSERT( mbedtls_pk_get_type( &pk ) == MBEDTLS_PK_OPAQUE_PSA );
     TEST_ASSERT( strcmp( mbedtls_pk_get_name( &pk), name ) == 0 );
 
+    TEST_ASSERT( mbedtls_pk_get_bitlen( &pk ) == bitlen );
+    TEST_ASSERT( mbedtls_pk_get_len( &pk ) == bitlen / 8 );
+
     /* test that freeing the context does not destroy the key */
     mbedtls_pk_free( &pk );
     TEST_ASSERT( PSA_SUCCESS == psa_destroy_key( key ) );