commit 3ecd5a4f19fd9a497490a91aaa96e76a5edadd2c
author Max Reitz <mreitz@redhat.com> Mon Nov 19 11:19:21 2018 +0100
committer Kevin Wolf <kwolf@redhat.com> Wed Nov 21 15:17:46 2018 +0100
tree f5128a58b6e0167192ed17269ac55255f0862fe0
parent f0998879e049dad19beed881a1c56643ce536384

qemu-img: Fix leak

create_opts was leaked here.  This is not too bad since the process is
about to exit anyway, but relying on that does not make the code nicer
to read.

Fixes: d402b6a21a825a5c07aac9251990860723d49f5d
Reported-by: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

qemu-img.c

diff --git a/qemu-img.c b/qemu-img.c
index a9a2470..ad04f59 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -263,6 +263,7 @@
         if (!proto_drv->create_opts) {
             error_report("Protocol driver '%s' does not support image creation",
                          proto_drv->format_name);
+            qemu_opts_free(create_opts);
             return 1;
         }
         create_opts = qemu_opts_append(create_opts, proto_drv->create_opts);