VtsTrebleVintfTest: Remove HalEntriesAreComplete
The test is obsolete:
- It is testing implementation detail of how manifests work
- It is using deprecated and private APIs of libvintf
Test: run the test
Bug: 74247301
Change-Id: Ife1e778a45e9a04212324df0e50f09302938dd8e
Merged-In: Ife1e778a45e9a04212324df0e50f09302938dd8e
diff --git a/treble/vintf/SingleManifestTest.cpp b/treble/vintf/SingleManifestTest.cpp
index c7feff7..f20bad9 100644
--- a/treble/vintf/SingleManifestTest.cpp
+++ b/treble/vintf/SingleManifestTest.cpp
@@ -29,27 +29,6 @@
using android::FqInstance;
using android::vintf::toFQNameString;
-// Tests that all HAL entries in VINTF has all required fields filled out.
-TEST_P(SingleManifestTest, HalEntriesAreComplete) {
- auto manifest = GetParam();
- for (const auto &hal_name : manifest->getHalNames()) {
- for (const ManifestHal *hal : manifest->getHals(hal_name)) {
- // Do not suggest <fqname> for target FCM version < P.
- bool allow_fqname = manifest->level() != Level::UNSPECIFIED &&
- manifest->level() >= 3 /* P */;
-
- EXPECT_TRUE(hal->isOverride() || !hal->isDisabledHal())
- << hal->getName()
- << " has no instances declared and does not have override=\"true\". "
- << "Do one of the following to fix: \n"
- << (allow_fqname ? " * Add <fqname> tags.\n" : "")
- << " * Add <version>, <interface> and <instance> tags.\n"
- << " * If the component should be disabled, add attribute "
- << "override=\"true\".";
- }
- }
-}
-
// Tests that no HAL outside of the allowed set is specified as passthrough in
// VINTF.
TEST_P(SingleManifestTest, HalsAreBinderized) {
diff --git a/treble/vintf/vts_treble_vintf_test_o_mr1.cpp b/treble/vintf/vts_treble_vintf_test_o_mr1.cpp
index 8ac4e80..4ee7dd6 100644
--- a/treble/vintf/vts_treble_vintf_test_o_mr1.cpp
+++ b/treble/vintf/vts_treble_vintf_test_o_mr1.cpp
@@ -137,17 +137,6 @@
transport);
}
-// Tests that all HAL entries in VINTF has all required fields filled out.
-TEST_F(VtsTrebleVintfTest, HalEntriesAreComplete) {
- for (const auto &hal_name : vendor_manifest_->getHalNames()) {
- for (const ManifestHal *hal : vendor_manifest_->getHals(hal_name)) {
- EXPECT_TRUE(!hal->isDisabledHal())
- << hal->getName() << " has no instances declared. Suggested fix: "
- << "Add <version>, <interface> and <instance> tags.\n";
- }
- }
-}
-
// Tests that no HAL outside of the allowed set is specified as passthrough in
// VINTF.
TEST_F(VtsTrebleVintfTest, HalsAreBinderized) {
