commit 7b8f2db4b07deaaa2f6f5ffbee0386a394032b08
author San Mehat <san@google.com> Mon Jan 04 14:03:36 2010 -0800
committer San Mehat <san@google.com> Mon Jan 04 14:03:36 2010 -0800
tree bc1d948d06dc1d485e6b916c57b0c1706d627931
parent bf04185c88161f13118b9975cdff7967d49a4fa0

vold2: Don't crap out if the kernel is missing the NPART/PARTN blkdev uevent patches

Signed-off-by: San Mehat <san@google.com>

DirectVolume.cpp

diff --git a/DirectVolume.cpp b/DirectVolume.cpp
index 1fda955..68a6fcd 100644
--- a/DirectVolume.cpp
+++ b/DirectVolume.cpp
@@ -126,7 +126,15 @@
 void DirectVolume::handleDiskAdded(const char *devpath, NetlinkEvent *evt) {
     mDiskMajor = atoi(evt->findParam("MAJOR"));
     mDiskMinor = atoi(evt->findParam("MINOR"));
-    mDiskNumParts = atoi(evt->findParam("NPARTS"));
+
+    const char *tmp = evt->findParam("NPARTS");
+    if (tmp) {
+        mDiskNumParts = atoi(tmp);
+    } else {
+        LOGW("Kernel block uevent missing 'NPARTS'");
+        mDiskNumParts = 1;
+    }
+
     char msg[255];
 
     int partmask = 0;
@@ -158,7 +166,17 @@
 void DirectVolume::handlePartitionAdded(const char *devpath, NetlinkEvent *evt) {
     int major = atoi(evt->findParam("MAJOR"));
     int minor = atoi(evt->findParam("MINOR"));
-    int part_num = atoi(evt->findParam("PARTN"));
+
+    int part_num;
+
+    const char *tmp = evt->findParam("PARTN");
+
+    if (tmp) {
+        part_num = atoi(tmp);
+    } else {
+        LOGW("Kernel block uevent missing 'PARTN'");
+        part_num = 1;
+    }
 
     if (major != mDiskMajor) {
         LOGE("Partition '%s' has a different major than its disk!", devpath);
@@ -191,7 +209,14 @@
     }
 
     LOGI("Volume %s disk has changed", getLabel());
-    mDiskNumParts = atoi(evt->findParam("NPARTS"));
+    const char *tmp = evt->findParam("NPARTS");
+    if (tmp) {
+        mDiskNumParts = atoi(tmp);
+    } else {
+        LOGW("Kernel block uevent missing 'NPARTS'");
+        mDiskNumParts = 1;
+    }
+
     int partmask = 0;
     int i;
     for (i = 1; i <= mDiskNumParts; i++) {
@@ -226,7 +251,6 @@
 void DirectVolume::handlePartitionRemoved(const char *devpath, NetlinkEvent *evt) {
     int major = atoi(evt->findParam("MAJOR"));
     int minor = atoi(evt->findParam("MINOR"));
-    int part_num = atoi(evt->findParam("PARTN"));
     char msg[255];
 
     LOGD("Volume %s %s partition %d:%d removed\n", getLabel(), getMountpoint(), major, minor);