commit 2376e6754044b5c6e66413e010db61756fd7a073
author David Srbecky <dsrbecky@google.com> Thu Feb 01 14:49:14 2018 +0000
committer David Srbecky <dsrbecky@google.com> Thu Feb 01 14:51:57 2018 +0000
tree c5265cd3786d92df887cf9dc9c589193fcfa77dd
parent 109700494cd2e62472851d7714f6dfd50e1e7ee3

Fix symbol resolution within a dex file.

Fixes the ART 137-cfi test, currently failing on buildbot.

Test: testrunner.py -j40 --host --cdex-none -t 137 -b
Change-Id: I16a007b291702207bbd003fd1e78e8e5ced7cd68

libunwindstack/DexFiles.cpp

diff --git a/libunwindstack/DexFiles.cpp b/libunwindstack/DexFiles.cpp
index 3d67a6a..fe6d3c6 100644
--- a/libunwindstack/DexFiles.cpp
+++ b/libunwindstack/DexFiles.cpp
@@ -52,9 +52,9 @@
   return dex_file;
 }
 
-void DexFiles::GetMethodInformation(uint64_t dex_offset, MapInfo* info, std::string* method_name,
-                                    uint64_t* method_offset) {
-  DexFile* dex_file = GetDexFile(dex_offset, info);
+void DexFiles::GetMethodInformation(uint64_t dex_file_offset, uint64_t dex_offset, MapInfo* info,
+                                    std::string* method_name, uint64_t* method_offset) {
+  DexFile* dex_file = GetDexFile(dex_file_offset, info);
   if (dex_file != nullptr) {
     dex_file->GetMethodInformation(dex_offset, method_name, method_offset);
   }

libunwindstack/Unwinder.cpp

diff --git a/libunwindstack/Unwinder.cpp b/libunwindstack/Unwinder.cpp
index d22e1e8..db8278e 100644
--- a/libunwindstack/Unwinder.cpp
+++ b/libunwindstack/Unwinder.cpp
@@ -95,7 +95,8 @@
   }
 
 #if !defined(NO_LIBDEXFILE_SUPPORT)
-  dex_files_->GetMethodInformation(dex_offset, info, &frame->function_name, &frame->function_offset);
+  dex_files_->GetMethodInformation(dex_pc - dex_offset, dex_offset, info, &frame->function_name,
+                                   &frame->function_offset);
 #endif
 }
 

libunwindstack/include/unwindstack/DexFiles.h

diff --git a/libunwindstack/include/unwindstack/DexFiles.h b/libunwindstack/include/unwindstack/DexFiles.h
index d80e9b7..50c9c32 100644
--- a/libunwindstack/include/unwindstack/DexFiles.h
+++ b/libunwindstack/include/unwindstack/DexFiles.h
@@ -38,10 +38,10 @@
   explicit DexFiles(std::shared_ptr<Memory>& memory);
   ~DexFiles();
 
-  DexFile* GetDexFile(uint64_t dex_offset, MapInfo* info);
+  DexFile* GetDexFile(uint64_t dex_file_offset, MapInfo* info);
 
-  void GetMethodInformation(uint64_t dex_offset, MapInfo* info, std::string* method_name,
-                            uint64_t* method_offset);
+  void GetMethodInformation(uint64_t dex_file_offset, uint64_t dex_offset, MapInfo* info,
+                            std::string* method_name, uint64_t* method_offset);
 
   void SetArch(ArchEnum arch);