commit 005757b900c6bf0b8b9af9b578ba515a8bfed368
author Steven Moreland <smoreland@google.com> Wed Dec 26 16:56:03 2018 -0800
committer Steven Moreland <smoreland@google.com> Wed Dec 26 16:56:03 2018 -0800
tree 019a7fb277c5302c440764bde3198c2b5b5baf9a
parent a99f99e3516eb5ace710033e0683986b152c09c0

performance-unnecessary-value-param where possible

*-adapter libraries don't have ABI requirements, so they can be changed

Fixes: 121200893
Test: make with:
 WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,performance-unnecessary-value-param

Change-Id: Ia238907101ba53d101d9e642c34abe67697100ad

Android.bp

diff --git a/Android.bp b/Android.bp
index 95e21bb..5e3566f 100644
--- a/Android.bp
+++ b/Android.bp
@@ -34,8 +34,8 @@
         "-Werror",
         "-Wextra-semi",
     ],
-    // b/121200893, hidl generated *All.cpp files use value parameters
     tidy_checks: [
+        // _hidl_cb and addOnewayTask are stuck because of the legacy ABI
         "-performance-unnecessary-value-param",
     ],
     product_variables: {

generateCppAdapter.cpp

diff --git a/generateCppAdapter.cpp b/generateCppAdapter.cpp
index a83e9f3..1d88d3c 100644
--- a/generateCppAdapter.cpp
+++ b/generateCppAdapter.cpp
@@ -54,7 +54,7 @@
             out << "public:\n";
             out << "typedef " << mockName << " Pure;\n";
 
-            out << klassName << "(::android::sp<" << mockName << "> impl);\n";
+            out << klassName << "(const ::android::sp<" << mockName << ">& impl);\n";
 
             generateMethods(out, [&](const Method* method, const Interface* /* interface */) {
                 if (method->isHidlReserved()) {
@@ -103,8 +103,8 @@
 
         const std::string mockName = getInterface()->fqName().cppName();
 
-        out << klassName << "::" << klassName << "(::android::sp<" << mockName
-            << "> impl) : mImpl(impl) {}";
+        out << klassName << "::" << klassName << "(const ::android::sp<" << mockName
+            << ">& impl) : mImpl(impl) {}";
 
         generateMethods(out, [&](const Method* method, const Interface* /* interface */) {
             generateAdapterMethod(out, method);