Google Git
Sign in
android / platform / system / tools / hidl / 3f2df67255fe2c99f076480c2c6c2ab3b13e6428
commit3f2df67255fe2c99f076480c2c6c2ab3b13e6428[log] [tgz]
authorYifan Hong <elsk@google.com>Wed Mar 15 11:00:28 2017 -0700
committergitbuildkicker <android-build@google.com>Thu Mar 16 18:18:37 2017 -0700
tree3e74b4944578a0a86bc9121573aaec85ec4d999b
parentcef70f2a3160d8463dc9ed6b0fb512203561c676 [diff]
getService should retry if getting nullptr

for transport == hwbinder / toggled only. If a service is dead but
hwservicemanager has not receive the death notification yet,
getService retrieved the service, called interfaceChain() into
it, failed, and returned nullptr.

With this change, getService retries until it gets an alive service
from hwservicemanager.

For transport == passthrough, the logic is not touched.

Refactored getService so that the code is easier to read.

Bug: 36153684
Test: killing system_server on the phone, logging shows that
      getService actually retries, and audio still works
      without the workaround.

Change-Id: Ib380d3f6665d7b3ff0cfb77c16f5b09f20003c00
(cherry picked from commit 64ba3d79879ac8bb406f29ef1a7a52a67d2b8f65)
3 files changed
tree: 3e74b4944578a0a86bc9121573aaec85ec4d999b
  1. c2hal/
  2. test/
  3. utils/
  4. Android.bp
  5. Annotation.cpp
  6. Annotation.h
  7. ArrayType.cpp
  8. ArrayType.h
  9. AST.cpp
  10. AST.h
  11. CompoundType.cpp
  12. CompoundType.h
  13. ConstantExpression.cpp
  14. ConstantExpression.h
  15. Coordinator.cpp
  16. Coordinator.h
  17. DeathRecipientType.cpp
  18. DeathRecipientType.h
  19. EnumType.cpp
  20. EnumType.h
  21. FmqType.cpp
  22. FmqType.h
  23. generateCpp.cpp
  24. generateCppImpl.cpp
  25. generateJava.cpp
  26. generateVts.cpp
  27. HandleType.cpp
  28. HandleType.h
  29. hidl-gen_l.ll
  30. hidl-gen_y.yy
  31. Interface.cpp
  32. Interface.h
  33. Location.h
  34. main.cpp
  35. MemoryType.cpp
  36. MemoryType.h
  37. Method.cpp
  38. Method.h
  39. MODULE_LICENSE_APACHE2
  40. NamedType.cpp
  41. NamedType.h
  42. NOTICE
  43. PointerType.cpp
  44. PointerType.h
  45. README.md
  46. RefType.cpp
  47. RefType.h
  48. ScalarType.cpp
  49. ScalarType.h
  50. Scope.cpp
  51. Scope.h
  52. StringType.cpp
  53. StringType.h
  54. Type.cpp
  55. Type.h
  56. TypeDef.cpp
  57. TypeDef.h
  58. VectorType.cpp
  59. VectorType.h
README.md

hidl-gen user guide

1. Build

croot
make hidl-gen

2. Run

hidl-gen -o output-path -L language (-r interface-root) fqname

output-path: directory to store the output files.
language: output file for given language. e.g.c++, vts..

fqname: fully qualified name of the input files.
For singe file input, follow the format: package@version::fileName
For directory input, follow the format: package@version

interface-root(optional): prefix and root path for fqname.
If not set, use the default prefix: android.hardware and default root path
defined in $TOP.

examples:

croot
hidl-gen -o output -L c++ -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0::INfc.hal
hidl-gen -o output -L vts -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0
hidl-gen -o test -L c++ -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0