tree 3e74b4944578a0a86bc9121573aaec85ec4d999b
parent cef70f2a3160d8463dc9ed6b0fb512203561c676
author Yifan Hong <elsk@google.com> 1489600828 -0700
committer gitbuildkicker <android-build@google.com> 1489713517 -0700

getService should retry if getting nullptr

for transport == hwbinder / toggled only. If a service is dead but
hwservicemanager has not receive the death notification yet,
getService retrieved the service, called interfaceChain() into
it, failed, and returned nullptr.

With this change, getService retries until it gets an alive service
from hwservicemanager.

For transport == passthrough, the logic is not touched.

Refactored getService so that the code is easier to read.

Bug: 36153684
Test: killing system_server on the phone, logging shows that
      getService actually retries, and audio still works
      without the workaround.

Change-Id: Ib380d3f6665d7b3ff0cfb77c16f5b09f20003c00
(cherry picked from commit 64ba3d79879ac8bb406f29ef1a7a52a67d2b8f65)