commit 8533bd0667b3fc5c7de26fe01752ac6b773662c7
author Jiyong Park <jiyong@google.com> Mon Oct 29 21:31:18 2018 +0900
committer Jiyong Park <jiyong@google.com> Tue Nov 06 07:08:36 2018 +0900
tree 8104316292840a4e2bb1b49c9c191ace80a9de09
parent b064cbb97c13488633bb29eb8b1752a008c2ea05

Don't use default arguments on virtual or override methods

The generated code does not make use of default arguments on virtual
methods onTransact().

Test: WITH_TIDY=true WITH_TIDY_CHECKS=google-default-arguments m
libaidl-integration-test
Change-Id: Iebc0b5c771d44422d7c4f761418d29f20a43412b

generate_cpp.cpp

diff --git a/generate_cpp.cpp b/generate_cpp.cpp
index e8c137e..0a92ae8 100644
--- a/generate_cpp.cpp
+++ b/generate_cpp.cpp
@@ -914,7 +914,7 @@
                StringPrintf("const %s& %s", kAndroidParcelLiteral,
                             kDataVarName),
                StringPrintf("%s* %s", kAndroidParcelLiteral, kReplyVarName),
-               StringPrintf("uint32_t %s = 0", kFlagsVarName)}},
+               StringPrintf("uint32_t %s", kFlagsVarName)}},
       MethodDecl::IS_OVERRIDE
   }};
 

generate_cpp_unittest.cpp

diff --git a/generate_cpp_unittest.cpp b/generate_cpp_unittest.cpp
index 39f20d1..65c9824 100644
--- a/generate_cpp_unittest.cpp
+++ b/generate_cpp_unittest.cpp
@@ -739,7 +739,7 @@
 
 class BnComplexTypeInterface : public ::android::BnInterface<IComplexTypeInterface> {
 public:
-  ::android::status_t onTransact(uint32_t _aidl_code, const ::android::Parcel& _aidl_data, ::android::Parcel* _aidl_reply, uint32_t _aidl_flags = 0) override;
+  ::android::status_t onTransact(uint32_t _aidl_code, const ::android::Parcel& _aidl_data, ::android::Parcel* _aidl_reply, uint32_t _aidl_flags) override;
 };  // class BnComplexTypeInterface
 
 }  // namespace os

tests/test_data_ping_responder.cpp

diff --git a/tests/test_data_ping_responder.cpp b/tests/test_data_ping_responder.cpp
index f6fb2d6..aaad80b 100644
--- a/tests/test_data_ping_responder.cpp
+++ b/tests/test_data_ping_responder.cpp
@@ -488,7 +488,7 @@
 
 class BnPingResponder : public ::android::BnInterface<IPingResponder> {
 public:
-  ::android::status_t onTransact(uint32_t _aidl_code, const ::android::Parcel& _aidl_data, ::android::Parcel* _aidl_reply, uint32_t _aidl_flags = 0) override;
+  ::android::status_t onTransact(uint32_t _aidl_code, const ::android::Parcel& _aidl_data, ::android::Parcel* _aidl_reply, uint32_t _aidl_flags) override;
 };  // class BnPingResponder
 
 }  // namespace os
@@ -941,7 +941,7 @@
 
 class BnPingResponder : public ::android::BnInterface<IPingResponder> {
 public:
-  ::android::status_t onTransact(uint32_t _aidl_code, const ::android::Parcel& _aidl_data, ::android::Parcel* _aidl_reply, uint32_t _aidl_flags = 0) override;
+  ::android::status_t onTransact(uint32_t _aidl_code, const ::android::Parcel& _aidl_data, ::android::Parcel* _aidl_reply, uint32_t _aidl_flags) override;
 };  // class BnPingResponder
 
 }  // namespace os