commit f8feed620bd607427ded702cce91bb0eb749bc6a
author nagendra modadugu <ngm@google.com> Mon Sep 24 13:40:23 2018 -0700
committer nagendra modadugu <ngm@google.com> Tue Oct 02 16:16:53 2018 -0700
tree 44699ce64d63fea47e62641469116d3705d0603b
parent 926f647663d589f7b16887ecd10162b64736e521

keystore: abort if verification token generation fails

Fix a corner case of operation leakage: if verification
token generation fails, then abort the corresponding
operation on citadel.

Bug: 116055338
Test: pending
Change-Id: I5163fa43fcff505deef5555318148178118ff41e

keystore/key_store_service.cpp

diff --git a/keystore/key_store_service.cpp b/keystore/key_store_service.cpp
index c831085..81189ae 100644
--- a/keystore/key_store_service.cpp
+++ b/keystore/key_store_service.cpp
@@ -1371,7 +1371,14 @@
                                                             }));
 
         if (!rc.isOk()) result->resultCode = rc;
-        if (!result->resultCode.isOk()) return Status::ok();
+        if (!result->resultCode.isOk()) {
+            LOG(ERROR) << "Failed to verify authorization " << rc << " from begin()";
+            rc = KS_HANDLE_HIDL_ERROR(dev->abort(result->handle));
+            if (!rc.isOk()) {
+                LOG(ERROR) << "Failed to abort operation " << rc << " from begin()";
+            }
+            return Status::ok();
+        }
     }
 
     // Note: The operation map takes possession of the contents of "characteristics".
@@ -1462,7 +1469,12 @@
 
     // just a reminder: on success result->resultCode was set in the callback. So we only overwrite
     // it if there was a communication error indicated by the ErrorCode.
-    if (!rc.isOk()) result->resultCode = rc;
+    if (!rc.isOk()) {
+        result->resultCode = rc;
+        // removeOperation() will free the memory 'op' used, so the order is important
+        mAuthTokenTable.MarkCompleted(op.handle);
+        mOperationMap.removeOperation(token, /* wasOpSuccessful */ false);
+    }
 
     return Status::ok();
 }