commit e92ecd95daf692f49877b98f2f9b145ee0f6034a
author Martijn Coenen <maco@google.com> Thu May 27 12:31:54 2021 +0200
committer Martijn Coenen <maco@google.com> Mon May 31 07:04:10 2021 +0000
tree 40b1b90f459df533b51480145e86da3538c38dc1
parent 5860484ad09fe52be2d218b65c3510e8ed7b0257

On-device signing: Don't specify MAC_LENGTH on verify operation.

This parameter is rejected on some implementations.

Bug: 188121857
Test: TEST_MAPPING
Change-Id: Ic41dddc57dbb2e56d22ed79a54515d9467dcfde2
Merged-In: Ic41dddc57dbb2e56d22ed79a54515d9467dcfde2

ondevice-signing/KeystoreHmacKey.cpp

diff --git a/ondevice-signing/KeystoreHmacKey.cpp b/ondevice-signing/KeystoreHmacKey.cpp
index db8d7d9..a2208ce 100644
--- a/ondevice-signing/KeystoreHmacKey.cpp
+++ b/ondevice-signing/KeystoreHmacKey.cpp
@@ -169,11 +169,6 @@
     digest.value = KeyParameterValue::make<KeyParameterValue::digest>(Digest::SHA_2_256);
     opParameters.push_back(digest);
 
-    KeyParameter mac_length;
-    mac_length.tag = Tag::MAC_LENGTH;
-    mac_length.value = KeyParameterValue::make<KeyParameterValue::integer>(256);
-    opParameters.push_back(mac_length);
-
     KeyParameter purpose;
     purpose.tag = Tag::PURPOSE;
     purpose.value = KeyParameterValue::make<KeyParameterValue::keyPurpose>(KeyPurpose::VERIFY);