commit 1bdb61e5fac17af531c7f2755b29a6540901d38a
author Yi Kong <yikong@google.com> Fri Jun 19 14:00:40 2020 +0800
committer Yi Kong <yikong@google.com> Fri Jun 19 18:27:11 2020 +0000
tree 2294b41ad9dc7da630b7b26daa790ca71bde6e5b
parent e3421680c88cb9af44e4f63e1230069301ff3ad9

Fix incorrect use of TEMP_FAILURE_RETRY

TEMP_FAILURE_RETRY expects an argument that returns -1 on temporary
failure, not a boolean.

Test: TreeHugger
Change-Id: If8cb4a440e909c4ed7cbfdd34454670b0d5ee045
Exempt-From-Owner-Approval: Janitorial fix

identity/Util.cpp

diff --git a/identity/Util.cpp b/identity/Util.cpp
index a962dc3..cd29017 100644
--- a/identity/Util.cpp
+++ b/identity/Util.cpp
@@ -110,7 +110,7 @@
         remaining -= numWritten;
     }
 
-    if (TEMP_FAILURE_RETRY(fsync(fd) == -1)) {
+    if (TEMP_FAILURE_RETRY(fsync(fd))) {
         PLOG(ERROR) << "Failed fsyncing temp file for '" << path << "'";
         close(fd);
         return false;