commit 8080621a4bf97239ca175780431c0a2f3423b0e4
author Bernie Innocenti <codewiz@google.com> Wed Oct 10 22:45:11 2018 +0900
committer Bernie Innocenti <codewiz@google.com> Fri Oct 12 14:38:03 2018 +0900
tree dbe2fb30de374dc8f61760e0cb2971b93cf4ef42
parent 8bb94bad47592bbe351c9f6981e9f5b3931f34b6

Fix another range-for loop with an implicit copy.

Also employ the awesome C++17 structured binding feature to unpack the pair.

Test: atest netd_unit_test
Change-Id: Ie7a0d9643c81a702d06557b9352d4d11b01c71d2

server/NFLogListener.cpp

diff --git a/server/NFLogListener.cpp b/server/NFLogListener.cpp
index f13fcf7..e1615ff 100644
--- a/server/NFLogListener.cpp
+++ b/server/NFLogListener.cpp
@@ -169,8 +169,8 @@
     expectOk(mListener->unsubscribe(kNFLogPacketMsgType));
     expectOk(mListener->unsubscribe(kNetlinkDoneMsgType));
     const auto sendFn = [this](const Slice msg) { return mListener->send(msg); };
-    for (auto pair : mDispatchMap) {
-        expectOk(cfgCmdUnbind(sendFn, pair.first));
+    for (const auto& [key, value] : mDispatchMap) {
+        expectOk(cfgCmdUnbind(sendFn, key));
     }
 }