commit 89ea04969a8ddec12c0616cd4b5895dd10c85d2d
author Steven Moreland <smoreland@google.com> Thu Apr 16 16:22:52 2020 -0700
committer Steven Moreland <smoreland@google.com> Fri Apr 17 01:11:20 2020 +0000
tree 694b17dc79504e9ef2874ffd528c07c113c1fd48
parent 889cf78f80f1035c58513fa2459c6920657e095a

driver unfinished write error code

This fatal log used to be hidden inside of a function (Parcel::remove)
which always failed, and so when it was removed, the error gained
context, but I failed to include other relevant information in the log,
such as the error code.

Bug: 154144726
Test: m only
Change-Id: I477aaee1a335a9faf8c9b249a97c979c08bc4ebf

IPCThreadState.cpp

diff --git a/IPCThreadState.cpp b/IPCThreadState.cpp
index 6de17cb..2f4464d 100644
--- a/IPCThreadState.cpp
+++ b/IPCThreadState.cpp
@@ -963,7 +963,11 @@
     if (err >= NO_ERROR) {
         if (bwr.write_consumed > 0) {
             if (bwr.write_consumed < mOut.dataSize())
-                LOG_ALWAYS_FATAL("Driver did not consume write buffer");
+                LOG_ALWAYS_FATAL("Driver did not consume write buffer. "
+                                 "err: %s consumed: %zu of %zu",
+                                 statusToString(err).c_str(),
+                                 (size_t)bwr.write_consumed,
+                                 mOut.dataSize());
             else {
                 mOut.setDataSize(0);
                 processPostWriteDerefs();