commit 91db8678ab9929a89ee64e2604dc775930b18b61
author Devin Moore <devinmoore@google.com> Fri Sep 01 16:36:30 2023 +0000
committer Devin Moore <devinmoore@google.com> Wed Sep 06 17:48:21 2023 +0000
tree e4761e4ea130383fe4b72d86e5e6e0941bd14c8f
parent e9a6a01d789f6c044e30f3145ac9fd95c0e909c7

Add log to find issue with missing hwservicemanager easier

Without a log, the fail case for an upgrading device that still requires
HIDL services can be very hard to determine. This warning log will help
determine when this is the case.

Test: launch_cvd without hwservicemanager
Bug: 275622588
Change-Id: I4237939e362962d2a426a2dfa7645dd585ebdc82

transport/ServiceManagement.cpp

diff --git a/transport/ServiceManagement.cpp b/transport/ServiceManagement.cpp
index a5ad23e..78c1e96 100644
--- a/transport/ServiceManagement.cpp
+++ b/transport/ServiceManagement.cpp
@@ -324,6 +324,11 @@
 
         if (!isHwServiceManagerInstalled()) {
             // hwservicemanager is not available on this device.
+            LOG(WARNING)
+                    << "hwservicemanager is not installed on the device. If HIDL support "
+                    << "is still needed, hwservicemanager and android.hidl.allocator@1.0-service "
+                    << "need to be added to the device's PRODUCT_PACKAGES and the kernel config "
+                    << "needs to have 'hwbinder' in CONFIG_ANDROID_BINDER_DEVICES.";
             gDefaultServiceManager = sp<NoHwServiceManager>::make();
             return gDefaultServiceManager;
         }