commit 823296f0634af024b4ac3d8f83df0a24c14ccdec
author Steven Moreland <smoreland@google.com> Tue Aug 07 21:36:35 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Aug 07 21:36:35 2018 +0000
tree a32a16bb93610d304c11a2b95c0b3c4f26663057
parent b4187b61060d36334a0780bdcea9f01504e12540
parent 128040a16d5ed83da9b4fb2c6f562e932fa99619

Merge "Begin cleanup of HidlBinderSupport.h includes."

transport/HidlBinderSupport.cpp

diff --git a/transport/HidlBinderSupport.cpp b/transport/HidlBinderSupport.cpp
index cd05c3d..add1f5e 100644
--- a/transport/HidlBinderSupport.cpp
+++ b/transport/HidlBinderSupport.cpp
@@ -19,6 +19,7 @@
 #include <hidl/HidlBinderSupport.h>
 
 #include <InternalStatic.h>  // TODO(b/69122224): remove this include, for getOrCreateCachedBinder
+#include <hwbinder/IPCThreadState.h>
 
 // C includes
 #include <unistd.h>

transport/HidlTransportSupport.cpp

diff --git a/transport/HidlTransportSupport.cpp b/transport/HidlTransportSupport.cpp
index 9c2bf25..b214f1a 100644
--- a/transport/HidlTransportSupport.cpp
+++ b/transport/HidlTransportSupport.cpp
@@ -13,9 +13,11 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-#include <hidl/HidlTransportSupport.h>
 #include <hidl/HidlBinderSupport.h>
+#include <hidl/HidlTransportSupport.h>
+#include <hidl/Static.h>
 
+#include <android-base/logging.h>
 #include <android/hidl/manager/1.0/IServiceManager.h>
 
 namespace android {
@@ -41,20 +43,20 @@
 bool setMinSchedulerPolicy(const sp<::android::hidl::base::V1_0::IBase>& service,
                            int policy, int priority) {
     if (service->isRemote()) {
-        ALOGE("Can't set scheduler policy on remote service.");
+        LOG(ERROR) << "Can't set scheduler policy on remote service.";
         return false;
     }
 
     if (policy != SCHED_NORMAL && policy != SCHED_FIFO && policy != SCHED_RR) {
-        ALOGE("Invalid scheduler policy %d", policy);
+        LOG(ERROR) << "Invalid scheduler policy " << policy;
         return false;
     }
 
     if (policy == SCHED_NORMAL && (priority < -20 || priority > 19)) {
-        ALOGE("Invalid priority for SCHED_NORMAL: %d", priority);
+        LOG(ERROR) << "Invalid priority for SCHED_NORMAL: " << priority;
         return false;
     } else if (priority < 1 || priority > 99) {
-        ALOGE("Invalid priority for real-time policy: %d", priority);
+        LOG(ERROR) << "Invalid priority for real-time policy: " << priority;
         return false;
     }
 

transport/include/hidl/HidlBinderSupport.h

diff --git a/transport/include/hidl/HidlBinderSupport.h b/transport/include/hidl/HidlBinderSupport.h
index 97d185e..8fe1450 100644
--- a/transport/include/hidl/HidlBinderSupport.h
+++ b/transport/include/hidl/HidlBinderSupport.h
@@ -24,11 +24,10 @@
 #include <hidl/HidlSupport.h>
 #include <hidl/HidlTransportUtils.h>
 #include <hidl/MQDescriptor.h>
-#include <hidl/Static.h>
 #include <hwbinder/IBinder.h>
-#include <hwbinder/IPCThreadState.h>
 #include <hwbinder/Parcel.h>
-#include <hwbinder/ProcessState.h>
+#include <log/log.h>  // TODO(b/65843592): remove. Too many users depending on this transitively.
+
 // Defines functions for hidl_string, hidl_version, Status, hidl_vec, MQDescriptor,
 // etc. to interact with Parcel.