commit ebbda48faa9694299b66cef2f0a3826ec6dadb63
author Yabin Cui <yabinc@google.com> Thu Aug 25 14:43:12 2022 -0700
committer Yabin Cui <yabinc@google.com> Thu Aug 25 14:50:15 2022 -0700
tree 42d19836c07b599054bde49f5ecbb0ca403df3a4
parent 5d35f427c877a98f313044b864c606de4efc3b71

simpleperf: fix a heap buffer overflow reported by hwasan.

The kallsyms field in KernelSymbolRecord may not end with '\0'.
So we should use kallsyms_size when building std::string.

Bug: 237255120
Test: run simpleperf_unit_test
Change-Id: I62bcf81ae58756885f3d5f0a4a5a51edcdb3e3d2

simpleperf/thread_tree.cpp

diff --git a/simpleperf/thread_tree.cpp b/simpleperf/thread_tree.cpp
index 2898722..be346a8 100644
--- a/simpleperf/thread_tree.cpp
+++ b/simpleperf/thread_tree.cpp
@@ -398,7 +398,7 @@
     ExitThread(r.data->pid, r.data->tid);
   } else if (record.type() == SIMPLE_PERF_RECORD_KERNEL_SYMBOL) {
     const auto& r = *static_cast<const KernelSymbolRecord*>(&record);
-    Dso::SetKallsyms(std::move(r.kallsyms));
+    Dso::SetKallsyms(std::string(r.kallsyms, r.kallsyms_size));
   }
 }