commit 2658a27ac27defed751ebffed305cdfef0cffdb3
author Treehugger Robot <treehugger-gerrit@google.com> Wed Feb 12 00:01:49 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Feb 12 00:01:49 2020 +0000
tree 143b5e17a93e3108ff2af86d854346024278d435
parent 49220d1ad49bf4f0a141b4a2503abe8b661c7813
parent 3c5692007b8f7d0ca15fb6547871487a2fe73953

Merge "Fix clang-tidy performance-faster-string-find warnings"

simpleperf/event_type.cpp

diff --git a/simpleperf/event_type.cpp b/simpleperf/event_type.cpp
index c9eaa75..71c3d9f 100644
--- a/simpleperf/event_type.cpp
+++ b/simpleperf/event_type.cpp
@@ -161,7 +161,7 @@
   //   # cat armv8_pmuv3/events/cpu_cycles
   //   event=0x011
   for (auto& s : android::base::Split(event_str, ",")) {
-    auto pos = s.find("=");
+    auto pos = s.find('=');
     if (pos == std::string::npos)
       continue;
 
@@ -229,7 +229,7 @@
   if (!IsPmuEvent())
     return empty_result;
 
-  std::string pmu = name.substr(0, name.find("/"));
+  std::string pmu = name.substr(0, name.find('/'));
   std::string cpumask_path = "/sys/bus/event_source/devices/" + pmu + "/cpumask";
   std::string cpumask_content;
   if (!android::base::ReadFileToString(cpumask_path, &cpumask_content)) {

simpleperf/event_type.h

diff --git a/simpleperf/event_type.h b/simpleperf/event_type.h
index d4ffecb..359438e 100644
--- a/simpleperf/event_type.h
+++ b/simpleperf/event_type.h
@@ -44,7 +44,7 @@
   }
 
   bool IsPmuEvent() const {
-    return name.find("/") != std::string::npos;
+    return name.find('/') != std::string::npos;
   }
 
   std::vector<int> GetPmuCpumask();