commit 06f0813b7f8efc5796fec2186a0cebd5666036d4
author Treehugger Robot <treehugger-gerrit@google.com> Tue Aug 14 18:12:07 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Aug 14 18:12:07 2018 +0000
tree 820fc08915b68ffe0625098df6e05b0075d1c90c
parent 093a9899500bd23c9434477316b02b5183151f8b
parent da07844be70cd8be2a6b465b503216cff6d05c29

Merge "Enable -Wimplicit-fallthrough"

simpleperf/Android.bp

diff --git a/simpleperf/Android.bp b/simpleperf/Android.bp
index 8c48096..bf96745 100644
--- a/simpleperf/Android.bp
+++ b/simpleperf/Android.bp
@@ -21,6 +21,7 @@
         "-Wall",
         "-Wextra",
         "-Werror",
+        "-Wimplicit-fallthrough",
 
         // Try some more extreme warnings.
         "-Wpedantic",

simpleperf/perf_regs.cpp

diff --git a/simpleperf/perf_regs.cpp b/simpleperf/perf_regs.cpp
index e654b6b..c238f07 100644
--- a/simpleperf/perf_regs.cpp
+++ b/simpleperf/perf_regs.cpp
@@ -123,7 +123,8 @@
       if (reg >= PERF_REG_X86_R8 && reg <= PERF_REG_X86_R15) {
         return android::base::StringPrintf("r%d", reg - PERF_REG_X86_R8 + 8);
       }
-    }  // go through
+      FALLTHROUGH_INTENDED;
+    }
     case ARCH_X86_32: {
       auto it = x86_reg_map.find(reg);
       CHECK(it != x86_reg_map.end()) << "unknown reg " << reg;