commit 5639d9ad6ef0157586bfb5df35056039b611a448
author Glenn Kasten <gkasten@google.com> Mon Oct 10 16:13:35 2016 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Mon Oct 10 16:13:36 2016 +0000
tree b164a784cdd435f7903a605e627d6a4061671c91
parent ae8cebf5ae0934d27360fea875a9fb69772ff5ff
parent 89579f241c5c5fda75420c5e21ca4a46879bee2f

Merge "Traverse /etc/init in a well-defined order" into nyc-mr1-dev

init/init_parser.cpp

diff --git a/init/init_parser.cpp b/init/init_parser.cpp
index b44ca59..f2e5d6d 100644
--- a/init/init_parser.cpp
+++ b/init/init_parser.cpp
@@ -122,14 +122,20 @@
         return false;
     }
     dirent* current_file;
+    std::vector<std::string> files;
     while ((current_file = readdir(config_dir.get()))) {
-        std::string current_path =
-            android::base::StringPrintf("%s/%s", path.c_str(), current_file->d_name);
         // Ignore directories and only process regular files.
         if (current_file->d_type == DT_REG) {
-            if (!ParseConfigFile(current_path)) {
-                ERROR("could not import file '%s'\n", current_path.c_str());
-            }
+            std::string current_path =
+                android::base::StringPrintf("%s/%s", path.c_str(), current_file->d_name);
+            files.emplace_back(current_path);
+        }
+    }
+    // Sort first so we load files in a consistent order (bug 31996208)
+    std::sort(files.begin(), files.end());
+    for (const auto& file : files) {
+        if (!ParseConfigFile(file)) {
+            ERROR("Could not import file '%s'\n", file.c_str());
         }
     }
     return true;