commit de2562151a764168b8d96167605acb3aa1986583
author Sailesh Nepal <sail@google.com> Thu Aug 25 13:03:29 2016 -0700
committer Sailesh Nepal <sail@google.com> Thu Aug 25 13:16:21 2016 -0700
tree add4af9a0a8d8cbe04cf7da6c1813b979c4cee28
parent b7b799a63147a222bd2d0a24fb77a324512616a2

Fix VoicemailChangePinActivity crash on dialog dismiss

The VoicemailChangePinActivity code would crash if the activity was torn
down before the async task finished. Fix was to check the activity state
before calling Dialog.dismiss().

Bug: 31068693
Change-Id: I0089f13ab8f0cc88b960b6733ba6176f77ce57fa

src/com/android/phone/settings/VoicemailChangePinActivity.java

diff --git a/src/com/android/phone/settings/VoicemailChangePinActivity.java b/src/com/android/phone/settings/VoicemailChangePinActivity.java
index 74adb12..8027dc1 100644
--- a/src/com/android/phone/settings/VoicemailChangePinActivity.java
+++ b/src/com/android/phone/settings/VoicemailChangePinActivity.java
@@ -629,7 +629,12 @@
 
         private void sendResult(@ChangePinResult int result) {
             VvmLog.i(TAG, "Change PIN result: " + result);
-            mProgressDialog.dismiss();
+            if (mProgressDialog.isShowing() && !VoicemailChangePinActivity.this.isDestroyed() &&
+                    !VoicemailChangePinActivity.this.isFinishing()) {
+                mProgressDialog.dismiss();
+            } else {
+                VvmLog.i(TAG, "Dialog not visible, not dismissing");
+            }
             mHandler.obtainMessage(MESSAGE_HANDLE_RESULT, result, 0).sendToTarget();
             releaseNetwork();
         }