commit 22b950d862c87ebced143045bdefbbc626787b88
author dcashman <dcashman@google.com> Mon Jun 27 11:39:02 2016 -0700
committer dcashman <dcashman@google.com> Mon Jun 27 12:49:43 2016 -0700
tree e259485018e447935b5f33b401a1bca0669c1912
parent 0a6f39747d1ccd645931aa5492987ceea1f6747e

Add DUMP permission check to phone service.

Bug: 29640401
Change-Id: I3cdb21c602deb81d91a2bd960332f14c19022822

src/com/android/phone/PhoneInterfaceManager.java

diff --git a/src/com/android/phone/PhoneInterfaceManager.java b/src/com/android/phone/PhoneInterfaceManager.java
index ed014d3..546f0f2 100644
--- a/src/com/android/phone/PhoneInterfaceManager.java
+++ b/src/com/android/phone/PhoneInterfaceManager.java
@@ -3297,6 +3297,15 @@
      */
     @Override
     protected void dump(FileDescriptor fd, PrintWriter writer, String[] args) {
+        if (mPhone.getContext().checkCallingOrSelfPermission(android.Manifest.permission.DUMP)
+                != PackageManager.PERMISSION_GRANTED) {
+            writer.println("Permission Denial: can't dump Phone from pid="
+                    + Binder.getCallingPid()
+                    + ", uid=" + Binder.getCallingUid()
+                    + "without permission "
+                    + android.Manifest.permission.DUMP);
+            return;
+        }
         DumpsysHandler.dump(mPhone.getContext(), fd, writer, args);
     }
 }