c57ce6dab - platform/packages/services/Car

commit	c57ce6dabd02c08abffeb35a06f493739c7a7197	[log] [tgz]
author	felipeal <felipeal@google.com>	Thu May 21 08:32:19 2020 -0700
committer	felipeal <felipeal@google.com>	Thu May 21 11:36:56 2020 -0700
tree	8ffa703953f9ebb368a816d9352657447acd6011
parent	90a0077cce36236e2d839da66104b408ae851f64 [diff]

A few unit testing improvements.

- Logged missing Mockito session (when it's supposed to be closed).
- Created AbstractExtendedMockitoCarServiceTestCase (for CarService-specific
  mocking).
- Added mockGetCarLocalService() (on AbstractExtendedMockitoCarServiceTestCase).
- Renamed CarUserManagerPermissionTest (to avoid ambiguity when running
  atest CarUserManagerTest).
- Replaced do..when by when..do (on CarUserNoticeServiceTest)
- Added a mockContextGetService() method (on AndroidMockitoHelper).

Test: atest CarUserManagerPermissionTest CarUserNoticeServiceTest
Bug: 154927360

Change-Id: Ibee985d53c97f6165ef6ff4ce77d6eb993051ac0

car-test-lib/src/android/car/test/mocks/AbstractExtendedMockitoTestCase.java[diff]
car-test-lib/src/android/car/test/mocks/AndroidMockitoHelper.java[diff]
tests/CarSecurityPermissionTest/src/com/android/car/user/CarUserManagerPermissionTest.java[Renamed from tests/CarSecurityPermissionTest/src/com/android/car/user/CarUserManagerTest.java - diff]
tests/carservice_unit_test/src/android/car/AbstractExtendedMockitoCarServiceTestCase.java[Added - diff]
tests/carservice_unit_test/src/com/android/car/user/CarUserNoticeServiceTest.java[diff]

5 files changed

tree: 8ffa703953f9ebb368a816d9352657447acd6011

README.md

Native (C++) code format is required to be compatible with .clang-format file. Run

git clang-format --style=file --extension='h,cpp,cc' HEAD~

Note that clang-format is not desirable for Android java files. Therefore the command line above is limited to specific extensions.