| commit | bf45e5606bbc08deed6e90755868c622cd1c3477 | [log] [tgz] |
|---|---|---|
| author | Lakshman Annadorai <lakshmana@google.com> | Mon Jan 31 20:23:57 2022 +0000 |
| committer | Lakshman Annadorai <lakshmana@google.com> | Thu Mar 03 19:08:41 2022 +0000 |
| tree | 3ce8ef6c40b1a622b5cb312755230a20eb57ab1e | |
| parent | f0d542c284f058ac71bef268fc3ca24c47bf66cb [diff] |
Move proc fs access check outside constructor. The car watchdog native daemon unittest, libwatchdog_test, is killed due to sepolicy violation. This violation happens when the unittest accesses proc fs files. Move the proc fs access check outside the constructors, so classes that depend on the proc fs collectors can mock them safely after calling the real constructors. - Update UidStatsCollector to check whether UidIoStatsCollector is enabled. - Refactor WatchdogPerfServiceTest to use a test class as it makes the tests cleaner. - Add missing GUARDED_BY statements in UidStatsCollector. Test: atest libwatchdog_test Bug: 216642418 Bug: 215711169 Change-Id: If750481cb95803253c2787c7e4459b68271bb8d7 Merged-In: If750481cb95803253c2787c7e4459b68271bb8d7 (cherry picked from commit 287c8fc74d88b0c781d1ba7808730df65e2f950e)
Native (C++) code format is required to be compatible with .clang-format file. Run
git clang-format --style=file --extension='h,cpp,cc' HEAD~
Note that clang-format is not desirable for Android java files. Therefore the command line above is limited to specific extensions.