commit | 768c8bfbe91db71e11eae2c57fb678ff2a5bf15e | [log] [tgz] |
---|---|---|
author | Kathan Shukla <kathan@google.com> | Thu Oct 22 12:08:22 2020 -0700 |
committer | android-build-team Robot <android-build-team-robot@google.com> | Wed Nov 18 22:51:46 2020 +0000 |
tree | 1bd61629a603622ec1f60ee173a1399f49030d78 | |
parent | 2a642ca97b60c0126ec5844659383fb5c894c7a0 [diff] |
Grpc Graph - fix use after free GrpcGraph initializes StreamSetObserver - which triggers a thread to notify GrpcGraph of termination. If GrpcGraph is destroyed, this will result in use after free. Fix this by enforcing that GrpcGraph object is not destroyed before StreamSetObserver. Bug: 170407229 Test: build, unit test and fuzz test Change-Id: I8b24f72af60c441ebd7a31939769c46589431cfe Merged-In: I8b24f72af60c441ebd7a31939769c46589431cfe (cherry picked from commit 3f53bf0525bd5c21ff6cc3235b93cb26a7866ea8)
Native (C++) code format is required to be compatible with .clang-format file. Run
git clang-format --style=file --extension='h,cpp,cc' HEAD~
Note that clang-format is not desirable for Android java files. Therefore the command line above is limited to specific extensions.