| commit | 4444ef50e7c1053b0a295086b22b07c1df66f115 | [log] [tgz] |
|---|---|---|
| author | François Gaffie <francois.gaffie@renault.com> | Wed May 11 15:26:57 2022 +0200 |
| committer | Oscar Azucena <oscarazu@google.com> | Sat Jul 02 00:48:29 2022 +0000 |
| tree | f5a9e6dbd431a5bf9c56181ccc1cb2ae5d84accb | |
| parent | 8f5183adf2775a59882aa272c037dba3ebcade21 [diff] |
CarAudioService: fix NPE while recursive handling of delayed request Audio Focus is hold transiently, then new request with delayed support (with reject rule) is done. Yet, another request with gain transient may duck (with concurrent rule vs initial focus holder and delayed holder). When the first request abandons the focus, handling of delayed is done twice. This recursivity leads to calling getClientId on null member has delayed request has been made null inbetween. This CL fixes this issue by clearing the delayed requestor before evaluating focus for it. Bug: b/232417355 Test: adb shell am instrument -w -e class com.android.car.audio.CarAudioFocusUnitTest com.android.car.carservice_unittest Signed-off-by: François Gaffie <francois.gaffie@renault.com> Change-Id: Ibdcd8fce77cb4c0f8ea81d6ea48bad84bc6c78f9
Source code for Android Automotive OS.
car_product/ - AAOS product
car-builtin-lib/ - A helper library for CarService to access hidden
framework APIs
car-lib/ - Car API
car-lib-module/ - Car API module
cpp/ - Native services
experimental/ - Experimental Car API and services
packages/ - Apps and services for cars
service/ - Car service module
service-builint - Platform builtin component that runs CarService module
tests/ - Tests and sample apps
tools/ - Helper scripts
Native (C++) code format is required to be compatible with .clang-format file. The formatter is already integrated to repo tool. To run manually, use:
git clang-format --style=file --extension='h,cpp,cc' HEAD~
Note that clang-format is not desirable for Android java files. Therefore the command line above is limited to specific extensions.