commit f720bc684b1a8332eb4d5f8d25c5feaf7eb54433
author Jeff Sharkey <jsharkey@android.com> Thu Jan 05 14:37:51 2012 -0800
committer Jeff Sharkey <jsharkey@android.com> Thu Jan 05 14:41:35 2012 -0800
tree d0806fb582fca54e82542697b0165dd6617f6ab9
parent a318a7fc77521dae0ea4afdc087dd30973e89f50

Allow downloads when no network restriction set.

Fixes bug where DownloadManager would block downloads on WiMAX,
bluetooth, and ethernet networks, even when no network restrictions
had been set.

Bug: 5689335
Change-Id: I6d1bb78cbccb3c5eb1fce40a13b0689be0c3fa13

src/com/android/providers/downloads/DownloadInfo.java

diff --git a/src/com/android/providers/downloads/DownloadInfo.java b/src/com/android/providers/downloads/DownloadInfo.java
index 00b1045..304d70f 100644
--- a/src/com/android/providers/downloads/DownloadInfo.java
+++ b/src/com/android/providers/downloads/DownloadInfo.java
@@ -397,8 +397,9 @@
      */
     private int checkIsNetworkTypeAllowed(int networkType) {
         if (mIsPublicApi) {
-            int flag = translateNetworkTypeToApiFlag(networkType);
-            if ((flag & mAllowedNetworkTypes) == 0) {
+            final int flag = translateNetworkTypeToApiFlag(networkType);
+            final boolean allowAllNetworkTypes = mAllowedNetworkTypes == ~0;
+            if (!allowAllNetworkTypes && (flag & mAllowedNetworkTypes) == 0) {
                 return NETWORK_TYPE_DISALLOWED_BY_REQUESTOR;
             }
         }