commit 3fcebdb5f33b27f884d43249664cf74d228812d1
author Andrew Walbran <qwandor@google.com> Wed Nov 30 11:16:17 2022 +0000
committer Andrew Walbran <qwandor@google.com> Tue May 09 14:35:48 2023 +0000
tree 1c96a6f65537505187b32a1b5108adbb0742d176
parent f714eeb4dffb9cdcfb72ddfceb3e6669f35cfd5e

Use ignorabletest for devicemapper tests.

Bug: 260692911
Test: atest libdm_rust.test
Change-Id: I847f7afd29739850dde5d1ae6f346d11277155af

libs/devicemapper/Android.bp

diff --git a/libs/devicemapper/Android.bp b/libs/devicemapper/Android.bp
index 9fa010c..b7cdedc 100644
--- a/libs/devicemapper/Android.bp
+++ b/libs/devicemapper/Android.bp
@@ -31,7 +31,10 @@
 
 rust_test {
     name: "libdm_rust.test",
-    defaults: ["libdm_rust.defaults"],
+    defaults: [
+        "libdm_rust.defaults",
+        "ignorabletest.defaults",
+    ],
     test_suites: ["general-tests"],
     rustlibs: [
         "librustutils",

libs/devicemapper/src/lib.rs

diff --git a/libs/devicemapper/src/lib.rs b/libs/devicemapper/src/lib.rs
index fec0114..984ceda 100644
--- a/libs/devicemapper/src/lib.rs
+++ b/libs/devicemapper/src/lib.rs
@@ -29,6 +29,7 @@
 //! A library to create device mapper spec & issue ioctls.
 
 #![allow(missing_docs)]
+#![cfg_attr(test, allow(unused))]
 
 use anyhow::{Context, Result};
 use data_model::DataInit;
@@ -232,9 +233,13 @@
 }
 
 #[cfg(test)]
+ignorabletest::test_main!(tests::all_tests());
+
+#[cfg(test)]
 mod tests {
     use super::*;
     use crypt::{CipherType, DmCryptTargetBuilder};
+    use ignorabletest::{list_tests, test};
     use rustutils::system_properties;
     use std::fs::{read, File, OpenOptions};
     use std::io::Write;
@@ -257,6 +262,13 @@
         different_key: b"drowgnolyllaergnolsetybowtytriht",
     };
 
+    list_tests! {all_tests: [
+        mapping_again_keeps_data_xts,
+        mapping_again_keeps_data_hctr2,
+        data_inaccessible_with_diff_key_xts,
+        data_inaccessible_with_diff_key_hctr2,
+    ]}
+
     // Create a file in given temp directory with given size
     fn prepare_tmpfile(test_dir: &Path, filename: &str, sz: u64) -> PathBuf {
         let filepath = test_dir.join(filename);
@@ -279,7 +291,6 @@
         Ok(())
     }
 
-    // TODO(b/260692911): Find a better way to skip a test instead of silently passing it.
     fn is_hctr2_supported() -> bool {
         // hctr2 is NOT enabled in kernel 5.10 or lower. We run Microdroid tests on kernel versions
         // 5.10 or above & therefore,  we don't really care to skip test on other versions.
@@ -292,28 +303,23 @@
         }
     }
 
-    #[test]
+    test!(mapping_again_keeps_data_xts);
     fn mapping_again_keeps_data_xts() {
         mapping_again_keeps_data(&KEY_SET_XTS, "name1");
     }
 
-    #[test]
+    test!(mapping_again_keeps_data_hctr2, ignore_if: !is_hctr2_supported());
     fn mapping_again_keeps_data_hctr2() {
-        if !is_hctr2_supported() {
-            return;
-        }
         mapping_again_keeps_data(&KEY_SET_HCTR2, "name2");
     }
-    #[test]
+
+    test!(data_inaccessible_with_diff_key_xts);
     fn data_inaccessible_with_diff_key_xts() {
         data_inaccessible_with_diff_key(&KEY_SET_XTS, "name3");
     }
 
-    #[test]
+    test!(data_inaccessible_with_diff_key_hctr2, ignore_if: !is_hctr2_supported());
     fn data_inaccessible_with_diff_key_hctr2() {
-        if !is_hctr2_supported() {
-            return;
-        }
         data_inaccessible_with_diff_key(&KEY_SET_HCTR2, "name4");
     }