commit 248ceefac6bae52e183305dd5f7c611241441eeb
author Tsung-Mao Fang <tmfang@google.com> Tue Apr 26 16:47:04 2022 +0800
committer Tsung-Mao Fang <tmfang@google.com> Wed Apr 27 23:37:02 2022 +0000
tree 593e048498b7d7617e81899213b7c749e7e9e425
parent 9dae1f702dcb9d0d385346941409cec88acbede6

Fix "All files access" footer hyperlink issue

Try to use standard footer preference API to make hyper link
work again.

Test: User can click on the hyper link and open next page.
Fix: 230002254
Change-Id: I2b33b6f28c086cde815cccd775f6216c89bf46b4

PermissionController/res/values/strings.xml

diff --git a/PermissionController/res/values/strings.xml b/PermissionController/res/values/strings.xml
index 82ea1b1..a2916cc 100644
--- a/PermissionController/res/values/strings.xml
+++ b/PermissionController/res/values/strings.xml
@@ -765,11 +765,8 @@
     <!-- Header for denied permissions/apps [CHAR LIMIT=40] -->
     <string name="denied_header">Not allowed</string>
 
-    <!-- Warning text shown in storage_footer [CHAR LIMIT=none] -->
-    <string name="storage_footer_warning_text">Some apps that provide essential functionality for your device can have a special access to all your files</string>
-
     <!-- Text of hyperlink shown in storage_footer [CHAR LIMIT=60] -->
-    <string name="storage_footer_hyperlink_text">See apps with all files access</string>
+    <string name="storage_footer_hyperlink_text">See more apps that can access all files</string>
 
     <!-- Time in days -->
     <string name="days">{count, plural,

PermissionController/src/com/android/permissioncontroller/permission/ui/handheld/PermissionAppsFragment.java

diff --git a/PermissionController/src/com/android/permissioncontroller/permission/ui/handheld/PermissionAppsFragment.java b/PermissionController/src/com/android/permissioncontroller/permission/ui/handheld/PermissionAppsFragment.java
index 6ac574b..1d92a6e 100644
--- a/PermissionController/src/com/android/permissioncontroller/permission/ui/handheld/PermissionAppsFragment.java
+++ b/PermissionController/src/com/android/permissioncontroller/permission/ui/handheld/PermissionAppsFragment.java
@@ -35,9 +35,6 @@
 import android.os.Looper;
 import android.os.UserHandle;
 import android.provider.Settings;
-import android.text.SpannableString;
-import android.text.SpannableStringBuilder;
-import android.text.style.ClickableSpan;
 import android.util.ArrayMap;
 import android.view.Menu;
 import android.view.MenuInflater;
@@ -303,20 +300,6 @@
         return sensorCard;
     }
 
-    private SpannableString getLinkToAllFilesAccess(Context context) {
-        ClickableSpan clickableSpan = new ClickableSpan() {
-            @Override
-            public void onClick(View widget) {
-                context.startActivity(
-                        new Intent(Settings.ACTION_MANAGE_ALL_FILES_ACCESS_PERMISSION));
-            }
-        };
-        SpannableString spannableString =
-                new SpannableString(getString(R.string.storage_footer_hyperlink_text));
-        spannableString.setSpan(clickableSpan, 0, spannableString.length(), 0);
-        return spannableString;
-    }
-
     private void addStorageFooterSeeAllFilesAccess() {
         PreferenceScreen screen = getPreferenceScreen();
         Context context = screen.getPreferenceManager().getContext();
@@ -331,10 +314,12 @@
         preference.setKey(STORAGE_FOOTER_PREFERENCE_KEY);
         preference.setIcon(Utils.applyTint(getActivity(), R.drawable.ic_info_outline,
                 android.R.attr.colorControlNormal));
-        preference.setSummary(new SpannableStringBuilder(
-                getString(R.string.storage_footer_warning_text))
-                .append("\n\n")
-                .append(getLinkToAllFilesAccess(context)));
+        preference.setLearnMoreText(getString(R.string.storage_footer_hyperlink_text));
+        preference.setLearnMoreAction(v -> {
+            context.startActivity(
+                    new Intent(Settings.ACTION_MANAGE_ALL_FILES_ACCESS_PERMISSION));
+        });
+
         preferenceCategory.addPreference(preference);
     }