commit 404c6882edc91a34f60cd56f724d745b06a73756
author Przemysław Szczepaniak <pszczepaniak@google.com> Fri Mar 17 16:01:05 2023 +0000
committer Przemysław Szczepaniak <pszczepaniak@google.com> Fri Mar 17 16:02:20 2023 +0000
tree 2e2a7e3a9fafa0c7bcfbccb190de66d7084e711e
parent 647b99a358126a2455953a57a1e2e645a710c648

Fix OOB read in parseInputs in ShimPreparedModel.cpp

Bug: 269455813
Test: built image
Change-Id: Ib93baacd45f394568eb789b5196a5d0b4e1edd41

shim_and_sl/ShimPreparedModel.cpp

diff --git a/shim_and_sl/ShimPreparedModel.cpp b/shim_and_sl/ShimPreparedModel.cpp
index 178cc1c..840d65a 100644
--- a/shim_and_sl/ShimPreparedModel.cpp
+++ b/shim_and_sl/ShimPreparedModel.cpp
@@ -85,6 +85,11 @@
     }
 
     const auto& model = mMainAndReferencedModels[0];
+
+    if (request.inputs.size() > model.getInputs().size()) {
+        return ErrorStatus::INVALID_ARGUMENT;
+    }
+
     // set inputs
     for (int i = 0; i < request.inputs.size(); ++i) {
         const auto& input = request.inputs[i];
@@ -107,6 +112,9 @@
         }
     }
 
+    if (request.outputs.size() > model.getOutputs().size()) {
+        return ErrorStatus::INVALID_ARGUMENT;
+    }
     // set outputs
     for (int i = 0; i < request.outputs.size(); ++i) {
         const auto& output = request.outputs[i];