commit 64ce77d5b5a76746dd9c0ae7cce16ca272e5e61f
author Steven Moreland <smoreland@google.com> Sat Feb 15 16:33:49 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Sat Feb 15 16:33:49 2020 +0000
tree cf46a175cbc6679ca5762bb8d75a8bb0197f1d08
parent 9844eb95e4494dc27f06dba257508ca192a47d0e
parent d0f5d52f18236eda30c08f05516725b2fb5db35a

Merge "Use SharedRefBase::make to allocate."

DnsResolverService.cpp

diff --git a/DnsResolverService.cpp b/DnsResolverService.cpp
index c4b42bc..12ac191 100644
--- a/DnsResolverService.cpp
+++ b/DnsResolverService.cpp
@@ -78,7 +78,8 @@
 binder_status_t DnsResolverService::start() {
     // TODO: Add disableBackgroundScheduling(true) after libbinder_ndk support it. b/126506010
     // NetdNativeService does call disableBackgroundScheduling currently, so it is fine now.
-    DnsResolverService* resolverService = new DnsResolverService();
+    std::shared_ptr<DnsResolverService> resolverService =
+            ::ndk::SharedRefBase::make<DnsResolverService>();
     binder_status_t status =
             AServiceManager_addService(resolverService->asBinder().get(), getServiceName());
     if (status != STATUS_OK) {

DnsResolverService.h

diff --git a/DnsResolverService.h b/DnsResolverService.h
index e484b3c..5b19cf0 100644
--- a/DnsResolverService.h
+++ b/DnsResolverService.h
@@ -61,8 +61,9 @@
     // Debug log command
     ::ndk::ScopedAStatus setLogSeverity(int32_t logSeverity) override;
 
-  private:
     DnsResolverService();
+
+  private:
     // TODO: Remove below items after libbiner_ndk supports check_permission.
     ::ndk::ScopedAStatus checkAnyPermission(const std::vector<const char*>& permissions);
 };