commit 008122d1cce3491c4fc991854ea7828447d94c6c
author Mike Yu <yumike@google.com> Tue Mar 08 17:23:11 2022 +0800
committer Mike Yu <yumike@google.com> Tue Mar 08 17:35:11 2022 +0800
tree 3cfd0c1358f2d65ae4fbcf762ca735b435f33d0c
parent b537dfdd39e6a57c73db121849dd13ffd2590f54

Don't log if resolv_gethostby{name,addr} return no error

To avoid log spam, log their return value if the value
is an error. The following logs won't be printed.

  GetHostByNameHandler::run: result: Success
  GetHostByAddrHandler::run: result: Success

Fix: 223115382
Test: adb shell ping dns.google, then check the log
Change-Id: I180936a2d66a47142726054f001281a7ecd56f00

DnsProxyListener.cpp

diff --git a/DnsProxyListener.cpp b/DnsProxyListener.cpp
index f901831..4dfb4a2 100644
--- a/DnsProxyListener.cpp
+++ b/DnsProxyListener.cpp
@@ -1159,7 +1159,9 @@
     event.set_latency_micros(latencyUs);
     event.set_event_type(EVENT_GETHOSTBYNAME);
 
-    LOG(DEBUG) << "GetHostByNameHandler::run: result: " << gai_strerror(rv);
+    if (rv) {
+        LOG(DEBUG) << "GetHostByNameHandler::run: result failed: " << gai_strerror(rv);
+    }
 
     bool success = true;
     if (hp) {
@@ -1314,7 +1316,9 @@
     event.set_latency_micros(latencyUs);
     event.set_event_type(EVENT_GETHOSTBYADDR);
 
-    LOG(DEBUG) << "GetHostByAddrHandler::run: result: " << gai_strerror(rv);
+    if (rv) {
+        LOG(DEBUG) << "GetHostByAddrHandler::run: result failed: " << gai_strerror(rv);
+    }
 
     bool success = true;
     if (hp) {