commit d9890e5cc41d1b8ec0e1f2a0d1871be73f8c7fc7
author Marie Janssen <jamuraa@google.com> Fri Apr 14 14:07:19 2017 -0700
committer Marie Janssen <jamuraa@google.com> Wed May 10 11:08:59 2017 -0700
tree 717e29f82420549c7f300d3280265cb6451bee8b
parent 8d6df8a3f3ab3084636b36b9d4157acb0dffae33

btif: GetItemAttributes can return no attributes

If there are no attributes available, it's possible to return zero
attributes from a GetItemAttributes request.

This is triggered by some carkits who are unhappy when they only get
titles back (the only required item) and ask for the rest of the
attributes (which we don't have).

Test: connect to honda carkit and get snoop logs to confirm
Bug: 36055995
Bug: 35956792
Change-Id: I5a31e206565d212e456111d8c6b542c7a1569e5a

system/btif/src/btif_rc.cc

diff --git a/system/btif/src/btif_rc.cc b/system/btif/src/btif_rc.cc
index 14c2011..87ed2a7 100644
--- a/system/btif/src/btif_rc.cc
+++ b/system/btif/src/btif_rc.cc
@@ -2449,16 +2449,11 @@
 
   memset(item_attrs, 0, sizeof(tAVRC_ATTR_ENTRY) * num_attr);
 
-  if (num_attr == 0) {
-    avrc_rsp.get_attrs.status = AVRC_STS_INTERNAL_ERR;
-    BTIF_TRACE_ERROR("%s: num_attr in rsp is 0, sending internal error: 0x%02X",
-                     __func__, avrc_rsp.get_attrs.status);
-  } else {
-    avrc_rsp.get_attrs.status = status_code_map[rsp_status];
-    if (rsp_status == BTRC_STS_NO_ERROR) {
-      fill_avrc_attr_entry(item_attrs, num_attr, p_attrs);
-    }
+  avrc_rsp.get_attrs.status = status_code_map[rsp_status];
+  if (rsp_status == BTRC_STS_NO_ERROR) {
+    fill_avrc_attr_entry(item_attrs, num_attr, p_attrs);
   }
+
   avrc_rsp.get_attrs.num_attrs = num_attr;
   avrc_rsp.get_attrs.p_attrs = item_attrs;
   avrc_rsp.get_attrs.pdu = AVRC_PDU_GET_ITEM_ATTRIBUTES;