commit 30eaf00f3c66ec110df62c94ba1907c9f4a5bf8a
author Daniel Nishi <dhnishi@google.com> Tue May 03 17:21:51 2016 -0700
committer Daniel Nishi <dhnishi@google.com> Tue May 03 17:21:51 2016 -0700
tree e79343672fa81cf8808e98f071bc04b0474a69c8
parent bf96779cbf24603de712856d6b646e30586714d7

Fix a bug where negative file sizes were being used.

Negative file sizes for packages occurs when the file size is either
unknown or if an error occurred during size calculation. As a result,
we can skip them for total freeable space calculations.

Bug: 28465884
Change-Id: I340d725a66a228fd94993781c5e8ef732a60a7b3

src/com/android/settings/deletionhelper/DeletionHelperFragment.java

diff --git a/src/com/android/settings/deletionhelper/DeletionHelperFragment.java b/src/com/android/settings/deletionhelper/DeletionHelperFragment.java
index 8871adb..ce467e3 100644
--- a/src/com/android/settings/deletionhelper/DeletionHelperFragment.java
+++ b/src/com/android/settings/deletionhelper/DeletionHelperFragment.java
@@ -254,8 +254,10 @@
         long freeableSpace = 0;
         for (int i = 0; i < mAppEntries.size(); i++) {
             final AppEntry entry = mAppEntries.get(i);
-            if (!mUncheckedApplications.contains(entry.label)) {
-                freeableSpace += mAppEntries.get(i).size;
+            long entrySize = mAppEntries.get(i).size;
+            // If the entrySize is negative, it is either an unknown size or an error occurred.
+            if (!mUncheckedApplications.contains(entry.label) && entrySize > 0) {
+                freeableSpace += entrySize;
             }
         }
         return freeableSpace;