commit 0308976e2fde1ac6ce9bf10da733ccca8973f645
author Yi-Ling Chuang <emilychuang@google.com> Mon Oct 07 10:24:27 2019 +0800
committer android-build-team Robot <android-build-team-robot@google.com> Wed Nov 20 00:24:28 2019 +0000
tree 909e31a2d71f778f26cc23bbea712998f7a1732c
parent 6b66f3cf5be90f2b17a2aacb962d2c59642accc0

Fix non responding slice toggling

The issue happens when users are toggling slices. Sometimes the toggle
doesn't work as expected because the pending intent of the toggle action
seems to be canceled for some reasons.

Hence, we replace FLAG_CANCEL_CURRENT with FLAG_UPDATE_CURRENT to
prevent from getting PendingIntent.CancelExcpetion from SliceActionView
when toggling slices.

This change only applies on those auto converted Slices.

Bug: 140719905
Test: toggle slices in Settings Search and NGA
Change-Id: Iff724ce5f6a1e6a7d9ca85b8ce76539a72e72964
Merged-In: Iff724ce5f6a1e6a7d9ca85b8ce76539a72e72964
(cherry picked from commit ddf6cefcaccf669150bb4d61e37c1d78ccbe91b0)
(cherry picked from commit e786ce000ea094196eac98098a098e71d19f3bf6)

src/com/android/settings/slices/SliceBuilderUtils.java

diff --git a/src/com/android/settings/slices/SliceBuilderUtils.java b/src/com/android/settings/slices/SliceBuilderUtils.java
index 0e51032..5585be3 100644
--- a/src/com/android/settings/slices/SliceBuilderUtils.java
+++ b/src/com/android/settings/slices/SliceBuilderUtils.java
@@ -173,7 +173,7 @@
                 .putExtra(EXTRA_SLICE_KEY, data.getKey())
                 .putExtra(EXTRA_SLICE_PLATFORM_DEFINED, data.isPlatformDefined());
         return PendingIntent.getBroadcast(context, 0 /* requestCode */, intent,
-                PendingIntent.FLAG_CANCEL_CURRENT);
+                PendingIntent.FLAG_UPDATE_CURRENT);
     }
 
     /**