commit 81469702f32be538b5efedbf65f6688785708153
author tiansiming <tiansiming@xiaomi.com> Sun Jan 14 16:46:05 2018 +0800
committer siming tian <tiansiming@xiaomi.com> Wed Jan 17 18:13:47 2018 +0000
tree 32aaf8e9f0072347d5fe9ab69a635ddfbfe3abf0
parent 43b1b97e3e6af8ce9abe3c4137c82eec249d70b4

Fix NPE crash in AppInfoBase

This crash can hardly happen under the normal operation of the user,
but it may have a chance to appear in monkey test. To enhance the 
robustness of the program, intent.getData() here should not be null 
in any situations.

Bug: N/A
Test: adb shell am start -n
'com.android.settings/.Settings\$AppDrawOverlaySettingsActivity'

Change-Id: I732b564056e3e585405f146d99efe3b410edbc41
Signed-off-by: tiansiming <tiansiming@xiaomi.com>

src/com/android/settings/applications/AppInfoBase.java

diff --git a/src/com/android/settings/applications/AppInfoBase.java b/src/com/android/settings/applications/AppInfoBase.java
index e422076..2aa3b0b 100644
--- a/src/com/android/settings/applications/AppInfoBase.java
+++ b/src/com/android/settings/applications/AppInfoBase.java
@@ -138,7 +138,7 @@
         if (mPackageName == null) {
             Intent intent = (args == null) ?
                     getActivity().getIntent() : (Intent) args.getParcelable("intent");
-            if (intent != null) {
+            if (intent != null && intent.getData() != null) {
                 mPackageName = intent.getData().getSchemeSpecificPart();
             }
         }