commit 60f21a8d3ab501eb5a4b29ff3d7eb94e86f8f0d8
author Kevin <kevhan@google.com> Fri Apr 12 15:52:23 2019 -0700
committer Kevin <kevhan@google.com> Wed Apr 17 11:16:22 2019 -0700
tree b66ecd2d0ced6352a184e1fd55ce3f01448d9d9e
parent 194c12aec76264bd23d364c662e02f9408c689c5

Fix ViewTreeObserver crash on Recents Go

The view tree we originally attach the onGlobalLayout listener to may no
longer be alive when we get the callback as the view tree observer
merges when the view attaches to a view hierarchy, giving us an
exception. Instead, we should request the view tree observer again and
remove it from there.

Bug: 130740246
Fix: 130740246
Test: Manual test, no longer crashes
Change-Id: Idb982022e72db75b8e20fd5bea00655212dc0258

go/quickstep/src/com/android/quickstep/views/IconRecentsView.java

diff --git a/go/quickstep/src/com/android/quickstep/views/IconRecentsView.java b/go/quickstep/src/com/android/quickstep/views/IconRecentsView.java
index 8661402..9688fdf 100644
--- a/go/quickstep/src/com/android/quickstep/views/IconRecentsView.java
+++ b/go/quickstep/src/com/android/quickstep/views/IconRecentsView.java
@@ -417,13 +417,12 @@
      * manage when the animation conflicts with another animation.
      */
     private void scheduleFadeInLayoutAnimation() {
-        ViewTreeObserver viewTreeObserver = mTaskRecyclerView.getViewTreeObserver();
-        viewTreeObserver.addOnGlobalLayoutListener(
+        mTaskRecyclerView.getViewTreeObserver().addOnGlobalLayoutListener(
                 new ViewTreeObserver.OnGlobalLayoutListener() {
                     @Override
                     public void onGlobalLayout() {
                         animateFadeInLayoutAnimation();
-                        viewTreeObserver.removeOnGlobalLayoutListener(this);
+                        mTaskRecyclerView.getViewTreeObserver().removeOnGlobalLayoutListener(this);
                     }
                 });
     }