commit 3ecbd81f99d2005172f431d2bf207b698154fe29
author Joe Onorato <joeo@android.com> Fri Dec 11 13:38:54 2009 -0800
committer Joe Onorato <joeo@android.com> Fri Dec 11 13:38:54 2009 -0800
tree 80d8abd61708e23b4c7f1268b43273aea408b9c3
parent 8cf34293dc2f078bf023ac77d007f5182f9b9357

Still trying to fix 2320348 - Launcher2 crashed: AIOOBE at com.android.launcher2.AllAppsView$RolloRS.removeApp

src/com/android/launcher2/AllAppsView.java

diff --git a/src/com/android/launcher2/AllAppsView.java b/src/com/android/launcher2/AllAppsView.java
index fa272b9..8d24ea3 100644
--- a/src/com/android/launcher2/AllAppsView.java
+++ b/src/com/android/launcher2/AllAppsView.java
@@ -658,11 +658,7 @@
     public void setApps(ArrayList<ApplicationInfo> list) {
         mAllAppsList = list;
         if (mRollo != null) {
-            if (mRollo.mHasSurface) {
-                mRollo.setApps(list);
-            } else {
-                mRollo.mAppsDirty = true;
-            }
+            mRollo.setApps(list);
         }
         mLocks &= ~LOCK_ICONS_PENDING;
     }
@@ -1084,7 +1080,13 @@
             mState.iconCount = count;
             for (int i=0; i < mState.iconCount; i++) {
                 createAppIconAllocations(i, list.get(i));
-                uploadAppIcon(i, list.get(i));
+            }
+            if (mHasSurface) {
+                for (int i=0; i < mState.iconCount; i++) {
+                    uploadAppIcon(i, list.get(i));
+                }
+            } else {
+                mRollo.mAppsDirty = true;
             }
             saveAppsList();
         }