commit f54724f87413091a1344bc7423236e97b6492030
author Chih-Hung Hsieh <chh@google.com> Thu Nov 02 10:24:36 2017 -0700
committer Chih-Hung Hsieh <chh@google.com> Thu Nov 02 11:00:16 2017 -0700
tree 3e9b62b166e7ccb461c7d76a97c30841b5b65602
parent ea2a43b6e82217b20190e8979160d931eae2b686

Use -Werror in packages/apps/Gallery2

* Keep constant-conversion warnings to fix later.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ib93e954e025fd2f0202960df20583b50b97fce7f

jni/Android.mk

diff --git a/jni/Android.mk b/jni/Android.mk
index 32c7163..55bb205 100644
--- a/jni/Android.mk
+++ b/jni/Android.mk
@@ -1,9 +1,16 @@
 LOCAL_PATH:= $(call my-dir)
 
+Gallery2_jni_cflags := \
+    -Wall -Wextra -Werror \
+    -Wno-error=constant-conversion \
+    -Wno-unused-parameter \
+
+# to fix implicit conversion from 'int' to 'char', (255 to -1, 128 to -128)
+
 include $(CLEAR_VARS)
 
-LOCAL_CFLAGS += -DEGL_EGLEXT_PROTOTYPES -Wno-unused-parameter
-LOCAL_CFLAGS += -Wall -Wextra
+LOCAL_CFLAGS += -DEGL_EGLEXT_PROTOTYPES
+LOCAL_CFLAGS += $(Gallery2_jni_cflags)
 
 LOCAL_SRC_FILES := jni_egl_fence.cpp
 
@@ -45,8 +52,8 @@
                    filters/tinyplanet.cc \
                    filters/kmeans.cc
 
-LOCAL_CFLAGS    += -ffast-math -O3 -funroll-loops -Wno-unused-parameter
-LOCAL_CFLAGS += -Wall -Wextra
+LOCAL_CFLAGS += -ffast-math -O3 -funroll-loops
+LOCAL_CFLAGS += $(Gallery2_jni_cflags)
 LOCAL_LDLIBS := -llog -ljnigraphics
 LOCAL_ARM_MODE := arm
 

jni_jpegstream/Android.mk

diff --git a/jni_jpegstream/Android.mk b/jni_jpegstream/Android.mk
index f3a631d..cac2a7b 100644
--- a/jni_jpegstream/Android.mk
+++ b/jni_jpegstream/Android.mk
@@ -17,7 +17,7 @@
 LOCAL_ARM_MODE := arm
 
 LOCAL_CFLAGS    += -ffast-math -O3 -funroll-loops
-LOCAL_CFLAGS += -Wall -Wextra
+LOCAL_CFLAGS += -Wall -Wextra -Werror
 LOCAL_LDLIBS := -llog
 
 LOCAL_CPP_EXTENSION := .cpp