commit 0b4eb5923070d89c7221498c831cb2d19e3da2dd
author Marc Blank <mblank@google.com> Thu Mar 10 16:57:16 2011 -0800
committer Marc Blank <mblank@google.com> Thu Mar 10 17:22:48 2011 -0800
tree 0c77e4f32d054baf8597b706322fb25224494f95
parent d0bb59f5d1c7e1d8b6c2350d3ad769a2073a0230

Clear cached CalendarObservers after Calendar wipe

* This fix may resolve the bugs referenced below; the issue fixed
  could cause pandemonium after the server commands a wipe of calendar
  data and most likely explains these issues (via Occam's Razor)

Bug: 4077499
Bug: 4064237
Change-Id: I628fb14ea2c04150d4f27341751f0eab61ee33d1

src/com/android/exchange/ExchangeService.java

diff --git a/src/com/android/exchange/ExchangeService.java b/src/com/android/exchange/ExchangeService.java
index 0e459d7..ffdbb82 100644
--- a/src/com/android/exchange/ExchangeService.java
+++ b/src/com/android/exchange/ExchangeService.java
@@ -209,8 +209,9 @@
     private EasSyncStatusObserver mSyncStatusObserver;
     private Object mStatusChangeListener;
 
-    private HashMap<Long, CalendarObserver> mCalendarObservers =
-        new HashMap<Long, CalendarObserver>();
+    // Concurrent because CalendarSyncAdapter can modify the map during a wipe
+    private ConcurrentHashMap<Long, CalendarObserver> mCalendarObservers =
+        new ConcurrentHashMap<Long, CalendarObserver>();
 
     private ContentResolver mResolver;
 
@@ -745,11 +746,14 @@
     /**
      * Unregister all CalendarObserver's
      */
-    private void unregisterCalendarObservers() {
-        for (CalendarObserver observer: mCalendarObservers.values()) {
-            mResolver.unregisterContentObserver(observer);
+    static public void unregisterCalendarObservers() {
+        ExchangeService exchangeService = INSTANCE;
+        if (exchangeService == null) return;
+        ContentResolver resolver = exchangeService.mResolver;
+        for (CalendarObserver observer: exchangeService.mCalendarObservers.values()) {
+            resolver.unregisterContentObserver(observer);
         }
-        mCalendarObservers.clear();
+        exchangeService.mCalendarObservers.clear();
     }
 
     /**

src/com/android/exchange/adapter/CalendarSyncAdapter.java

diff --git a/src/com/android/exchange/adapter/CalendarSyncAdapter.java b/src/com/android/exchange/adapter/CalendarSyncAdapter.java
index ea857ec..682fcba 100644
--- a/src/com/android/exchange/adapter/CalendarSyncAdapter.java
+++ b/src/com/android/exchange/adapter/CalendarSyncAdapter.java
@@ -24,6 +24,7 @@
 import com.android.exchange.Eas;
 import com.android.exchange.EasOutboxService;
 import com.android.exchange.EasSyncService;
+import com.android.exchange.ExchangeService;
 import com.android.exchange.utility.CalendarUtilities;
 import com.android.exchange.utility.Duration;
 
@@ -198,6 +199,8 @@
                 "=" + DatabaseUtils.sqlEscapeString(mEmailAddress) + " AND " +
                 Calendars._SYNC_ACCOUNT_TYPE + "=" +
                 DatabaseUtils.sqlEscapeString(AccountManagerTypes.TYPE_EXCHANGE), null);
+        // Invalidate our calendar observers
+        ExchangeService.unregisterCalendarObservers();
     }
 
     @Override