Merge "Update language to comply with Android's inclusive language guidance" am: 237d9b014c am: 45595d4753 am: 6b570f82d5
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/1378558
Change-Id: Ic7d60bf2531edb57089955191d597ec7667c9e11
diff --git a/java/com/android/dialer/app/list/PhoneFavoriteTileView.java b/java/com/android/dialer/app/list/PhoneFavoriteTileView.java
index f9f8e0e..7f0a6bc 100644
--- a/java/com/android/dialer/app/list/PhoneFavoriteTileView.java
+++ b/java/com/android/dialer/app/list/PhoneFavoriteTileView.java
@@ -57,7 +57,7 @@
// make room for the contact name and number label at the bottom of the image.
private static final float DEFAULT_IMAGE_LETTER_OFFSET = -0.12f;
private static final float DEFAULT_IMAGE_LETTER_SCALE = 0.70f;
- // Dummy clip data object that is attached to drag shadows so that text views
+ // Placeholder clip data object that is attached to drag shadows so that text views
// don't crash with an NPE if the drag shadow is released in their bounds
private static final ClipData EMPTY_CLIP_DATA = ClipData.newPlainText("", "");
/** View that contains the transparent shadow that is overlaid on top of the contact image. */
diff --git a/java/com/android/dialer/callcomposer/camera/CameraManager.java b/java/com/android/dialer/callcomposer/camera/CameraManager.java
index c61f570..e802cc2 100644
--- a/java/com/android/dialer/callcomposer/camera/CameraManager.java
+++ b/java/com/android/dialer/callcomposer/camera/CameraManager.java
@@ -85,7 +85,7 @@
private static final int NO_CAMERA_SELECTED = -1;
- private static final Camera.ShutterCallback DUMMY_SHUTTER_CALLBACK =
+ private static final Camera.ShutterCallback NOOP_SHUTTER_CALLBACK =
new Camera.ShutterCallback() {
@Override
public void onShutter() {
@@ -493,7 +493,7 @@
try {
this.camera.takePicture(
// A shutter callback is required to enable shutter sound
- DUMMY_SHUTTER_CALLBACK, null /* raw */, null /* postView */, jpegCallback);
+ NOOP_SHUTTER_CALLBACK, null /* raw */, null /* postView */, jpegCallback);
} catch (final RuntimeException e) {
LogUtil.e("CameraManager.takePicture", "RuntimeException in CameraManager.takePicture", e);
takingPicture = false;
diff --git a/java/com/android/dialer/contactphoto/ContactPhotoManagerImpl.java b/java/com/android/dialer/contactphoto/ContactPhotoManagerImpl.java
index cf42606..f7f79e1 100644
--- a/java/com/android/dialer/contactphoto/ContactPhotoManagerImpl.java
+++ b/java/com/android/dialer/contactphoto/ContactPhotoManagerImpl.java
@@ -92,7 +92,8 @@
private static final String[] COLUMNS = new String[] {Photo._ID, Photo.PHOTO};
/**
- * Dummy object used to indicate that a bitmap for a given key could not be stored in the cache.
+ * Placeholder object used to indicate that a bitmap for a given key could not be stored in the
+ * cache.
*/
private static final BitmapHolder BITMAP_UNAVAILABLE;
/** Cache size for {@link #bitmapHolderCache} for devices with "large" RAM. */
diff --git a/java/com/android/dialer/database/FilteredNumberContract.java b/java/com/android/dialer/database/FilteredNumberContract.java
index 3efbaaf..5a7153e 100644
--- a/java/com/android/dialer/database/FilteredNumberContract.java
+++ b/java/com/android/dialer/database/FilteredNumberContract.java
@@ -30,7 +30,7 @@
public static final Uri AUTHORITY_URI = Uri.parse("content://" + AUTHORITY);
- /** The type of filtering to be applied, e.g. block the number or whitelist the number. */
+ /** The type of filtering to be applied, e.g. block the number or allow the number. */
public interface FilteredNumberTypes {
int UNDEFINED = 0;
diff --git a/java/com/android/dialer/phonelookup/phone_lookup_info.proto b/java/com/android/dialer/phonelookup/phone_lookup_info.proto
index 6a97d3d..c0fa31d 100644
--- a/java/com/android/dialer/phonelookup/phone_lookup_info.proto
+++ b/java/com/android/dialer/phonelookup/phone_lookup_info.proto
@@ -140,7 +140,7 @@
}
optional PeopleApiInfo people_api_info = 3;
- // Whether a number is blocked or not. Used by both the system blacklist and
+ // Whether a number is blocked or not. Used by both the system block list and
// dialer fallback
enum BlockedState {
UNKNOWN = 0;
diff --git a/java/com/android/incallui/DtmfKeyListener.java b/java/com/android/incallui/DtmfKeyListener.java
index a2a0de0..330630a 100644
--- a/java/com/android/incallui/DtmfKeyListener.java
+++ b/java/com/android/incallui/DtmfKeyListener.java
@@ -55,8 +55,8 @@
* necessary to copy the implementation.
*
* <p>The Spannable is only used to determine which meta keys are pressed, e.g. shift, alt, see
- * {@link android.text.method.MetaKeyKeyListener#getMetaState(CharSequence)}, so using a dummy
- * value is fine here.
+ * {@link android.text.method.MetaKeyKeyListener#getMetaState(CharSequence)}, so using a
+ * placeholder value is fine here.
*/
private static final Spannable EMPTY_SPANNABLE = new SpannableString("");
diff --git a/java/com/android/incallui/answer/impl/utils/FlingAnimationUtils.java b/java/com/android/incallui/answer/impl/utils/FlingAnimationUtils.java
index baec308..b30afa0 100644
--- a/java/com/android/incallui/answer/impl/utils/FlingAnimationUtils.java
+++ b/java/com/android/incallui/answer/impl/utils/FlingAnimationUtils.java
@@ -32,7 +32,7 @@
private static final float MIN_VELOCITY_DP_PER_SECOND = 250;
private static final float HIGH_VELOCITY_DP_PER_SECOND = 3000;
- /** Crazy math. http://en.wikipedia.org/wiki/B%C3%A9zier_curve */
+ /** Fancy math. http://en.wikipedia.org/wiki/B%C3%A9zier_curve */
private static final float LINEAR_OUT_SLOW_IN_START_GRADIENT = 1.0f / LINEAR_OUT_SLOW_IN_X2;
private Interpolator linearOutSlowIn;
diff --git a/java/com/android/voicemail/impl/mail/FetchProfile.java b/java/com/android/voicemail/impl/mail/FetchProfile.java
index 28a7080..5b83fd8 100644
--- a/java/com/android/voicemail/impl/mail/FetchProfile.java
+++ b/java/com/android/voicemail/impl/mail/FetchProfile.java
@@ -56,10 +56,10 @@
STRUCTURE,
/**
- * A sane portion of the entire message, cut off at a provider determined limit. This should
- * generally be around 50kB.
+ * A truncated portion of the entire message, cut off at a provider determined limit. This
+ * should generally be around 50kB.
*/
- BODY_SANE,
+ BODY_TRUNCATED,
/** The entire message. */
BODY,
diff --git a/java/com/android/voicemail/impl/mail/store/ImapFolder.java b/java/com/android/voicemail/impl/mail/store/ImapFolder.java
index 3c76ec3..cd3803d 100644
--- a/java/com/android/voicemail/impl/mail/store/ImapFolder.java
+++ b/java/com/android/voicemail/impl/mail/store/ImapFolder.java
@@ -257,7 +257,7 @@
* ENVELOPE - UID FETCH (INTERNALDATE UID RFC822.SIZE FLAGS BODY.PEEK[
* HEADER.FIELDS (date subject from content-type to cc)])
* STRUCTURE - UID FETCH (BODYSTRUCTURE)
- * BODY_SANE - UID FETCH (BODY.PEEK[]<0.N>) where N = max bytes returned
+ * BODY_TRUNCATED - UID FETCH (BODY.PEEK[]<0.N>) where N = max bytes returned
* BODY - UID FETCH (BODY.PEEK[])
* Part - UID FETCH (BODY.PEEK[ID]) where ID = mime part ID
*/
@@ -277,8 +277,8 @@
fetchFields.add(ImapConstants.BODYSTRUCTURE);
}
- if (fp.contains(FetchProfile.Item.BODY_SANE)) {
- fetchFields.add(ImapConstants.FETCH_FIELD_BODY_PEEK_SANE);
+ if (fp.contains(FetchProfile.Item.BODY_TRUNCATED)) {
+ fetchFields.add(ImapConstants.FETCH_FIELD_BODY_PEEK_TRUNCATED);
}
if (fp.contains(FetchProfile.Item.BODY)) {
fetchFields.add(ImapConstants.FETCH_FIELD_BODY_PEEK);
@@ -363,7 +363,8 @@
}
}
}
- if (fp.contains(FetchProfile.Item.BODY) || fp.contains(FetchProfile.Item.BODY_SANE)) {
+ if (fp.contains(FetchProfile.Item.BODY)
+ || fp.contains(FetchProfile.Item.BODY_TRUNCATED)) {
// Body is keyed by "BODY[]...".
// Previously used "BODY[..." but this can be confused with "BODY[HEADER..."
// TODO Should we accept "RFC822" as well??
diff --git a/java/com/android/voicemail/impl/mail/store/ImapStore.java b/java/com/android/voicemail/impl/mail/store/ImapStore.java
index 6b88080..44b78be 100644
--- a/java/com/android/voicemail/impl/mail/store/ImapStore.java
+++ b/java/com/android/voicemail/impl/mail/store/ImapStore.java
@@ -30,9 +30,9 @@
public class ImapStore {
/**
* A global suggestion to Store implementors on how much of the body should be returned on
- * FetchProfile.Item.BODY_SANE requests. We'll use 125k now.
+ * FetchProfile.Item.BODY_TRUNCATED requests. We'll use 125k now.
*/
- public static final int FETCH_BODY_SANE_SUGGESTED_SIZE = (125 * 1024);
+ public static final int FETCH_BODY_TRUNCATED_SUGGESTED_SIZE = (125 * 1024);
private final Context context;
private final ImapHelper helper;
diff --git a/java/com/android/voicemail/impl/mail/store/imap/ImapConstants.java b/java/com/android/voicemail/impl/mail/store/imap/ImapConstants.java
index fd56952..2dc2254 100644
--- a/java/com/android/voicemail/impl/mail/store/imap/ImapConstants.java
+++ b/java/com/android/voicemail/impl/mail/store/imap/ImapConstants.java
@@ -24,8 +24,8 @@
public static final String FETCH_FIELD_BODY_PEEK_BARE = "BODY.PEEK";
public static final String FETCH_FIELD_BODY_PEEK = FETCH_FIELD_BODY_PEEK_BARE + "[]";
- public static final String FETCH_FIELD_BODY_PEEK_SANE =
- String.format(Locale.US, "BODY.PEEK[]<0.%d>", ImapStore.FETCH_BODY_SANE_SUGGESTED_SIZE);
+ public static final String FETCH_FIELD_BODY_PEEK_TRUNCATED =
+ String.format(Locale.US, "BODY.PEEK[]<0.%d>", ImapStore.FETCH_BODY_TRUNCATED_SUGGESTED_SIZE);
public static final String FETCH_FIELD_HEADERS =
"BODY.PEEK[HEADER.FIELDS (date subject from content-type to cc message-id content-duration)]";
diff --git a/java/com/android/voicemail/impl/mail/store/imap/ImapTempFileLiteral.java b/java/com/android/voicemail/impl/mail/store/imap/ImapTempFileLiteral.java
index 417adcc..f452c9d 100644
--- a/java/com/android/voicemail/impl/mail/store/imap/ImapTempFileLiteral.java
+++ b/java/com/android/voicemail/impl/mail/store/imap/ImapTempFileLiteral.java
@@ -74,7 +74,7 @@
// It's probably possible if we're low on storage and the system clears the cache dir.
LogUtils.w(TAG, "ImapTempFileLiteral: Temp file not found");
- // Return 0 byte stream as a dummy...
+ // Return 0 byte stream as a placeholder...
return new ByteArrayInputStream(new byte[0]);
}
}
